Skip to contentSkip to conversation

Fix UVD/VCN IB detection.

PATCH In review Tom St Denis 2 participants 3 messages Aug 25, 2017 2 messages not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 Fix UVD/VCN IB detection.

Since we add the IP name to the register names we
need to strip that off again.

---
 src/lib/ring_decode.c | 4 ++++
 1 file changed, 4 insertions(+)
src/lib/ring_decode.c +4 -0
index 9d6e366e4594..52855ab4fb62 100644
@@ -748,6 +748,10 @@ static void print_decode_pm4(struct umr_asic *asic, struct umr_ring_decoder *dec
 			name = umr_reg_name(asic, decoder->pm4.next_write_mem.addr_lo);
 			printf("   word (%lu): %s(0x%lx) <= 0x%lx", (unsigned long)decoder->pm4.cur_word++, name, (unsigned long)decoder->pm4.next_write_mem.addr_lo, (unsigned long)ib);
 
+			// strip off IP name
+			name = strstr(name, ".");
+			if (name[0] == '.') ++name;
+
 			// detect VCN/UVD IBs and chain them once all
 			// 4 pieces of information are found
 			if (!strcmp(name, "mmUVD_LMI_RBC_IB_VMID")) {
Signature · 6 lines
2.12.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

PATCH 2/2 Add SI/CIK to read_vram.

Tested with my Tahiti device.

---
 src/lib/read_vram.c | 2 ++
 1 file changed, 2 insertions(+)
src/lib/read_vram.c +2 -0
index f2c3a15c27fe..c254f5a2e406 100644
@@ -815,6 +815,8 @@ int umr_read_vram(struct umr_asic *asic, uint32_t vmid, uint64_t address, uint32
 	}
 
 	switch (asic->family) {
+		case FAMILY_SI:
+		case FAMILY_CIK:
 		case FAMILY_VI:
 			return umr_read_vram_vi(asic, vmid, address, size, dst);
 		case FAMILY_RV:
Signature · 6 lines
2.12.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

Reviewed-by Alex Deucher
#4 lore raw

RE: [PATCH umr 2/2] Add SI/CIK to read_vram.

Quoted 11 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Tom St Denis
Sent: Friday, August 25, 2017 8:56 AM
To: [email protected]
Cc: StDenis, Tom
Subject: [PATCH umr 2/2] Add SI/CIK to read_vram.

Tested with my Tahiti device.

Series is:

Quoted 22 lines
---
 src/lib/read_vram.c | 2 ++
 1 file changed, 2 insertions(+)
src/lib/read_vram.c +0 -0
index f2c3a15c27fe..c254f5a2e406 100644
@@ -815,6 +815,8 @@ int umr_read_vram(struct umr_asic *asic, uint32_t

vmid, uint64_t address, uint32

src/lib/read_vram.c +2 -0
 	}
 
 	switch (asic->family) {
+		case FAMILY_SI:
+		case FAMILY_CIK:
 		case FAMILY_VI:
 			return umr_read_vram_vi(asic, vmid, address, size,

dst);
case FAMILY_RV:
--
2.12.0

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx