staging: typec: tcpm: Check for port type for Try.SRC/Try.SNK

PATCH Superseded Badhri Jagan Sridharan 1 participant 1 message Aug 27, 2017 Staging

Share & tools

Badhri Jagan Sridharan

author

2017-08-27 06:41 UTC #0 lore raw

PATCH v2 2/11 staging: typec: tcpm: Check for port type for Try.SRC/Try.SNK

Enable Try.SRC or Try.SNK only when port_type is
DRP. Try.SRC or Try.SNK state machines are not
valid for SRC only or SNK only ports.

Signed-off-by Badhri Jagan Sridharan <[email protected]>

---
Changelog since v1:
- Corrected tag

 drivers/staging/typec/tcpm.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

drivers/staging/typec/tcpm.c +4 -2

index 6c045ac9c42a..1219e3bc13ef 100644
@@ -328,10 +328,12 @@ struct pd_rx_event {
 	 (tcpm_cc_is_audio((port)->cc2) && tcpm_cc_is_open((port)->cc1)))
 
 #define tcpm_try_snk(port) \
-	((port)->try_snk_count == 0 && (port)->try_role == TYPEC_SINK)
+	((port)->try_snk_count == 0 && (port)->try_role == TYPEC_SINK && \
+	(port)->port_type == TYPEC_PORT_DRP)
 
 #define tcpm_try_src(port) \
-	((port)->try_src_count == 0 && (port)->try_role == TYPEC_SOURCE)
+	((port)->try_src_count == 0 && (port)->try_role == TYPEC_SOURCE && \
+	(port)->port_type == TYPEC_PORT_DRP)
 
 static enum tcpm_state tcpm_default_state(struct tcpm_port *port)
 {

Signature · 1 line

2.14.1.342.g6490525c54-goog