lib/igt_debugfs: Open DRM driver without master for hpd storm exit
PATCH 1/1 lib/igt_debugfs: Open DRM driver without master for hpd storm exit
When running the full chamelium test binary, it occurs that the hpd storm exit handler (that restores its initial value) will fail when trying to acquire DRM master.
This happens even though the previously-held DRM file descriptor was closed already.
Since there is no need to get DRM master for debugfs access purposes, open the DRM node without requesting master to fix the issue.
--- lib/igt_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/igt_debugfs.c +1 -1
@@ -579,7 +579,7 @@ void igt_require_pipe_crc(int fd)static void igt_hpd_storm_exit_handler (int sig) { -int fd =drm_open_driver_master (DRIVER_INTEL ); +int fd =drm_open_driver (DRIVER_INTEL );/* Here we assume that only one i915 device will be ever present */ igt_hpd_storm_reset (fd);
Signature · 6 lines
2.14.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for lib/igt_debugfs: Open DRM driver without master for hpd storm exit
== Series Details ==
== Series Details ==
Series: lib/igt_debugfs: Open DRM driver without master for hpd storm exit
URL : https://patchwork.freedesktop.org/series/29470/
State : success
== Summary ==
IGT patchset tested on top of latest successful build bf45d253648250fc402eee02237366c8882b2053 igt: Add gem_close
with latest DRM-Tip kernel build CI_DRM_3014627598734e5e drm-tip: 2017y-08m-29d-09h-52m-12s UTC integration manifest
Test kms_flip:
Subgroup basic-flip-vs-modeset:
skip -> PASS (fi-skl-x1585l) fdo#101781
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
dmesg-warn -> PASS (fi-byt-j1900) fdo#101705fdo#101781 https://bugs.freedesktop.org/show_bug.cgi?id=101781
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:453s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:439s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:366s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:564s fi-bwr-2160 total:279 pass:184 dwarn:0 dfail:0 fail:0 skip:95 time:254s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:525s fi-byt-j1900 total:279 pass:255 dwarn:0 dfail:0 fail:0 skip:24 time:525s fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:520s fi-elk-e7500 total:279 pass:230 dwarn:0 dfail:0 fail:0 skip:49 time:446s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:615s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:445s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:426s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:423s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:501s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:470s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:478s fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:595s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:602s fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:528s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:465s fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:486s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:491s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:448s fi-skl-x1585l total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:505s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:551s fi-snb-2600 total:279 pass:249 dwarn:0 dfail:0 fail:1 skip:29 time:406s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_117/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for lib/igt_debugfs: Open DRM driver without master for hpd storm exit
In reply to Paul Kocialkowski== Series Details ==
== Series Details ==
Series: lib/igt_debugfs: Open DRM driver without master for hpd storm exit
URL : https://patchwork.freedesktop.org/series/29470/
State : success
== Summary ==
Test kms_atomic_transition:
Subgroup plane-all-transition-fencing:
skip -> PASS (shard-hsw)
Test perf:
Subgroup blocking:
fail -> PASS (shard-hsw) fdo#102252 +1
Test kms_setmode:
Subgroup basic:
pass -> FAIL (shard-hsw) fdo#99912
Test vgem_basic:
Subgroup unload:
skip -> PASS (shard-hsw) fdo#102453
Test kms_plane:
Subgroup plane-panning-bottom-right-suspend-pipe-C-planes:
skip -> PASS (shard-hsw)
Subgroup plane-position-hole-dpms-pipe-C-planes:
skip -> PASS (shard-hsw)
Test kms_properties:
Subgroup plane-properties-legacy:
skip -> PASS (shard-hsw)fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#102453 https://bugs.freedesktop.org/show_bug.cgi?id=102453
shard-hsw total:2230 pass:1232 dwarn:0 dfail:0 fail:17 skip:981 time:9575s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_117/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
R-B'd and pushed, thanks!
Quoted 29 lines · Paul Kocialkowski
When running the full chamelium test binary, it occurs that the hpd storm exit handler (that restores its initial value) will fail when trying to acquire DRM master.
This happens even though the previously-held DRM file descriptor was closed already.
Since there is no need to get DRM master for debugfs access purposes, open the DRM node without requesting master to fix the issue.
Signed-off-by Paul Kocialkowski <[email protected]>--- lib/igt_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/igt_debugfs.c +1
-1@@ -579,7 +579,7 @@ void igt_require_pipe_crc(int fd)static void igt_hpd_storm_exit_handler (int sig) { -int fd =drm_open_driver_master (DRIVER_INTEL ); +int fd =drm_open_driver (DRIVER_INTEL );/* Here we assume that only one i915 device will be ever present */
igt_hpd_storm_reset(fd);
Signature · 6 lines
Cheers, Lyude _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx