drm/i915/cnl: WaDisableI2mCycleOnWRPort
Subsystems (2)
Rodrigo Vivi
maintainerPATCH 1/1 drm/i915/cnl: WaDisableI2mCycleOnWRPort
On CNL B0 stepping GAM is not able to detect some deadlock condition and then rise the rise the gam_coh_flush.
WA database and spec both mentions to set 4AB8[24]=1 as workaround. Alghouth register offset 0x4AB8 is not documented for any platform.
--- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_engine_cs.c | 5 +++++ 2 files changed, 6 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +1 -0
@@ -2373,6 +2373,7 @@ enum i915_power_well_id {#define GAMT_CHKN_BIT_REG _MMIO(0x4ab8)#define GAMT_CHKN_DISABLE_DYNAMIC_CREDIT_SHARING (1<<28) +#define GAMT_CHKN_DISABLE_I2M_CYCLE_ON_WR_PORT (1<<24)#if 0 #define PRB0_TAIL _MMIO(0x2030)
drivers/gpu/drm/i915/intel_engine_cs.c +5 -0
@@ -1070,6 +1070,11 @@ static int cnl_init_workarounds(struct intel_engine_cs *engine)struct drm_i915_private *dev_priv = engine->i915;int ret; +/* WaDisableI2mCycleOnWRPort: cnl (pre-prod) */ +if (IS_CNL_REVID (dev_priv,CNL_REVID_B0 ,CNL_REVID_B0 )) +WA_SET_BIT (GAMT_CHKN_BIT_REG , +GAMT_CHKN_DISABLE_I2M_CYCLE_ON_WR_PORT ); +/* WaForceContextSaveRestoreNonCoherent:cnl */ WA_SET_BIT_MASKED (CNL_HDC_CHICKEN0 ,HDC_FORCE_CONTEXT_SAVE_RESTORE_NON_COHERENT );
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/cnl: WaDisableI2mCycleOnWRPort
== Series Details ==
== Series Details ==
Series: drm/i915/cnl: WaDisableI2mCycleOnWRPort
URL : https://patchwork.freedesktop.org/series/29506/
State : success
== Summary ==
Series 29506v1 drm/i915/cnl: WaDisableI2mCycleOnWRPort
https://patchwork.freedesktop.org/api/1.0/series/29506/revisions/1/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
pass -> FAIL (fi-snb-2600) fdo#100007
Test gem_ringfill:
Subgroup basic-default-hang:
incomplete -> DMESG-WARN (fi-pnv-d510) fdo#101600
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-legacy:
pass -> FAIL (fi-snb-2600) fdo#100215
Test kms_flip:
Subgroup basic-flip-vs-modeset:
pass -> SKIP (fi-skl-x1585l) fdo#101781
Test kms_frontbuffer_tracking:
Subgroup basic:
dmesg-warn -> PASS (fi-bdw-5557u)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
dmesg-warn -> PASS (fi-byt-n2820) fdo#101705fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#101600 https://bugs.freedesktop.org/show_bug.cgi?id=101600
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#101781 https://bugs.freedesktop.org/show_bug.cgi?id=101781
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:455s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:358s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:548s fi-bwr-2160 total:279 pass:184 dwarn:0 dfail:0 fail:0 skip:95 time:255s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:518s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:521s fi-byt-n2820 total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:519s fi-elk-e7500 total:279 pass:230 dwarn:0 dfail:0 fail:0 skip:49 time:437s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:611s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:446s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:423s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:421s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:501s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:471s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:473s fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:591s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:596s fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:524s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:472s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:484s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:443s fi-skl-x1585l total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:482s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:548s fi-snb-2600 total:279 pass:248 dwarn:0 dfail:0 fail:2 skip:29 time:409s
fi-bdw-gvtdvm failed to connect after reboot
428ed27345fbf9be530d01ca6dc862eb5895db81 drm-tip: 2017y-08m-29d-17h-43m-11s UTC integration manifest a1d60281b605 drm/i915/cnl: WaDisableI2mCycleOnWRPort
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5531/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915/cnl: WaDisableI2mCycleOnWRPort
In reply to Rodrigo Vivi== Series Details ==
== Series Details ==
Series: drm/i915/cnl: WaDisableI2mCycleOnWRPort
URL : https://patchwork.freedesktop.org/series/29506/
State : success
== Summary ==
Test kms_cursor_legacy:
Subgroup short-flip-before-cursor-atomic-transitions-varying-size:
skip -> PASS (shard-hsw)
Test perf:
Subgroup polling:
pass -> FAIL (shard-hsw) fdo#102252
Test kms_setmode:
Subgroup basic:
fail -> PASS (shard-hsw) fdo#99912fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
shard-hsw total:2230 pass:1230 dwarn:0 dfail:0 fail:18 skip:982 time:9610s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5531/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 5 lines · Rodrigo Vivi
On CNL B0 stepping GAM is not able to detect some deadlock condition and then rise the rise the
gam_coh_flush.WA database and spec both mentions to set 4AB8[24]=1 as workaround. Alghouth register offset
0x4AB8is not
s/Alghouth/Although
Quoted 2 lines
documented for any platform.
References: HSD#1945815, BSID#1112
Quoted 2 lines
Cc Mika Kuoppala <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>
Quoted 40 lines
--- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_engine_cs.c | 5 +++++ 2 files changed, 6 insertions(+)drivers/gpu/drm/i915/i915_reg.h +1
-0@@ -2373,6 +2373,7 @@ enum i915_power_well_id {#define GAMT_CHKN_BIT_REG _MMIO(0x4ab8)#define GAMT_CHKN_DISABLE_DYNAMIC_CREDIT_SHARING (1<<28) +#define GAMT_CHKN_DISABLE_I2M_CYCLE_ON_WR_PORT (1<<24)#if 0 #define PRB0_TAIL _MMIO(0x2030)drivers/gpu/drm/i915/intel_engine_cs.c +5
-0@@ -1070,6 +1070,11 @@ static int cnl_init_workarounds(struct intel_engine_cs *engine)struct drm_i915_private *dev_priv = engine->i915;int ret; +/* WaDisableI2mCycleOnWRPort: cnl (pre-prod) */ +if (IS_CNL_REVID (dev_priv,CNL_REVID_B0 ,CNL_REVID_B0 )) +WA_SET_BIT (GAMT_CHKN_BIT_REG , +GAMT_CHKN_DISABLE_I2M_CYCLE_ON_WR_PORT ); +/* WaForceContextSaveRestoreNonCoherent:cnl */ WA_SET_BIT_MASKED (CNL_HDC_CHICKEN0 ,HDC_FORCE_CONTEXT_SAVE_RESTORE_NON_COHERENT );Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
merged to dinq. thanks for the review
Quoted 55 lines · Mika Kuoppala
Quoted 5 lines · Rodrigo Vivi
On CNL B0 stepping GAM is not able to detect some deadlock condition and then rise the rise the
gam_coh_flush.WA database and spec both mentions to set 4AB8[24]=1 as workaround. Alghouth register offset
0x4AB8is nots/Alghouth/Although
Quoted 2 lines
documented for any platform.
References: HSD#1945815, BSID#1112
Quoted 2 lines
Cc Mika Kuoppala <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>Reviewed-by Mika Kuoppala <[email protected]>Quoted 36 lines
--- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_engine_cs.c | 5 +++++ 2 files changed, 6 insertions(+)drivers/gpu/drm/i915/i915_reg.h +1
-0@@ -2373,6 +2373,7 @@ enum i915_power_well_id {#define GAMT_CHKN_BIT_REG _MMIO(0x4ab8)#define GAMT_CHKN_DISABLE_DYNAMIC_CREDIT_SHARING (1<<28) +#define GAMT_CHKN_DISABLE_I2M_CYCLE_ON_WR_PORT (1<<24)#if 0 #define PRB0_TAIL _MMIO(0x2030)drivers/gpu/drm/i915/intel_engine_cs.c +5
-0@@ -1070,6 +1070,11 @@ static int cnl_init_workarounds(struct intel_engine_cs *engine)struct drm_i915_private *dev_priv = engine->i915;int ret; +/* WaDisableI2mCycleOnWRPort: cnl (pre-prod) */ +if (IS_CNL_REVID (dev_priv,CNL_REVID_B0 ,CNL_REVID_B0 )) +WA_SET_BIT (GAMT_CHKN_BIT_REG , +GAMT_CHKN_DISABLE_I2M_CYCLE_ON_WR_PORT ); +/* WaForceContextSaveRestoreNonCoherent:cnl */ WA_SET_BIT_MASKED (CNL_HDC_CHICKEN0 ,HDC_FORCE_CONTEXT_SAVE_RESTORE_NON_COHERENT );Signature · 1 line
2.13.2
Quoted 4 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx