memorder: Express `value-returning RMW` more explicitly
PATCH 1/2 memorder: Express `value-returning RMW` more explicitly
A sentence represents Successful Non-Relaced Non-void RMW' row in Linux-Kernel Memory-Ordering Cheat Sheet as value-returning RMW` row. Because it is far different expression, some reader may confuse. This commit remove the confuse by representing the row with exactly same words.
--- memorder/memorder.tex | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
memorder/memorder.tex +3 -3
@@ -507,9 +507,9 @@ The \co{*_acquire} row covers \co{smp_load_acquire()}, \co{cmpxchg_acquire()}, \co{xchg_release()}, and so on; the \co{*_release} row covers \co{smp_store_release()}, \co{cmpxchg_release()}, \co{xchg_release()}, and so on; and -the value-returning RMW row covers \co{atomic_add_return()}, -\co{atomic_add_unless()}, -\co{atomic_dec_and_test()}, \co{cmpxchg()}, \co{xchg()}, and so on. +the ``Successful Non-Relaxed Non-\co{void} RMW'' row covers +\co{atomic_add_return()}, \co{atomic_add_unless()}, \co{atomic_dec_and_test()}, +\co{cmpxchg()}, \co{xchg()}, and so on. The ``Successful'' qualifiers apply to primitives such as \co{atomic_add_unless()}, \co{cmpxchg_acquire()}, and \co{cmpxchg_release()}, which have no effect on either memory or on ordering when they indicate
Signature · 1 line
2.10.0
PATCH 2/2 memorder: Add missed closing parenthesis
A closing parenthesis is missed. This commit adds it.
--- memorder/memorder.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
memorder/memorder.tex +1 -1
@@ -596,7 +596,7 @@ are at most two threads involved. ordering for any accesses preceding or following both. No ordering need be provided for accesses between the \co{smp_mb__before_atomic()} (or, similarly, the - \co{smp_mb__after_atomic()} and the atomic RMW operation, as + \co{smp_mb__after_atomic()}) and the atomic RMW operation, as indicated by the ``a'' entries on the \co{smp_mb__before_atomic()} and \co{smp_mb__after_atomic()} rows of the table.
Signature · 1 line
2.10.0
Quoted 7 lines · SeongJae Park
A sentence represents
Successful Non-Relaced Non-void RMW' row inLinux-Kernel Memory-Ordering Cheat Sheetasvalue-returning RMW` row. Because it is far different expression, some reader may confuse. This commit remove the confuse by representing the row with exactly same words.Signed-off-by SeongJae Park <[email protected]>
Good catches, applied both, thank you!
Thanx, Paul
Quoted 24 lines
--- memorder/memorder.tex | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)memorder/memorder.tex +3
-3@@ -507,9 +507,9 @@ The \co{*_acquire} row covers \co{smp_load_acquire()}, \co{cmpxchg_acquire()}, \co{xchg_release()}, and so on; the \co{*_release} row covers \co{smp_store_release()}, \co{cmpxchg_release()}, \co{xchg_release()}, and so on; and -the value-returning RMW row covers \co{atomic_add_return()}, -\co{atomic_add_unless()}, -\co{atomic_dec_and_test()}, \co{cmpxchg()}, \co{xchg()}, and so on. +the ``Successful Non-Relaxed Non-\co{void} RMW'' row covers +\co{atomic_add_return()}, \co{atomic_add_unless()}, \co{atomic_dec_and_test()}, +\co{cmpxchg()}, \co{xchg()}, and so on. The ``Successful'' qualifiers apply to primitives such as \co{atomic_add_unless()}, \co{cmpxchg_acquire()}, and \co{cmpxchg_release()}, which have no effect on either memory or on ordering when they indicateSignature · 1 line
2.10.0
--
To unsubscribe from this list: send the line "unsubscribe perfbook" in
the body of a message to [email protected]
More majordomo info at https://urldefense.proofpoint.com/v2/url?u=http-3A__vger.kernel.org_majordomo-2Dinfo.html&d=DwIBAg&c=jf_iaSHvJObTbx-siA1ZOg&r=ux41CW3B5BSVxDMRNRWyLbUmPebZc70Kq4AkfdiRGMI&m=VjmF1wSmnKfzHsjtYLhnVDL4Sn_rjJ0qmIkI1wh9cDM&s=IRasYQidXsEuhEadRYwKZtOJuZD_KbTh3IIyCMnRMLM&e=