Skip to contentSkip to conversation

go-dep: Add 0.3.0 release

PATCH In review Otavio Salvador 3 participants 5 messages Sep 3, 2017 – Sep 4, 2017

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 go-dep: Add 0.3.0 release

This is the Golang dependency management tool under development; it is ready for production use and intended to be merged onto Golang 1.10. Until that, projects are starting to use it and making it available on OE-Core reduces the Golang integration work for new recipes.

---

Changes in v2:
- Update to 0.3.0

 meta/recipes-devtools/go/go-dep_0.3.0.bb | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 meta/recipes-devtools/go/go-dep_0.3.0.bb
meta/recipes-devtools/go/go-dep_0.3.0.bb new file +20 -0
new file mode 100644
index 0000000000..66e30acbd3
@@ -0,0 +1,20 @@
+SUMMARY = "Dependency management tool for Golang"
+HOMEPAGE = "https://github.com/golang/dep"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://src/${GO_IMPORT}/LICENSE;md5=1bad315647751fab0007812f70d42c0d"
+
+GO_IMPORT = "github.com/golang/dep"
+SRC_URI = "git://${GO_IMPORT};destsuffix=${BPN}-${PV}/src/${GO_IMPORT};nobranch=1"
+
+# Points to 0.3.0 tag
+SRCREV = "7a91b794bbfbf1f3b8b79823799316451127801b"
+
+inherit go
+
+GO_INSTALL = "${GO_IMPORT}/cmd/dep"
+
+INSANE_SKIP_${PN} += "ldflags"
+
+BBCLASSEXTEND = "native nativesdk"
+
+RDEPENDS_${PN}-staticdev += "bash"
Signature · 1 line
2.14.1
#1 lore raw
Quoted 6 lines · Otavio Salvador

This is the Golang dependency management tool under development; it is ready for production use and intended to be merged onto Golang 1.10. Until that, projects are starting to use it and making it available on OE-Core reduces the Golang integration work for new recipes.

ERROR: go-dep-0.3.0-r0 do_package: QA Issue: go-dep: Files/directories were installed but not shipped in any package:
/usr/lib64/x86_64-poky-linux/go/bin/dep
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
go-dep: 1 installed and not shipped files. [installed-vs-shipped]

Ross

#2 lore raw
Quoted 10 lines · Ross
Quoted 6 lines · Otavio Salvador

This is the Golang dependency management tool under development; it is ready for production use and intended to be merged onto Golang 1.10. Until that, projects are starting to use it and making it available on OE-Core reduces the Golang integration work for new recipes.

Quoted 6 lines

ERROR: go-dep-0.3.0-r0 do_package: QA Issue: go-dep: Files/directories were installed but not shipped in any package:
/usr/lib64/x86_64-poky-linux/go/bin/dep
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
go-dep: 1 installed and not shipped files. [installed-vs-shipped]

I know and this is an issue with our Go toolchain support. It fails when we are building for same architecture than our build host.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#3 lore raw
Quoted 17 lines · Otavio Salvador
Quoted 11 lines · Ross
Quoted 6 lines · Otavio Salvador

This is the Golang dependency management tool under development; it is ready for production use and intended to be merged onto Golang 1.10. Until that, projects are starting to use it and making it available on OE-Core reduces the Golang integration work for new recipes.

ERROR: go-dep-0.3.0-r0 do_package: QA Issue: go-dep: Files/directories

were

Quoted 3 lines

installed but not shipped in any package:
/usr/lib64/x86_64-poky-linux/go/bin/dep
Please set FILES such that these items are packaged. Alternatively if

Quoted 7 lines

they

Quoted 2 lines

are unneeded, avoid installing them or delete them within do_install.
go-dep: 1 installed and not shipped files. [installed-vs-shipped]

I know and this is an issue with our Go toolchain support. It fails when we are building for same architecture than our build host.

(CCing Khem)

Sounds like a serious problem. Presumably different tooling is used to build go-hellworld, as that doesn't have the same problem?

Do we need a bug for this? How critical is it to fix before 2.4?

Ross

#4 lore raw
Quoted 28 lines · Ross
Quoted 22 lines · Otavio Salvador
Quoted 10 lines · Ross
Quoted 6 lines · Otavio Salvador

This is the Golang dependency management tool under development; it is ready for production use and intended to be merged onto Golang 1.10. Until that, projects are starting to use it and making it available on OE-Core reduces the Golang integration work for new recipes.

Quoted 8 lines

ERROR: go-dep-0.3.0-r0 do_package: QA Issue: go-dep: Files/directories were
installed but not shipped in any package:
/usr/lib64/x86_64-poky-linux/go/bin/dep
Please set FILES such that these items are packaged. Alternatively if they
are unneeded, avoid installing them or delete them within do_install.
go-dep: 1 installed and not shipped files. [installed-vs-shipped]

Quoted 2 lines

I know and this is an issue with our Go toolchain support. It fails when we are building for same architecture than our build host.

Quoted 6 lines

(CCing Khem)

Sounds like a serious problem. Presumably different tooling is used to build go-hellworld, as that doesn't have the same problem?

Do we need a bug for this? How critical is it to fix before 2.4?

Honestly, Go support needs some love for 2.4. I am investing some quality time reviewing what is missing when comparing to meta-golang and there is a lot to improve.

The error is nothing obvious to me. However, I am cleaning up the integration so we have it in better quality for the release. Eventually, I will end fixing this error.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750