Skip to contentSkip to conversation

xfsdump: Use c99 defined int64_t instead of __int64_t

PATCH In review Khem Raj 2 participants 4 messages Sep 9, 2017 – Sep 10, 2017

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 xfsdump: Use c99 defined int64_t instead of __int64_t

---
 common/hsmapi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/hsmapi.c +1 -1
index 6054773..0709dbe 100644
@@ -585,7 +585,7 @@ HsmModifyExtentMap(
 	struct getbmapx	*bmap)
 {
 	dmf_f_ctxt_t	*dmf_f_ctxtp = (dmf_f_ctxt_t *)contextp;
-	__int64_t	length;
+	int64_t		length;
 
 	if (bmap[0].bmv_entries <= 0) {
 		return 1;	/* caller must already be at EOF */
Signature · 1 line
2.14.1
#1 lore raw

Seems fine, but are the __uint32_t instances in the code not a problem?

Thanks,
-Eric

Quoted 19 lines · Khem Raj
---
 common/hsmapi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/hsmapi.c +1 -1
index 6054773..0709dbe 100644
@@ -585,7 +585,7 @@ HsmModifyExtentMap(
 	struct getbmapx	*bmap)
 {
 	dmf_f_ctxt_t	*dmf_f_ctxtp = (dmf_f_ctxt_t *)contextp;
-	__int64_t	length;
+	int64_t		length;
 
 	if (bmap[0].bmv_entries <= 0) {
 		return 1;	/* caller must already be at EOF */
author
#2 lore raw
Quoted 2 lines · Eric Sandeen

Seems fine, but are the __uint32_t instances in the code not a problem?

yes they are and I had a seprate patch for them, which I will send once I have fixed the tab formatting issues with it. May be I should squash then into one

Quoted 23 lines

Thanks,
-Eric

Quoted 19 lines · Khem Raj
---
 common/hsmapi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/hsmapi.c +1 -1
index 6054773..0709dbe 100644
@@ -585,7 +585,7 @@ HsmModifyExtentMap(
      struct getbmapx *bmap)
 {
      dmf_f_ctxt_t    *dmf_f_ctxtp = (dmf_f_ctxt_t *)contextp;
-     __int64_t       length;
+     int64_t         length;
 
      if (bmap[0].bmv_entries <= 0) {
              return 1;       /* caller must already be at EOF */
#3 lore raw
Quoted 7 lines · Khem Raj
Quoted 2 lines · Eric Sandeen

Seems fine, but are the __uint32_t instances in the code not a problem?

yes they are and I had a seprate patch for them, which I will send once I have fixed the tab formatting issues with it. May be I should squash then into one

yes please.

thanks,
-Eric