drm/i915/guc: Submit GuC workitems containing coalesced requests
Subsystems (2)
PATCH 1/2 drm/i915/guc: Submit GuC workitems containing coalesced requests
To create an upper bound on number of GuC workitems, we need to change the way that requests are being submitted. Rather than submitting each request as an individual workitem, we can do coalescing in a similar way we're handlig execlist submission ports. We also need to stop pretending that we're doing "lite-restore" in GuC submission (we would create a workitem each time we hit this condition). This allows us to completely remove the reservation, replacing it with a compile time check.
v2: Also coalesce when replaying on reset (Daniele)
v3: Consistent wq_resv - per-request (Daniele)
v4: Squash removing wq_resv
References: https://bugs.freedesktop.org/show_bug.cgi?id=101873
--- drivers/gpu/drm/i915/i915_debugfs.c | 2 - drivers/gpu/drm/i915/i915_guc_submission.c | 179 ++++++++++------------------- drivers/gpu/drm/i915/intel_lrc.c | 25 +--- drivers/gpu/drm/i915/intel_uc.h | 8 -- 4 files changed, 62 insertions(+), 152 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +0 -2
@@ -2450,8 +2450,6 @@ static void i915_guc_client_info(struct seq_file *m,seq_printf (m,"\tWQ size %d, offset: 0x%x, tail %d\n" , client->wq_size, client->wq_offset, client->wq_tail); -seq_printf (m,"\tWork queue full: %u\n" , client->no_wq_space); -for_each_engine (engine, dev_priv, id) {u64 submissions = client->submissions[id]; tot += submissions;
drivers/gpu/drm/i915/i915_guc_submission.c +59 -120
278 lines not on this page · raw message
drivers/gpu/drm/i915/intel_lrc.c +3 -22
@@ -914,27 +914,14 @@ static int execlists_request_alloc(struct drm_i915_gem_request *request)*/ request->reserved_space +=EXECLISTS_REQUEST_SIZE ; -if (i915.enable_guc_submission) { -/* -* Check that the GuC has space for the request before -* going any further, as the i915_add_request() call -* later on mustn't fail ... -*/ - ret =i915_guc_wq_reserve (request); -if (ret) - goto err; - } - cs =intel_ring_begin (request,0 ); -if (IS_ERR (cs)) { - ret =PTR_ERR (cs); - goto err_unreserve; - } +if (IS_ERR (cs)) +return PTR_ERR (cs);if (!ce->initialised) { ret = engine->init_context (request);if (ret) - goto err_unreserve; +return ret; ce->initialised = true; }
@@ -948,12 +935,6 @@ static int execlists_request_alloc(struct drm_i915_gem_request *request) request->reserved_space -=EXECLISTS_REQUEST_SIZE ;return 0 ; - -err_unreserve: -if (i915.enable_guc_submission) -i915_guc_wq_unreserve (request); -err: -return ret; }/*
drivers/gpu/drm/i915/intel_uc.h +0 -8
@@ -55,10 +55,6 @@ struct drm_i915_gem_request;* * We also keep a few statistics on failures. Ideally, these should all * be zero! -* no_wq_space: times that the submission pre-check found no space was -* available in the work queue (note, the queue is shared, -* not per-engine). It is OK for this to be nonzero, but -* it should not be huge! * b_fail: failed to ring the doorbell. This should never happen, unless * somehow the hardware misbehaves, or maybe if the GuC firmware * crashes? We probably need to reset the GPU to recover.
@@ -83,8 +79,6 @@ struct i915_guc_client {uint32_t wq_offset;uint32_t wq_size;uint32_t wq_tail; -uint32_t wq_rsvd; -uint32_t no_wq_space;/* Per-engine counts of GuC submissions */ uint64_t submissions[I915_NUM_ENGINES ];
@@ -250,8 +244,6 @@ u32 intel_guc_wopcm_size(struct drm_i915_private *dev_priv);/* i915_guc_submission.c */ int i915_guc_submission_init (struct drm_i915_private *dev_priv);int i915_guc_submission_enable (struct drm_i915_private *dev_priv); -int i915_guc_wq_reserve (struct drm_i915_gem_request *rq); -void i915_guc_wq_unreserve (struct drm_i915_gem_request *request);void i915_guc_submission_disable (struct drm_i915_private *dev_priv);void i915_guc_submission_fini (struct drm_i915_private *dev_priv);struct i915_vma *intel_guc_allocate_vma (struct intel_guc *guc,u32 size);
Signature · 6 lines
2.13.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/2 HAX Enable GuC Submission for CI
--- drivers/gpu/drm/i915/i915_params.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_params.c +2 -2
@@ -56,8 +56,8 @@ struct i915_params i915 __read_mostly = { .verbose_state_checks = 1, .nuclear_pageflip = 0, .edp_vswing = 0, - .enable_guc_loading = 0, - .enable_guc_submission = 0, + .enable_guc_loading = 2, + .enable_guc_submission = 2, .guc_log_level = -1, .guc_firmware_path = NULL, .huc_firmware_path = NULL,
Signature · 6 lines
2.13.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/guc: Submit GuC workitems containing coalesced requests
In reply to Michał Winiarski== Series Details ==
== Series Details ==
Series: series starting with [1/2] drm/i915/guc: Submit GuC workitems containing coalesced requests
URL : https://patchwork.freedesktop.org/series/30135/
State : failure
== Summary ==
Series 30135v1 series starting with [1/2] drm/i915/guc: Submit GuC workitems containing coalesced requests
https://patchwork.freedesktop.org/api/1.0/series/30135/revisions/1/mbox/
Test chamelium:
Subgroup dp-crc-fast:
fail -> PASS (fi-kbl-7500u) fdo#102514
Subgroup common-hpd-after-suspend:
pass -> INCOMPLETE (fi-skl-6700k)
dmesg-warn -> INCOMPLETE (fi-kbl-7500u) fdo#102505
Test debugfs_test:
Subgroup read_all_entries:
pass -> SKIP (fi-glk-2a)
Test drv_hangman:
Subgroup error-state-basic:
pass -> INCOMPLETE (fi-skl-6260u)
pass -> INCOMPLETE (fi-skl-6770hq)
pass -> INCOMPLETE (fi-skl-gvtdvm)
pass -> INCOMPLETE (fi-skl-x1585l)
pass -> INCOMPLETE (fi-bxt-j4205)
pass -> INCOMPLETE (fi-kbl-7560u)
pass -> INCOMPLETE (fi-kbl-r)
pass -> SKIP (fi-glk-2a)
pass -> INCOMPLETE (fi-cfl-s)
Test gem_busy:
Subgroup basic-busy-default:
pass -> SKIP (fi-glk-2a)
Subgroup basic-hang-default:
pass -> SKIP (fi-glk-2a)
Test gem_close_race:
Subgroup basic-process:
pass -> SKIP (fi-glk-2a)
Subgroup basic-threads:
pass -> SKIP (fi-glk-2a)
Test gem_cpu_reloc:
Subgroup basic:
pass -> SKIP (fi-glk-2a)
Test gem_cs_tlb:
Subgroup basic-default:
pass -> SKIP (fi-glk-2a)
Test gem_ctx_create:
Subgroup basic:
pass -> SKIP (fi-glk-2a)
Subgroup basic-files:
pass -> SKIP (fi-glk-2a)
Test gem_ctx_exec:
Subgroup basic:
pass -> SKIP (fi-glk-2a)
Test gem_ctx_switch:
Subgroup basic-default:
pass -> SKIP (fi-glk-2a)
Subgroup basic-default-heavy:
pass -> SKIP (fi-glk-2a)
Test gem_exec_basic:
Subgroup basic-blt:
pass -> SKIP (fi-glk-2a)
Subgroup basic-bsd:
pass -> SKIP (fi-glk-2a)
Subgroup basic-default:
pass -> SKIP (fi-glk-2a)
Subgroup basic-render:
pass -> SKIP (fi-glk-2a)
Subgroup basic-vebox:
pass -> SKIP (fi-glk-2a)
Subgroup gtt-blt:
pass -> SKIP (fi-glk-2a)
Subgroup gtt-bsd:
pass -> SKIP (fi-glk-2a)
Subgroup gtt-default:
pass -> SKIP (fi-glk-2a)
Subgroup gtt-render:
pass -> SKIP (fi-glk-2a)
Subgroup gtt-vebox:
pass -> SKIP (fi-glk-2a)
Subgroup readonly-blt:
pass -> SKIP (fi-glk-2a)
Subgroup readonly-bsd:
pass -> SKIP (fi-glk-2a)
Subgroup readonly-default:
pass -> SKIP (fi-glk-2a)
Subgroup readonly-render:
pass -> SKIP (fi-glk-2a)
Subgroup readonly-vebox:
pass -> SKIP (fi-glk-2a)
Test gem_exec_create:
Subgroup basic:
pass -> SKIP (fi-glk-2a)
Test gem_exec_fence:
Subgroup basic-busy-default:
pass -> SKIP (fi-glk-2a)
Subgroup basic-wait-default:
pass -> SKIP (fi-glk-2a)
Subgroup basic-await-default:
pass -> SKIP (fi-glk-2a)
Subgroup await-hang-default:
pass -> SKIP (fi-glk-2a)
Subgroup nb-await-default:
pass -> SKIP (fi-glk-2a)
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
pass -> SKIP (fi-glk-2a)WARNING: Long output truncated
a06ff73a7522af231e77776d7948e4d8099558c6 drm-tip: 2017y-09m-11d-13h-31m-34s UTC integration manifest 291b12ffede8 HAX Enable GuC Submission for CI862b9ff36cd0 drm/i915/guc: Submit GuC workitems containing coalesced requests
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5644/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Michał Winiarski (2017-09-11 15:17:31)
Quoted 9 lines
To create an upper bound on number of GuC workitems, we need to change the way that requests are being submitted. Rather than submitting each request as an individual workitem, we can do coalescing in a similar way we're handlig execlist submission ports. We also need to stop pretending that we're doing "lite-restore" in GuC submission (we would create a workitem each time we hit this condition). This allows us to completely remove the reservation, replacing it with a compile time check.
v2: Also coalesce when replaying on reset (Daniele)
?
You are using the pattern I expected, just calling i915_guc_submit() with the ports[] reset to count=0 to trigger the resubmit.
Quoted 10 lines
v3: Consistent
wq_resv- per-request (Daniele)
v4: Squash removingwq_resvReferences: https://bugs.freedesktop.org/show_bug.cgi?id=101873
Cc Chris Wilson <[email protected]>Cc Daniele Ceraolo Spurio <[email protected]>Cc Jeff McGee <[email protected]>Cc Michal Wajdeczko <[email protected]>Cc Oscar Mateo <[email protected]>Signed-off-by Michał Winiarski <[email protected]>
Looks good, very similar to the way I did the rq coalescing, but with the improvement of restricting it to ARRAY_SIZE(port[]) and so asserting that wq cannot overflow. If you get adventurous you can replace the spinlock with cmpxchg.
Fancy having a go at a lockless guc_wq_item_append? Kill off the redundant stats for simplicity.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
kbuild test robot
build botAll warnings (new ones prefixed by >>):
Hi Michał,
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v4.13 next-20170914]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Micha-Winiarski/drm-i915-guc-Submit-GuC-workitems-containing-coalesced-requests/20170914-122212 base: git://anongit.freedesktop.org/drm-intel for-linux-next reproduce: make htmldocs
All warnings (new ones prefixed by >>):
WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org)
include/linux/init.h:1: warning: no structured comments found
include/linux/mod_devicetable.h:687: warning: Excess struct/union/enum/typedef member 'ver_major' description in 'fsl_mc_device_id' include/linux/mod_devicetable.h:687: warning: Excess struct/union/enum/typedef member 'ver_minor' description in 'fsl_mc_device_id' kernel/sys.c:1: warning: no structured comments found
include/linux/device.h:968: warning: No description found for parameter 'dma_ops' drivers/dma-buf/seqno-fence.c:1: warning: no structured comments found
include/linux/sync_file.h:51: warning: No description found for parameter 'flags' include/linux/iio/iio.h:603: warning: No description found for parameter 'trig_readonly' include/linux/iio/trigger.h:151: warning: No description found for parameter 'indio_dev' include/linux/iio/trigger.h:151: warning: No description found for parameter 'trig' include/linux/device.h:969: warning: No description found for parameter 'dma_ops' arch/s390/include/asm/cmb.h:1: warning: no structured comments found
drivers/scsi/scsi_lib.c:1116: warning: No description found for parameter 'rq'
drivers/scsi/constants.c:1: warning: no structured comments found
include/linux/usb/gadget.h:230: warning: No description found for parameter 'claimed' include/linux/usb/gadget.h:230: warning: No description found for parameter 'enabled' include/linux/usb/gadget.h:412: warning: No description found for parameter 'quirk_altset_not_supp' include/linux/usb/gadget.h:412: warning: No description found for parameter 'quirk_stall_not_supp' include/linux/usb/gadget.h:412: warning: No description found for parameter 'quirk_zlp_not_supp' fs/inode.c:1666: warning: No description found for parameter 'rcu'
include/linux/jbd2.h:443: warning: No description found for parameter 'i_transaction' include/linux/jbd2.h:443: warning: No description found for parameter 'i_next_transaction' include/linux/jbd2.h:443: warning: No description found for parameter 'i_list'
include/linux/jbd2.h:443: warning: No description found for parameter 'i_vfs_inode'
include/linux/jbd2.h:443: warning: No description found for parameter 'i_flags'
include/linux/jbd2.h:497: warning: No description found for parameter 'h_rsv_handle' include/linux/jbd2.h:497: warning: No description found for parameter 'h_reserved'
include/linux/jbd2.h:497: warning: No description found for parameter 'h_type'
include/linux/jbd2.h:497: warning: No description found for parameter 'h_line_no'
include/linux/jbd2.h:497: warning: No description found for parameter 'h_start_jiffies' include/linux/jbd2.h:497: warning: No description found for parameter 'h_requested_credits' include/linux/jbd2.h:497: warning: No description found for parameter 'saved_alloc_context' include/linux/jbd2.h:1050: warning: No description found for parameter 'j_chkpt_bhs' include/linux/jbd2.h:1050: warning: No description found for parameter 'j_devname'
include/linux/jbd2.h:1050: warning: No description found for parameter 'j_average_commit_time' include/linux/jbd2.h:1050: warning: No description found for parameter 'j_min_batch_time' include/linux/jbd2.h:1050: warning: No description found for parameter 'j_max_batch_time' include/linux/jbd2.h:1050: warning: No description found for parameter 'j_commit_callback' include/linux/jbd2.h:1050: warning: No description found for parameter 'j_failed_commit' include/linux/jbd2.h:1050: warning: No description found for parameter 'j_chksum_driver' include/linux/jbd2.h:1050: warning: No description found for parameter 'j_csum_seed' fs/jbd2/transaction.c:511: warning: No description found for parameter 'type'
fs/jbd2/transaction.c:511: warning: No description found for parameter 'line_no'
fs/jbd2/transaction.c:641: warning: No description found for parameter 'gfp_mask'
include/drm/drm_drv.h:594: warning: No description found for parameter 'gem_prime_pin' include/drm/drm_drv.h:594: warning: No description found for parameter 'gem_prime_unpin' include/drm/drm_drv.h:594: warning: No description found for parameter 'gem_prime_res_obj' include/drm/drm_drv.h:594: warning: No description found for parameter 'gem_prime_get_sg_table' include/drm/drm_drv.h:594: warning: No description found for parameter 'gem_prime_import_sg_table' include/drm/drm_drv.h:594: warning: No description found for parameter 'gem_prime_vmap' include/drm/drm_drv.h:594: warning: No description found for parameter 'gem_prime_vunmap' include/drm/drm_drv.h:594: warning: No description found for parameter 'gem_prime_mmap' include/drm/drm_mode_config.h:771: warning: No description found for parameter 'modifiers_property' include/drm/drm_mode_config.h:771: warning: Excess struct/union/enum/typedef member 'modifiers' description in 'drm_mode_config' include/drm/drm_plane.h:544: warning: No description found for parameter 'modifiers' include/drm/drm_plane.h:544: warning: No description found for parameter 'modifier_count'
>> drivers/gpu/drm/i915/i915_guc_submission.c:531: warning: No description found for parameter 'engine' >> drivers/gpu/drm/i915/i915_guc_submission.c:531: warning: Excess function parameter 'rq' description in 'i915_guc_submit'
drivers/gpu/drm/i915/i915_guc_submission.c:532: warning: No description found for parameter 'engine' drivers/gpu/drm/i915/i915_guc_submission.c:532: warning: Excess function parameter 'rq' description in 'i915_guc_submit' drivers/gpu/host1x/bus.c:50: warning: No description found for parameter 'driver'
Documentation/doc-guide/sphinx.rst:121: ERROR: Unknown target name: "sphinx c domain".
kernel/sched/fair.c:7584: WARNING: Inline emphasis start-string without end-string.
kernel/time/timer.c:1200: ERROR: Unexpected indentation.
kernel/time/timer.c:1202: ERROR: Unexpected indentation.
kernel/time/timer.c:1203: WARNING: Block quote ends without a blank line; unexpected unindent.
include/linux/wait.h:108: WARNING: Block quote ends without a blank line; unexpected unindent.
include/linux/wait.h:111: ERROR: Unexpected indentation.
include/linux/wait.h:113: WARNING: Block quote ends without a blank line; unexpected unindent.
kernel/time/hrtimer.c:991: WARNING: Block quote ends without a blank line; unexpected unindent.
kernel/signal.c:323: WARNING: Inline literal start-string without end-string.
kernel/rcu/tree.c:3187: ERROR: Unexpected indentation.
kernel/rcu/tree.c:3214: ERROR: Unexpected indentation.
kernel/rcu/tree.c:3215: WARNING: Bullet list ends without a blank line; unexpected unindent.
include/linux/iio/iio.h:219: ERROR: Unexpected indentation.
include/linux/iio/iio.h:220: WARNING: Block quote ends without a blank line; unexpected unindent.
include/linux/iio/iio.h:226: WARNING: Definition list ends without a blank line; unexpected unindent. drivers/iio/industrialio-core.c:633: ERROR: Unknown target name: "iio_val".
drivers/iio/industrialio-core.c:640: ERROR: Unknown target name: "iio_val".
drivers/ata/libata-core.c:5906: ERROR: Unknown target name: "hw".
drivers/message/fusion/mptbase.c:5051: WARNING: Definition list ends without a blank line; unexpected unindent. drivers/tty/serial/serial_core.c:1897: WARNING: Definition list ends without a blank line; unexpected unindent. drivers/pci/pci.c:3470: ERROR: Unexpected indentation.
include/linux/regulator/driver.h:271: ERROR: Unknown target name: "regulator_regmap_x_voltage".
include/linux/spi/spi.h:373: ERROR: Unexpected indentation.
drivers/w1/w1_io.c:196: WARNING: Definition list ends without a blank line; unexpected unindent.
block/bio.c:404: ERROR: Unknown target name: "gfp".
sound/soc/soc-core.c:2703: ERROR: Unknown target name: "snd_soc_daifmt".
sound/core/jack.c:312: ERROR: Unknown target name: "snd_jack_btn".
Documentation/virtual/kvm/vcpu-requests.rst:: WARNING: document isn't included in any toctree Documentation/dev-tools/kselftest.rst:15: WARNING: Could not lex literal_block as "c". Highlighting skipped.
Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 43: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 56: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 69: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 82: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 96: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 109: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 122: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 133: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 164: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 193: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 43: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 56: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 69: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 82: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 96: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 109: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 122: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 133: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 164: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 193: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 43: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 56: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 69: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 82: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 96: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 109: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 122: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 133: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 164: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 193: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 43: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 56: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 69: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 82: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 96: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 109: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 122: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 133: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 164: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 193: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 43: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 56: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 69: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 82: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 96: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 109: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 122: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 133: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 164: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 193: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 43: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 56: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 69: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 82: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 96: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 109: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 122: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 133: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 164: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "~/.fonts.conf", line 193: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 43: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 56: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 69: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 82: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 96: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 109: Having multiple values in <test> isn't supported and may not work as expected Fontconfig warning: "/home/kbuild/.config/fontconfig/fonts.conf", line 122: Having multiple values in <test> isn't supported and may not work as expected
vim +/engine +531 drivers/gpu/drm/i915/i915_guc_submission.c
10d2c3e28 Dave Gordon 2016-06-13 522
44a28b1d3 Dave Gordon 2015-08-12 523 /**
e875144fe Michał Winiarski 2017-09-11 524 * i915_guc_submit() - Submit commands through GuC
feda33ef0 Alex Dai 2015-10-19 525 * @rq: request associated with the commands
44a28b1d3 Dave Gordon 2015-08-12 526 *
7c2c270d2 Dave Gordon 2016-05-13 527 * The only error here arises if the doorbell hardware isn't functioning
7c2c270d2 Dave Gordon 2016-05-13 528 * as expected, which really shouln't happen.
44a28b1d3 Dave Gordon 2015-08-12 529 */
e875144fe Michał Winiarski 2017-09-11 530 static void i915_guc_submit(struct intel_engine_cs *engine)
44a28b1d3 Dave Gordon 2015-08-12 @531 {
e875144fe Michał Winiarski 2017-09-11 532 struct drm_i915_private *dev_priv = engine->i915;
e875144fe Michał Winiarski 2017-09-11 533 struct intel_guc *guc = &dev_priv->guc;
7c2c270d2 Dave Gordon 2016-05-13 534 struct i915_guc_client *client = guc->execbuf_client;
e875144fe Michał Winiarski 2017-09-11 535 struct execlist_port *port = engine->execlist_port;
e875144fe Michał Winiarski 2017-09-11 536 unsigned int engine_id = engine->id;
e875144fe Michał Winiarski 2017-09-11 537 unsigned int n;
25afdf89a Chris Wilson 2017-03-02 538 unsigned long flags;
0a31afbc0 Dave Gordon 2016-05-13 539 int b_ret;
44a28b1d3 Dave Gordon 2015-08-12 540
e875144fe Michał Winiarski 2017-09-11 541 for (n = 0; n < ARRAY_SIZE(engine->execlist_port); n++) {
e875144fe Michał Winiarski 2017-09-11 542 struct drm_i915_gem_request *rq;
e875144fe Michał Winiarski 2017-09-11 543 unsigned int count;
e875144fe Michał Winiarski 2017-09-11 544
e875144fe Michał Winiarski 2017-09-11 545 rq = port_unpack(&port[n], &count);
e875144fe Michał Winiarski 2017-09-11 546 if (rq && count == 0) {
e875144fe Michał Winiarski 2017-09-11 547 port_set(&port[n], port_pack(rq, ++count));
e875144fe Michał Winiarski 2017-09-11 548
ed4596ea9 Akash Goel 2016-10-25 549 if (i915_vma_is_map_and_fenceable(rq->ring->vma))
ed4596ea9 Akash Goel 2016-10-25 550 POSTING_READ_FW(GUC_STATUS);
ed4596ea9 Akash Goel 2016-10-25 551
25afdf89a Chris Wilson 2017-03-02 552 spin_lock_irqsave(&client->wq_lock, flags);
0c33518db Chris Wilson 2017-02-28 553
0c33518db Chris Wilson 2017-02-28 554 guc_wq_item_append(client, rq);
44a28b1d3 Dave Gordon 2015-08-12 555 b_ret = guc_ring_doorbell(client);
44a28b1d3 Dave Gordon 2015-08-12 556
397097b02 Alex Dai 2016-01-23 557 client->submissions[engine_id] += 1;
0a31afbc0 Dave Gordon 2016-05-13 558
25afdf89a Chris Wilson 2017-03-02 559 spin_unlock_irqrestore(&client->wq_lock, flags);
44a28b1d3 Dave Gordon 2015-08-12 560 }
e875144fe Michał Winiarski 2017-09-11 561 }
34ba5a80f Chris Wilson 2016-11-29 562 }
34ba5a80f Chris Wilson 2016-11-29 563 :::::: The code at line 531 was first introduced by commit
:::::: 44a28b1d36762499de6fd701fcce6814eefe31d7 drm/i915: Implementation of GuC submission client
:::::: TO: Dave Gordon <[email protected]>
:::::: CC: Daniel Vetter <[email protected]>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx