Skip to contentSkip to conversation

test_kmod-remove-paranoid-uint_max-check-on-uint-range-processing.patch removed from -mm tree

merged [email protected] 1 participant 1 message Sep 11, 2017

lore
Share & tools
lore

[email protected]

author tree notice Applied
#0 lore raw

The patch titled
Subject: test_kmod: remove paranoid UINT_MAX check on uint range processing
has been removed from the -mm tree. Its filename was
test_kmod-remove-paranoid-uint_max-check-on-uint-range-processing.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Dan Carpenter <[email protected]>
Subject: test_kmod: remove paranoid UINT_MAX check on uint range processing

The UINT_MAX comparison is not needed because "max" is already an unsigned int, and we expect developer C code max value input to have a sensible 0 - UINT_MAX range. Note that if it so happens to be UINT_MAX + 1 it would lead to an issue, but we expect the developer to know this.

[[email protected]: massaged commit log]
Cc Dmitry Torokhov <[email protected]>
Cc Kees Cook <[email protected]>
Cc Jessica Yu <[email protected]>
Cc Rusty Russell <[email protected]>
Cc Michal Marek <[email protected]>
Cc Petr Mladek <[email protected]>
Cc Miroslav Benes <[email protected]>
Cc Josh Poimboeuf <[email protected]>
Cc Eric W. Biederman <[email protected]>
Cc Shuah Khan <[email protected]>
Cc Colin Ian King <[email protected]>
Cc David Binderman <[email protected]>

---

 lib/test_kmod.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/test_kmod.c renamed from lib/test_kmod.c~test_kmod-remove-paranoid-uint_max-check-on-uint-range-processing +1 -1
diff -puN lib/test_kmod.c~test_kmod-remove-paranoid-uint_max-check-on-uint-range-processing lib/test_kmod.c
@@ -924,7 +924,7 @@ static int test_dev_config_update_uint_r
 	if (ret)
 		return ret;
 
-	if (new < min || new >  max || new > UINT_MAX)
+	if (new < min || new > max)
 		return -EINVAL;
 
 	mutex_lock(&test_dev->config_mutex);

_

Patches currently in -mm which might be from [email protected] are