Skip to contentSkip to conversation

Splitting led drivers to subdirectories?

DISCUSSION Pavel Machek 2 participants 2 messages Sep 12, 2017 LED

lore
Share & tools
lore
#0 lore raw

Hi!

Is it time to start splitting drivers into subdirectories?

I'd quite like to see drivers/leds/i2c/ and drivers/leds/flash/ . That way it is easier to look at related drivers for inspiration...

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw

Hi,

Quoted 6 lines · Pavel Machek

Hi!

Is it time to start splitting drivers into subdirectories?

I'd quite like to see drivers/leds/i2c/ and drivers/leds/flash/ . That way it is easier to look at related drivers for inspiration...

These categorization would be inconsistent - i2c is a bus, and flash is a LED function. Moreover, not all devices are driven through buses, some of them via gpio, MMIO or even as2cwire like in case of leds-aat1290. Do we want to split the drivers like that? It would generate only unnecessary noise IMHO.

We could go for splitting drivers to LED and LED flash class, but the former is just a subset of the latter, so it would be also not accurate.

Effectively I propose to apply the "leave well alone" rule here :-)

Signature · 2 lines
Best regards,
Jacek Anaszewski