Skip to contentSkip to conversation

tools: objtool: fix memory leak in elf_create_rela_section()

PATCH Superseded Martin Kepplinger 1 participant 1 message Sep 13, 2017 objtool

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools: objtool: fix memory leak in elf_create_rela_section()

Let's free the allocated char array relaname before returning in order to avoid leaking memory.

---
 tools/objtool/elf.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
tools/objtool/elf.c +5 -1
index 6e9f980a7d26..6aacbc31316d 100644
@@ -508,8 +508,12 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base)
 	strcat(relaname, base->name);
 
 	sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0);
-	if (!sec)
+	if (!sec) {
+		free(relaname);
 		return NULL;
+	}
+
+	free(relaname);
 
 	base->rela = sec;
 	sec->base = base;
Signature · 1 line
2.11.0