Skip to contentSkip to conversation

xen: x86: mark xen_find_pt_base as __init

PATCH Applied Arnd Bergmann 2 participants 3 messages Sep 15, 2017 – Sep 16, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen: x86: mark xen_find_pt_base as __init

gcc-4.6 causes a harmless link-time warning:

WARNING: vmlinux.o(.text.unlikely+0x48e): Section mismatch in reference from the function xen_find_pt_base() to the function .init.text:m2p() The function xen_find_pt_base() references
the function __init m2p().
This is often because xen_find_pt_base lacks a __init
annotation or the annotation of m2p is wrong.

Newer compilers inline this function, so it never shows up, but marking it __init is the right way to avoid the warning.

Fixes 70e61199559a ("xen: move p2m list if conflicting with e820 map")
---
 arch/x86/xen/mmu_pv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/xen/mmu_pv.c +1 -1
index 509f560bd0c6..7330cb3b2283 100644
@@ -2220,7 +2220,7 @@ static void __init xen_write_cr3_init(unsigned long cr3)
  * not the first page table in the page table pool.
  * Iterate through the initial page tables to find the real page table base.
  */
-static phys_addr_t xen_find_pt_base(pmd_t *pmd)
+static phys_addr_t __init xen_find_pt_base(pmd_t *pmd)
 {
 	phys_addr_t pt_base, paddr;
 	unsigned pmdidx;
Signature · 7 lines
2.9.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel
reviewer Applied
#1 lore raw
Quoted 8 lines · Arnd Bergmann

gcc-4.6 causes a harmless link-time warning:

WARNING: vmlinux.o(.text.unlikely+0x48e): Section mismatch in reference from the function xen_find_pt_base() to the function .init.text:m2p() The function xen_find_pt_base() references
the function __init m2p().
This is often because xen_find_pt_base lacks a __init
annotation or the annotation of m2p is wrong.

Quoted 5 lines

Newer compilers inline this function, so it never shows up, but marking it __init is the right way to avoid the warning.

Fixes 70e61199559a ("xen: move p2m list if conflicting with e820 map")

Applied to for-linus-14b.

-boris

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel

reviewer Applied
#2 lore raw
In reply to Arnd Bergmann
Quoted 8 lines · Arnd Bergmann

gcc-4.6 causes a harmless link-time warning:

WARNING: vmlinux.o(.text.unlikely+0x48e): Section mismatch in reference from the function xen_find_pt_base() to the function .init.text:m2p() The function xen_find_pt_base() references
the function __init m2p().
This is often because xen_find_pt_base lacks a __init
annotation or the annotation of m2p is wrong.

Quoted 5 lines

Newer compilers inline this function, so it never shows up, but marking it __init is the right way to avoid the warning.

Fixes 70e61199559a ("xen: move p2m list if conflicting with e820 map")

Applied to for-linus-14b.

-boris