drm/radeon: properly initialize r600_audio_status() data
Subsystems (2)
PATCH 1/1 drm/radeon: properly initialize r600_audio_status() data
The structure returned from r600_audio_status() is only partially initialized, and older gcc versions (4.3 and 4.4) warn about this:
drivers/gpu/drm/radeon/r600_hdmi.c: In function 'r600_audio_status':drivers/gpu/drm/radeon/r600_hdmi.c:108: error: 'status.id' is used uninitialized in this function drivers/gpu/drm/radeon/r600_hdmi.c:108: error: 'status.connected' is used uninitialized in this function drivers/gpu/drm/radeon/r600_hdmi.c:108: error: 'status.offset' is used uninitialized in this function
This is harmless and surprisingly correct in C99, as the caller only accesses the fields that got initialized, so newer compilers don't warn about it, but initializing the entire structure feels like the right thing to do here and avoids the warning.
--- drivers/gpu/drm/radeon/r600_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/radeon/r600_hdmi.c +1 -1
@@ -58,7 +58,7 @@ enum r600_hdmi_iec_status_bits {static struct r600_audio_pin r600_audio_status (struct radeon_device *rdev) { -struct r600_audio_pin status; +struct r600_audio_pin status = {};uint32_t value; value =RREG32 (R600_AUDIO_RATE_BPS_CHANNEL );
Signature · 6 lines
2.9.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Am 15.09.2017 um 22:06 schrieb Arnd Bergmann:
Quoted 8 lines
The structure returned from
r600_audio_status()is only partially initialized, and older gcc versions (4.3 and 4.4) warn about this:
drivers/gpu/drm/radeon/r600_hdmi.c: In function 'r600_audio_status':drivers/gpu/drm/radeon/r600_hdmi.c:108: error: 'status.id' is used uninitialized in this functiondrivers/gpu/drm/radeon/r600_hdmi.c:108: error: 'status.connected' is used uninitialized in this functiondrivers/gpu/drm/radeon/r600_hdmi.c:108: error: 'status.offset' is used uninitialized in this function
Quoted 6 lines
This is harmless and surprisingly correct in C99, as the caller only accesses the fields that got initialized, so newer compilers don't warn about it, but initializing the entire structure feels like the right thing to do here and avoids the warning.
Signed-off-by Arnd Bergmann <[email protected]>
Quoted 9 lines
--- drivers/gpu/drm/radeon/r600_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/radeon/r600_hdmi.c +0
-0
drivers/gpu/drm/radeon/r600_hdmi.c enum r600_hdmi_iec_status_bits { · line 64
Quoted 8 lines
drivers/gpu/drm/radeon/r600_hdmi.c +1
-1@@ -58,7 +58,7 @@ enum r600_hdmi_iec_status_bits {static struct r600_audio_pin r600_audio_status (struct radeon_device *rdev) { -struct r600_audio_pin status; +struct r600_audio_pin status = {};uint32_t value; value =RREG32 (R600_AUDIO_RATE_BPS_CHANNEL );
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Alex Deucher
AppliedQuoted 18 lines · Christian König
Am 15.09.2017 um 22:06 schrieb Arnd Bergmann:
Quoted 17 lines
The structure returned from
r600_audio_status()is only partially initialized, and older gcc versions (4.3 and 4.4) warn about this:
drivers/gpu/drm/radeon/r600_hdmi.c: In function 'r600_audio_status':drivers/gpu/drm/radeon/r600_hdmi.c:108: error: 'status.id' is used uninitialized in this functiondrivers/gpu/drm/radeon/r600_hdmi.c:108: error: 'status.connected' is used uninitialized in this functiondrivers/gpu/drm/radeon/r600_hdmi.c:108: error: 'status.offset' is used uninitialized in this functionThis is harmless and surprisingly correct in C99, as the caller only accesses the fields that got initialized, so newer compilers don't warn about it, but initializing the entire structure feels like the right thing to do here and avoids the warning.
Quoted 4 lines
Quoted 1 line
Signed-off-by Arnd Bergmann <[email protected]>Reviewed-by Christian König <[email protected]>
Applied. thanks!
Alex
Quoted 17 lines
Quoted 17 lines
--- drivers/gpu/drm/radeon/r600_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/radeon/r600_hdmi.c +1
-1@@ -58,7 +58,7 @@ enum r600_hdmi_iec_status_bits {static struct r600_audio_pin r600_audio_status (struct radeon_device *rdev) { -struct r600_audio_pin status; +struct r600_audio_pin status = {};uint32_t value;
Quoted 8 lines
drivers/gpu/drm/radeon/r600_hdmi.c enum r600_hdmi_iec_status_bits { · line 64
Quoted 1 line
drivers/gpu/drm/radeon/r600_hdmi.c +0
-0value =RREG32 (R600_AUDIO_RATE_BPS_CHANNEL );_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel