Skip to contentSkip to conversation

xen, arm64: drop dummy lookup_address()

PATCH Applied Tycho Andersen 4 participants 4 messages Sep 18, 2017 – Sep 19, 2017 Xen hypervisor interface

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen, arm64: drop dummy lookup_address()

This is unused, and conflicts with the definition that we'll add for XPFO.

CC Boris Ostrovsky <[email protected]>
CC Juergen Gross <[email protected]>
CC Stefano Stabellini <[email protected]>

---
The patch this depends on is in for-linus-4.14b, so it would be easiest to carry this one too; Stefano can you ack it and Boris can you carry it?

Thanks!

---
 include/xen/arm/page.h | 10 ----------
 1 file changed, 10 deletions(-)
include/xen/arm/page.h +0 -10
index 415dbc6e43fd..6adc2a955340 100644
@@ -84,16 +84,6 @@ static inline xmaddr_t arbitrary_virt_to_machine(void *vaddr)
 	BUG();
 }
 
-/* TODO: this shouldn't be here but it is because the frontend drivers
- * are using it (its rolled in headers) even though we won't hit the code path.
- * So for right now just punt with this.
- */
-static inline pte_t *lookup_address(unsigned long address, unsigned int *level)
-{
-	BUG();
-	return NULL;
-}
-
 extern int set_foreign_p2m_mapping(struct gnttab_map_grant_ref *map_ops,
 				   struct gnttab_map_grant_ref *kmap_ops,
 				   struct page **pages, unsigned int count);
Signature · 7 lines
2.11.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 6 lines · Tycho Andersen

This is unused, and conflicts with the definition that we'll add for XPFO.

CC Boris Ostrovsky <[email protected]>
CC Juergen Gross <[email protected]>
CC Stefano Stabellini <[email protected]>

Cheers,

Quoted 31 lines

---
The patch this depends on is in for-linus-4.14b, so it would be easiest to carry this one too; Stefano can you ack it and Boris can you carry it?

Thanks!

---
  include/xen/arm/page.h | 10 ----------
  1 file changed, 10 deletions(-)
include/xen/arm/page.h +0 -10
index 415dbc6e43fd..6adc2a955340 100644
@@ -84,16 +84,6 @@ static inline xmaddr_t arbitrary_virt_to_machine(void *vaddr)
  	BUG();
  }
 
-/* TODO: this shouldn't be here but it is because the frontend drivers
- * are using it (its rolled in headers) even though we won't hit the code path.
- * So for right now just punt with this.
- */
-static inline pte_t *lookup_address(unsigned long address, unsigned int *level)
-{
-	BUG();
-	return NULL;
-}
-
  extern int set_foreign_p2m_mapping(struct gnttab_map_grant_ref *map_ops,
  				   struct gnttab_map_grant_ref *kmap_ops,
  				   struct page **pages, unsigned int count);
Signature · 6 lines
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel
#2 lore raw
In reply to Tycho Andersen
Quoted 9 lines · Tycho Andersen

This is unused, and conflicts with the definition that we'll add for XPFO.

CC Boris Ostrovsky <[email protected]>
CC Juergen Gross <[email protected]>
CC Stefano Stabellini <[email protected]>

---
The patch this depends on is in for-linus-4.14b, so it would be easiest to carry this one too; Stefano can you ack it and Boris can you carry it?

Applied to for-linus-14b.

-boris

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel

maintainer Reviewed-by
#3 lore raw
Quoted 10 lines · Boris Ostrovsky
Quoted 9 lines · Tycho Andersen

This is unused, and conflicts with the definition that we'll add for XPFO.

CC Boris Ostrovsky <[email protected]>
CC Juergen Gross <[email protected]>
CC Stefano Stabellini <[email protected]>

---
The patch this depends on is in for-linus-4.14b, so it would be easiest to carry this one too; Stefano can you ack it and Boris can you carry it?

Quoted 1 line

Applied to for-linus-14b.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel