Skip to contentSkip to conversation

memorder: Remove unnecessary comma

PATCH Applied SeongJae Park 2 participants 4 messages Sep 19, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 memorder: Remove unnecessary comma

---
 memorder/memorder.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
memorder/memorder.tex +2 -2
index f7ec84a..820e718 100644
@@ -1254,7 +1254,7 @@ exists (1:r2=x0 /\ 1:r3=1)
 \end{listing}
 
 Listing~\ref{lst:memorder:Message-Passing Address-Dependency Litmus Test (No Ordering)}
-(\path{C-MP+o-wmb-o+o-addr-o.litmus}),
+(\path{C-MP+o-wmb-o+o-addr-o.litmus})
 shows a linked variant of the message-passing pattern.
 The head pointer is \co{x1}, which initially
 references the \co{int} variable \co{y} (line~5), which is in turn
@@ -1576,7 +1576,7 @@ exists (1:r2=2 /\ 0:r2=2)
 \end{listing}
 
 Listing~\ref{lst:memorder:Load-Buffering Control-Dependency Litmus Test}
-(\path{C-LB+o-r+o-ctrl-o.litmus}),
+(\path{C-LB+o-r+o-ctrl-o.litmus})
 shows another load-buffering example, this time using a control
 dependency (line~19) to order the load on line~18 and the store on
 line~20.
Signature · 1 line
2.10.0
#1 lore raw

PATCH 2/3 memorder: Fix wrong function reference

---
 memorder/memorder.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
memorder/memorder.tex +1 -1
index 820e718..85ba46e 100644
@@ -1714,7 +1714,7 @@ where ``IRIW'' stands
 for ``independent reads of independent writes''.
 Because this litmus test uses only one variable,
 \co{P2()} and \co{P3()} must agree
-on the order of \co{P0()}'s and \co{P()}'s stores.
+on the order of \co{P0()}'s and \co{P1()}'s stores.
 In other words, if \co{P2()} believes that \co{P0()}'s store
 came first, then \co{P3()} had better not believe that
 \co{P1()}'s store came first.
Signature · 1 line
2.10.0
#2 lore raw

PATCH 3/3 memorder: Present P0()-P3() in consistent manner

In reply to SeongJae Park
---
 memorder/memorder.tex | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
memorder/memorder.tex +6 -6
index 85ba46e..5df5649 100644
@@ -1982,12 +1982,12 @@ This sequence of events will depend critically on \co{P0()} and
 Figure~\ref{fig:memorder:Shared Store Buffers And Multi-Copy Atomicity}.
 
 \QuickQuiz{}
-	But just how is it fair that P0 and P1 must share a store buffer
-	and a cache, but P2 gets one each of its very own???
+	But just how is it fair that \co{P0()} and \co{P1()} must share a store
+	buffer and a cache, but \co{P2()} gets one each of its very own???
 \QuickQuizAnswer{
-	Presumably there is a P3, as is in fact shown in
+	Presumably there is a \co{P3()}, as is in fact shown in
 	Figure~\ref{fig:memorder:Shared Store Buffers And Multi-Copy Atomicity},
-	that shares P2's store buffer and cache.
+	that shares \co{P2()}'s store buffer and cache.
 	But not necessarily.
 	Some platforms allow different cores to disable different numbers
 	of threads, allowing the hardware to adjust to the needs of the
@@ -2008,8 +2008,8 @@ Figure~\ref{fig:memorder:Shared Store Buffers And Multi-Copy Atomicity}.
 } \QuickQuizEnd
 
 Row~1 shows the initial state, with the initial value of \co{y} in
-P0's and P1's shared cache, and the initial value of \co{x} in
-P2's cache.
+\co{P0()}'s and \co{P1()}'s shared cache, and the initial value of \co{x} in
+\co{P2()}'s cache.
 
 Row~2 shows the immediate effect of \co{P0()} executing its store on line~8.
 Because the cacheline containing \co{x} is not in \co{P0()}'s and \co{P1()}'s
Signature · 1 line
2.10.0
#3 lore raw
In reply to SeongJae Park
Quoted 1 line · SeongJae Park

Queued and pushed all three, good eyes, thank you!!!

Thanx, Paul

Quoted 29 lines
---
 memorder/memorder.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
memorder/memorder.tex +2 -2
index f7ec84a..820e718 100644
@@ -1254,7 +1254,7 @@ exists (1:r2=x0 /\ 1:r3=1)
 \end{listing}
 
 Listing~\ref{lst:memorder:Message-Passing Address-Dependency Litmus Test (No Ordering)}
-(\path{C-MP+o-wmb-o+o-addr-o.litmus}),
+(\path{C-MP+o-wmb-o+o-addr-o.litmus})
 shows a linked variant of the message-passing pattern.
 The head pointer is \co{x1}, which initially
 references the \co{int} variable \co{y} (line~5), which is in turn
@@ -1576,7 +1576,7 @@ exists (1:r2=2 /\ 0:r2=2)
 \end{listing}
 
 Listing~\ref{lst:memorder:Load-Buffering Control-Dependency Litmus Test}
-(\path{C-LB+o-r+o-ctrl-o.litmus}),
+(\path{C-LB+o-r+o-ctrl-o.litmus})
 shows another load-buffering example, this time using a control
 dependency (line~19) to order the load on line~18 and the store on
 line~20.
Signature · 1 line
2.10.0