net: ethernet: aquantia: default to no in config
Subsystems (2)
PATCH 1/1 net: ethernet: aquantia: default to no in config
NET_VENDOR_AQUANTIA was "default y" for some reason, which seems obviously inappropriate.
--- drivers/net/ethernet/aquantia/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/aquantia/Kconfig +1 -1
@@ -4,7 +4,7 @@ config NET_VENDOR_AQUANTIA bool "aQuantia devices" - default y + default n ---help--- Set this to y if you have an Ethernet network cards that uses the aQuantia AQC107/AQC108 chipset.
Signature · 1 line
2.11.0
David Miller
maintainerFrom: Vito Caputo <[email protected]>
Date: Tue, 19 Sep 2017 15:43:15 -0700
Quoted 2 lines
NET_VENDOR_AQUANTIAwas "default y" for some reason, which seems obviously inappropriate.
It is appropriate.
We make all vendor guards default to yes.
Quoted 9 lines · David Miller
From: Vito Caputo <[email protected]>
Date: Tue, 19 Sep 2017 15:43:15 -0700Quoted 2 lines
NET_VENDOR_AQUANTIAwas "default y" for some reason, which seems obviously inappropriate.It is appropriate.
We make all vendor guards default to yes.
Thanks for the quick response.
Out of curiosity, what's the rationale for that decision?
David Miller
maintainerFrom: [email protected]
Date: Tue, 19 Sep 2017 16:02:49 -0700
Quoted 1 line
Out of curiosity, what's the rationale for that decision?
So that you don't need to know what special vendor knob needs to be switched in order to even be offered the config knob for the driver you are interested in.
Hello!
Quoted 11 lines · Vito Caputo
NET_VENDOR_AQUANTIAwas "default y" for some reason, which seems obviously inappropriate.--- drivers/net/ethernet/aquantia/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/ethernet/aquantia/Kconfig +0
-0
drivers/net/ethernet/aquantia/Kconfig line 7
Quoted 5 lines
drivers/net/ethernet/aquantia/Kconfig +1
-1@@ -4,7 +4,7 @@ config NET_VENDOR_AQUANTIA bool "aQuantia devices" - default y + default n
Just remove it -- 'n' is the default default. :-)
[...]
MBR, Sergei