Skip to contentSkip to conversation

cifs: show 'soft' in the mount options for !hard mounts

PATCH In review Ronnie Sahlberg 2 participants 4 messages Sep 20, 2017 3 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cifs: show 'soft' in the mount options for !hard mounts

---
 fs/cifs/cifsfs.c | 2 ++
 1 file changed, 2 insertions(+)
fs/cifs/cifsfs.c +2 -0
index 180b3356ff86..a864e6575309 100644
@@ -461,6 +461,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)
 		seq_puts(s, ",nocase");
 	if (tcon->retry)
 		seq_puts(s, ",hard");
+	else
+		seq_puts(s, ",soft");
 	if (tcon->use_persistent)
 		seq_puts(s, ",persistenthandles");
 	else if (tcon->use_resilient)
Signature · 1 line
2.13.3

A message that is not in the archive (sent off-list or not yet received): CAH2r5msLbzwzFvwosLpLJLeLNu4+3EEs=UTxZoOzyXeOWX6mjQ@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CAH2r5msLbzwzFvwosLpLJLeLNu4+3EEs=UTxZoOzyXeOWX6mjQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#3 lore raw

No option on stable.

It is a trivial but purely cosmetic patch. Probably not worth the effort to post to stable.

----- Original Message -----
From: "Steve French" <[email protected]>
To: "Ronnie Sahlberg" <[email protected]>
Cc: "linux-cifs" <[email protected]>
Sent: Wednesday, 20 September, 2017 1:22:11 PM
Subject: Re: [PATCH] cifs: show 'soft' in the mount options for !hard mounts

Opinions on stable?

Quoted 23 lines · Ronnie Sahlberg
---
 fs/cifs/cifsfs.c | 2 ++
 1 file changed, 2 insertions(+)
fs/cifs/cifsfs.c +2 -0
index 180b3356ff86..a864e6575309 100644
@@ -461,6 +461,8 @@ cifs_show_options(struct seq_file *s, struct dentry
 *root)
                seq_puts(s, ",nocase");
        if (tcon->retry)
                seq_puts(s, ",hard");
+       else
+               seq_puts(s, ",soft");
        if (tcon->use_persistent)
                seq_puts(s, ",persistenthandles");
        else if (tcon->use_resilient)

--
2.13.3

#4 lore raw
In reply to a message not in the archive

What does NFS do - does it show both "soft" and "hard"?

Quoted 27 lines · Steve French

Opinions on stable?

Quoted 23 lines · Ronnie Sahlberg
---
 fs/cifs/cifsfs.c | 2 ++
 1 file changed, 2 insertions(+)
fs/cifs/cifsfs.c +2 -0
index 180b3356ff86..a864e6575309 100644
@@ -461,6 +461,8 @@ cifs_show_options(struct seq_file *s, struct dentry
 *root)
                seq_puts(s, ",nocase");
        if (tcon->retry)
                seq_puts(s, ",hard");
+       else
+               seq_puts(s, ",soft");
        if (tcon->use_persistent)
                seq_puts(s, ",persistenthandles");
        else if (tcon->use_resilient)

--
2.13.3

Signature · 3 lines
Thanks,

Steve

A message that is not in the archive (sent off-list or not yet received): CAH2r5mtW38uGGO5LPKyy=O8mzctgq0kLAWbBadzk+0ztvF6Org-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#6 lore raw

NFS does the same, well except for the fact that 'hard' is default in that land.

NFS:
Mount with 'hard' : mount shows ',hard'
Mount with 'soft' : mount shows ',soft'
Mount with default : mount shows ',hard'

----- Original Message -----
From: "Steve French" <[email protected]>
To: "Ronnie Sahlberg" <[email protected]>
Cc: "linux-cifs" <[email protected]>
Sent: Wednesday, 20 September, 2017 1:25:52 PM
Subject: Re: [PATCH] cifs: show 'soft' in the mount options for !hard mounts

What does NFS do - does it show both "soft" and "hard"?

Quoted 27 lines · Steve French

Opinions on stable?

Quoted 23 lines · Ronnie Sahlberg
---
 fs/cifs/cifsfs.c | 2 ++
 1 file changed, 2 insertions(+)
fs/cifs/cifsfs.c +2 -0
index 180b3356ff86..a864e6575309 100644
@@ -461,6 +461,8 @@ cifs_show_options(struct seq_file *s, struct dentry
 *root)
                seq_puts(s, ",nocase");
        if (tcon->retry)
                seq_puts(s, ",hard");
+       else
+               seq_puts(s, ",soft");
        if (tcon->use_persistent)
                seq_puts(s, ",persistenthandles");
        else if (tcon->use_resilient)

--
2.13.3

Signature · 7 lines
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html