nfs: override uid and gid for exclusive creates in nfs3_proc_create
Subsystems (2)
PATCH 1/1 nfs: override uid and gid for exclusive creates in nfs3_proc_create
RFC 1813 section 3.3.8 states
Once the client has performed a successful exclusive create, it must issue a SETATTR to set the correct file attributes. Until it does so, it should not rely upon any of the file attributes, since the server implementation may need to overload file metadata to store the verifier.
HP-UX expects the client to send the uid and gid in the post-create setattr for exclusive creates. Customers are sometimes seeing bogus values because the Linux NFS client is only updating the atime and mtime.
--- fs/nfs/nfs3proc.c | 7 +++++++ 1 file changed, 7 insertions(+)
fs/nfs/nfs3proc.c +7 -0
@@ -370,6 +370,13 @@ nfs3_proc_create(struct inode *dir, struct dentry *dentry, struct iattr *sattr,if (data->arg.create.createmode ==NFS3_CREATE_EXCLUSIVE ) {dprintk ("NFS call setattr (post-create)\n" ); + sattr->ia_uid =current_fsuid (); + sattr->ia_valid |=ATTR_UID ; +if (dir->i_mode &S_ISGID ) + sattr->ia_gid = dir->i_gid; +else + sattr->ia_gid =current_fsgid (); + sattr->ia_valid |=ATTR_GID ;if (!(sattr->ia_valid &ATTR_ATIME_SET )) sattr->ia_valid |=ATTR_ATIME ;if (!(sattr->ia_valid &ATTR_MTIME_SET ))
Signature · 1 line
2.9.5
T24gRnJpLCAyMDE3LTA5LTIyIGF0IDE2OjE1IC0wNDAwLCBTY290dCBNYXloZXcgd3JvdGU6DQo+ IFJGQyAxODEzIHNlY3Rpb24gMy4zLjggc3RhdGVzDQo+IA0KPiAgICAgICBPbmNlIHRoZSBjbGll bnQgaGFzIHBlcmZvcm1lZCBhIHN1Y2Nlc3NmdWwgZXhjbHVzaXZlDQo+ICAgICAgIGNyZWF0ZSwg aXQgbXVzdCBpc3N1ZSBhIFNFVEFUVFIgdG8gc2V0IHRoZSBjb3JyZWN0IGZpbGUNCj4gICAgICAg YXR0cmlidXRlcy4gIFVudGlsIGl0IGRvZXMgc28sIGl0IHNob3VsZCBub3QgcmVseSB1cG9uIGFu eQ0KPiAgICAgICBvZiB0aGUgZmlsZSBhdHRyaWJ1dGVzLCBzaW5jZSB0aGUgc2VydmVyIGltcGxl bWVudGF0aW9uDQo+ICAgICAgIG1heSBuZWVkIHRvIG92ZXJsb2FkIGZpbGUgbWV0YWRhdGEgdG8g c3RvcmUgdGhlIHZlcmlmaWVyLg0KPiANCj4gSFAtVVggZXhwZWN0cyB0aGUgY2xpZW50IHRvIHNl bmQgdGhlIHVpZCBhbmQgZ2lkIGluIHRoZSBwb3N0LWNyZWF0ZQ0KPiBzZXRhdHRyIGZvciBleGNs dXNpdmUgY3JlYXRlcy4gIEN1c3RvbWVycyBhcmUgc29tZXRpbWVzIHNlZWluZyBib2d1cw0KPiB2 YWx1ZXMgYmVjYXVzZSB0aGUgTGludXggTkZTIGNsaWVudCBpcyBvbmx5IHVwZGF0aW5nIHRoZSBh dGltZSBhbmQNCj4gbXRpbWUuDQoNCkknbSBzb3JyeSwgYnV0IHRoYXQgaXMganVzdCBpbnNhbmVs eSBzdHVwaWQgc2VydmVyIGJlaGF2aW91ci4gSG93IGRvDQp5b3UgZ3VhcmFudGVlIHRoYXQgYSBz ZWNvbmQgY2xpZW50IHdvbid0IGhpamFjayB0aGUgZmlsZSBieSBzZW5kaW5nDQp0aGVpciBvd24g U0VUQVRUUiBjYWxsIGJlZm9yZSB5b3VyIGNsaWVudCBoYXMgYW4gb3Bwb3J0dW5pdHkgdG8gc2V0 IHRoZQ0Kb3duZXI/DQoNCi0tIA0KVHJvbmQgTXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1h aW50YWluZXIsIFByaW1hcnlEYXRhDQp0cm9uZC5teWtsZWJ1c3RAcHJpbWFyeWRhdGEuY29tDQo=