SPL: SPI: sunxi: add SPL FIT image support
PATCH 1/1 SPL: SPI: sunxi: add SPL FIT image support
The sunxi-specific SPI load routine only knows how to load a legacy U-Boot image.
Teach it how to handle FIT images as well, simply by providing the existing SPL FIT loader with the right loader routine to access the SPI NOR flash.
---
Hi,
this patch was actually part of an early version of the SPL FIT series, but I somehow managed to drop it during some rebase.
This is needed to enable SPI boot when using a FIT image, so this fixes SPI booting on 64-bit Allwinner boards, like the OrangePi PC2 and the Pine64 SoPine.
I would be grateful if it could make it into v2017.11.
Cheers,
Andre.
drivers/mtd/spi/sunxi_spi_spl.c | 39 ++++++++++++++++++++++++++++++++------- 1 file changed, 32 insertions(+), 7 deletions(-)
drivers/mtd/spi/sunxi_spi_spl.c +32 -7
@@ -8,6 +8,7 @@#include <spl.h> #include <asm/gpio.h> #include <asm/io.h> +#include <libfdt.h> #ifdef CONFIG_SPL_OS_BOOT #error CONFIG_SPL_OS_BOOT is not supported yet
@@ -261,27 +262,51 @@ static void spi0_read_data(void *buf, u32 addr, u32 len) } } +static ulong spi_load_read (struct spl_load_info *load,ulong sector, +ulong count,void *buf) +{ +spi0_read_data (buf, sector, count); + +return count; +} +/*****************************************************************************/ static int spl_spi_load_image (struct spl_image_info *spl_image,struct spl_boot_device *bootdev) { -int err; +int ret =0 ;struct image_header *header; header = (struct image_header *)(CONFIG_SYS_TEXT_BASE );spi0_init ();spi0_read_data ((void *)header,CONFIG_SYS_SPI_U_BOOT_OFFS ,0x40 ); - err =spl_parse_image_header (spl_image, header); -if (err) -return err; -spi0_read_data ((void *)spl_image->load_addr,CONFIG_SYS_SPI_U_BOOT_OFFS , - spl_image->size); +if (IS_ENABLED (CONFIG_SPL_LOAD_FIT ) && +image_get_magic (header) ==FDT_MAGIC ) { +struct spl_load_info load; + +debug ("Found FIT image\n" ); + load.dev =NULL ; + load.priv =NULL ; + load.filename =NULL ; + load.bl_len =1 ; + load.read = spi_load_read; + ret =spl_load_simple_fit (spl_image, &load, +CONFIG_SYS_SPI_U_BOOT_OFFS , header); + }else { + ret =spl_parse_image_header (spl_image, header); +if (ret) +return ret; + +spi0_read_data ((void *)spl_image->load_addr, +CONFIG_SYS_SPI_U_BOOT_OFFS , spl_image->size); + }spi0_deinit (); -return 0 ; + +return ret; }/* Use priorty 0 to override the default if it happens to be linked in */ SPL_LOAD_IMAGE_METHOD ("sunxi SPI" ,0 ,BOOT_DEVICE_SPI , spl_spi_load_image);
Signature · 1 line
2.14.1
PATCH 1/1 SPL: SPI: sunxi: add SPL FIT image support
Quoted 8 lines · Andre Przywara
The sunxi-specific SPI load routine only knows how to load a legacy U-Boot image.
Teach it how to handle FIT images as well, simply by providing the existing SPL FIT loader with the right loader routine to access the SPI NOR flash.Signed-off-by Andre Przywara <[email protected]>Reported-by Peter Kosa <[email protected]>
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170925/7a966a46/attachment.sig>
PATCH 1/1 SPL: SPI: sunxi: add SPL FIT image support
Quoted 7 lines · Maxime Ripard
Quoted 6 lines · Andre Przywara
The sunxi-specific SPI load routine only knows how to load a legacy U-Boot image.
Teach it how to handle FIT images as well, simply by providing the existing SPL FIT loader with the right loader routine to access the SPI NOR flash.
Quoted 5 lines
Quoted 2 lines
Signed-off-by Andre Przywara <[email protected]>Reported-by Peter Kosa <[email protected]>Acked-by Maxime Ripard <[email protected]>Maxime
Applied to u-boot-spi/master
thanks!
Signature · 4 lines
Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India.