Fix C++ kernel in include/linux/mtd/mtd.h
PATCH 1/1 Fix C++ kernel in include/linux/mtd/mtd.h
C++ comments look wrong in kernel tree. Fix one.
include/linux/mtd/mtd.h +1 -1
@@ -267,7 +267,7 @@ struct mtd_info {*/ unsigned int bitflip_threshold; -// Kernel-only stuff starts here. +/* Kernel-only stuff starts here. */ const char *name;int index;
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 1 line · Pavel Machek
C++ comments look wrong in kernel tree. Fix one.
AFAIR they are now (sadly) accepted, but this patch works for me. Would be nice if trivial could pick it.
Quoted 16 lines
Signed-off-by Pavel Machek <[email protected]>include/linux/mtd/mtd.h +1
-1@@ -267,7 +267,7 @@ struct mtd_info {*/ unsigned int bitflip_threshold; -// Kernel-only stuff starts here. +/* Kernel-only stuff starts here. */ const char *name;int index;
Signature · 2 lines
Best regards, Marek Vasut
Boris Brezillon
Acked-byQuoted 4 lines · On Sat, 23 Sep 2017 23:10:26 +0200 Marek Vasut <[email protected]> wrote:
Quoted 1 line · Pavel Machek
C++ comments look wrong in kernel tree. Fix one.
AFAIR they are now (sadly) accepted, but this patch works for me.
Works for me too. Here is my
Quoted 1 line
Would be nice if trivial could pick it.
Hm, I'd recommend not doing that, otherwise we might end up with a conflict if a patch modify something in this area.
Quoted 19 lines
Quoted 17 lines
Signed-off-by Pavel Machek <[email protected]>include/linux/mtd/mtd.h +1
-1@@ -267,7 +267,7 @@ struct mtd_info {*/ unsigned int bitflip_threshold; -// Kernel-only stuff starts here. +/* Kernel-only stuff starts here. */ const char *name;int index;
Richard Weinberger
maintainerAm Sonntag, 24. September 2017, 10:20:06 CEST schrieb Boris Brezillon:
Quoted 8 lines
On Sat, 23 Sep 2017 23:10:26 +0200
Quoted 4 lines · Marek Vasut
Quoted 1 line · Pavel Machek
C++ comments look wrong in kernel tree. Fix one.
AFAIR they are now (sadly) accepted, but this patch works for me.
Quoted 8 lines
Works for me too. Here is my
Acked-by Boris Brezillon <[email protected]>Quoted 1 line
Would be nice if trivial could pick it.
Hm, I'd recommend not doing that, otherwise we might end up with a conflict if a patch modify something in this area.
Let's carry it via MTD.
BTW: Shouldn't it be s/kernel/comment/ in the subject line?
Thanks,
//richard
Quoted 13 lines · Richard Weinberger
Am Sonntag, 24. September 2017, 10:20:06 CEST schrieb Boris Brezillon:
Quoted 12 lines
On Sat, 23 Sep 2017 23:10:26 +0200
Quoted 4 lines · Marek Vasut
Quoted 1 line · Pavel Machek
C++ comments look wrong in kernel tree. Fix one.
AFAIR they are now (sadly) accepted, but this patch works for me.
Works for me too. Here is my
Acked-by Boris Brezillon <[email protected]>
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Would be nice if trivial could pick it.
Hm, I'd recommend not doing that, otherwise we might end up with a conflict if a patch modify something in this area.
Let's carry it via MTD.
BTW: Shouldn't it be s/kernel/comment/ in the subject line?
Yes, it should. Can it be fixed while applying?
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Richard Weinberger
maintainerAm Freitag, 6. Oktober 2017, 13:55:14 CEST schrieb Pavel Machek:
Quoted 4 lines
Quoted 2 lines
Let's carry it via MTD.
BTW: Shouldn't it be s/kernel/comment/ in the subject line?Yes, it should. Can it be fixed while applying?
Sure. :)
Thanks,
//richard
Quoted 7 lines · Richard Weinberger
Am Freitag, 6. Oktober 2017, 13:55:14 CEST schrieb Pavel Machek:
Quoted 5 lines
Quoted 4 lines
Let's carry it via MTD.
BTW: Shouldn't it be s/kernel/comment/ in the subject line?Yes, it should. Can it be fixed while applying?
Sure. :)
You can change 'C++' to 'C99' too, while you're at it :)
Quoted 10 lines · David Woodhouse
Quoted 7 lines · Richard Weinberger
Am Freitag, 6. Oktober 2017, 13:55:14 CEST schrieb Pavel Machek:
Quoted 5 lines
Quoted 4 lines
Let's carry it via MTD.
BTW: Shouldn't it be s/kernel/comment/ in the subject line?Yes, it should. Can it be fixed while applying?
Sure. :)
You can change 'C++' to 'C99' too, while you're at it :)
No. They are C++ comments... as in... dangerous infection that came from C++. Yes, C99 is infected, too, but still C++ is original source of infection :-).
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 5 lines · Pavel Machek
Quoted 1 line
You can change 'C++' to 'C99' too, while you're at it :)
No. They are C++ comments... as in... dangerous infection that came from C++. Yes, C99 is infected, too, but still C++ is original source of infection :-).
C++ is a different language, and irrelevant here. You could call them Java comments if you want, but that would be equally silly. In the kernel, they are C99 comments. Valid, but not our preferred style (which is fair enough, unlike our idiotic refusal to use C99 integer types).
Quoted 7 lines · On Fri, 06 Oct 2017 13:25:55 +0100 David Woodhouse <[email protected]> wrote:
Quoted 5 lines · Pavel Machek
Quoted 1 line
You can change 'C++' to 'C99' too, while you're at it :)
No. They are C++ comments... as in... dangerous infection that came from C++. Yes, C99 is infected, too, but still C++ is original source of infection :-).
Quoted 5 lines
C++ is a different language, and irrelevant here. You could call them Java comments if you want, but that would be equally silly. In the kernel, they are C99 comments. Valid, but not our preferred style (which is fair enough, unlike our idiotic refusal to use C99 integer types).
We might as well allow them. We are using those compiler settings so the cases where your compilation produces different results in C99 and more classic C are no longer a risk 8)
int main(int argc, char *argv[])
{
int x = 1//**/
-1;
if (x == 0)
puts("Ewww C99");
exit(0);
}Quoted 7 lines · Pavel Machek
Quoted 6 lines · David Woodhouse
Quoted 5 lines · Richard Weinberger
Am Freitag, 6. Oktober 2017, 13:55:14 CEST schrieb Pavel Machek:
Quoted 4 lines
Quoted 4 lines
Let's carry it via MTD.
BTW: Shouldn't it be s/kernel/comment/ in the subject line?
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Quoted 1 line
Yes, it should. Can it be fixed while applying?
Sure. :)
You can change 'C++' to 'C99' too, while you're at it :)
No. They are C++ comments... as in... dangerous infection that came from C++. Yes, C99 is infected, too, but still C++ is original source of infection :-).
No, it is not. See https://www.bell-labs.com/usr/dmr/www/bcpl.html and scans refered therein; let's keep snobbery historically accurate...
IOW, it's not C++ invention - it's BCPL one.
Quoted 11 lines · Al Viro
Quoted 10 lines · Pavel Machek
Quoted 8 lines · David Woodhouse
Quoted 5 lines · Richard Weinberger
Am Freitag, 6. Oktober 2017, 13:55:14 CEST schrieb Pavel Machek:
Quoted 3 lines
Quoted 2 lines
Let's carry it via MTD.
BTW: Shouldn't it be s/kernel/comment/ in the subject line?Yes, it should. Can it be fixed while applying?
Sure. :)
You can change 'C++' to 'C99' too, while you're at it :)
Quoted 8 lines
Quoted 3 lines
No. They are C++ comments... as in... dangerous infection that came from C++. Yes, C99 is infected, too, but still C++ is original source of infection :-).
No, it is not. See https://www.bell-labs.com/usr/dmr/www/bcpl.html and scans refered therein; let's keep snobbery historically accurate...
IOW, it's not C++ invention - it's BCPL one.
Ah, longing for the return of BPTRs and BSTRs ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds