Skip to contentSkip to conversation

ncpfs: ioctl: Delete unnecessary len variables

PATCH RESEND New Christos Gkekas 1 participant 1 message Sep 24, 2017

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 ncpfs: ioctl: Delete unnecessary len variables

Variables oldnamelen, oldprivatelen and oldlen are set but are never used, thus they need to be cleaned up.

---
 fs/ncpfs/ioctl.c | 6 ------
 1 file changed, 6 deletions(-)
fs/ncpfs/ioctl.c +0 -6
index 12550c2..85c6c60 100644
@@ -642,9 +642,7 @@ static long __ncp_ioctl(struct inode *inode, unsigned int cmd, unsigned long arg
 			struct ncp_objectname_ioctl user;
 			void* newname;
 			void* oldname;
-			size_t oldnamelen;
 			void* oldprivate;
-			size_t oldprivatelen;
 
 #ifdef CONFIG_COMPAT
 			if (cmd == NCP_IOC_SETOBJECTNAME_32) {
@@ -671,9 +669,7 @@ static long __ncp_ioctl(struct inode *inode, unsigned int cmd, unsigned long arg
 			}
 			down_write(&server->auth_rwsem);
 			oldname = server->auth.object_name;
-			oldnamelen = server->auth.object_name_len;
 			oldprivate = server->priv.data;
-			oldprivatelen = server->priv.len;
 			server->auth.auth_type = user.auth_type;
 			server->auth.object_name_len = user.object_name_len;
 			server->auth.object_name = newname;
@@ -742,7 +738,6 @@ static long __ncp_ioctl(struct inode *inode, unsigned int cmd, unsigned long arg
 			struct ncp_privatedata_ioctl user;
 			void* new;
 			void* old;
-			size_t oldlen;
 
 #ifdef CONFIG_COMPAT
 			if (cmd == NCP_IOC_SETPRIVATEDATA_32) {
@@ -767,7 +762,6 @@ static long __ncp_ioctl(struct inode *inode, unsigned int cmd, unsigned long arg
 			}
 			down_write(&server->auth_rwsem);
 			old = server->priv.data;
-			oldlen = server->priv.len;
 			server->priv.len = user.len;
 			server->priv.data = new;
 			up_write(&server->auth_rwsem);
Signature · 1 line
2.7.4