Skip to contentSkip to conversation

Fix typos in printk

PATCH In review Masanari Iida 3 participants 5 messages Sep 25, 2017 – Sep 26, 2017

Subsystems (13)
Network drivers DRM drivers SCSI Sound +9 more subsystems
lore
Share & tools
lore

Masanari Iida

author
#0 lore raw

PATCH 1/1 Fix typos in printk

This patch fix some spellint typo found in printk messages.

Signed-off-by Masanari Iida <[email protected]>
---
 drivers/fmc/fmc-core.c                                | 2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c             | 2 +-
 drivers/gpu/drm/i915/intel_cdclk.c                    | 4 ++--
 drivers/net/ethernet/qlogic/qed/qed_int.c             | 2 +-
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +-
 drivers/scsi/aacraid/src.c                            | 4 ++--
 drivers/scsi/qedi/qedi_fw.c                           | 2 +-
 fs/orangefs/orangefs-utils.c                          | 2 +-
 sound/soc/mediatek/mt2701/mt2701-afe-pcm.c            | 2 +-
 9 files changed, 11 insertions(+), 11 deletions(-)
drivers/fmc/fmc-core.c +1 -1
index cec3b8db0d69..bbcb505d1522 100644
@@ -244,7 +244,7 @@ int fmc_device_register_n_gw(struct fmc_device **devs, int n,
 		if (!fmc->carrier_name || !fmc->carrier_data ||
 		    !fmc->device_id) {
 			dev_err(fmc->hwdev,
-				"deivce nr %i: carrier name, "
+				"device nr %i: carrier name, "
 				"data or dev_id not set\n", i);
 			ret = -EINVAL;
 		}
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c +1 -1
index 36c763310df5..df856c986dfd 100644
@@ -280,7 +280,7 @@ amdgpu_ucode_get_load_type(struct amdgpu_device *adev, int load_type)
 		else
 			return AMDGPU_FW_LOAD_PSP;
 	default:
-		DRM_ERROR("Unknow firmware load type\n");
+		DRM_ERROR("Unknown firmware load type\n");
 	}
 
 	return AMDGPU_FW_LOAD_DIRECT;
drivers/gpu/drm/i915/intel_cdclk.c +2 -2
index 1241e5891b29..8f6632840b04 100644
@@ -1492,7 +1492,7 @@ static void cnl_cdclk_pll_disable(struct drm_i915_private *dev_priv)
 
 	/* Timeout 200us */
 	if (wait_for((I915_READ(BXT_DE_PLL_ENABLE) & BXT_DE_PLL_LOCK) == 0, 1))
-		DRM_ERROR("timout waiting for CDCLK PLL unlock\n");
+		DRM_ERROR("timeout waiting for CDCLK PLL unlock\n");
 
 	dev_priv->cdclk.hw.vco = 0;
 }

@@ -1510,7 +1510,7 @@ static void cnl_cdclk_pll_enable(struct drm_i915_private *dev_priv, int vco)
 
 	/* Timeout 200us */
 	if (wait_for((I915_READ(BXT_DE_PLL_ENABLE) & BXT_DE_PLL_LOCK) != 0, 1))
-		DRM_ERROR("timout waiting for CDCLK PLL lock\n");
+		DRM_ERROR("timeout waiting for CDCLK PLL lock\n");
 
 	dev_priv->cdclk.hw.vco = vco;
 }
drivers/net/ethernet/qlogic/qed/qed_int.c +1 -1
index 719cdbfe1695..932c589a0b22 100644
@@ -321,7 +321,7 @@ static int qed_pglub_rbc_attn_cb(struct qed_hwfn *p_hwfn)
 	tmp = qed_rd(p_hwfn, p_hwfn->p_dpc_ptt,
 		     PGLUE_B_REG_TX_ERR_WR_DETAILS_ICPL);
 	if (tmp & PGLUE_ATTENTION_ICPL_VALID)
-		DP_INFO(p_hwfn, "ICPL eror - %08x\n", tmp);
+		DP_INFO(p_hwfn, "ICPL error - %08x\n", tmp);
 
 	tmp = qed_rd(p_hwfn, p_hwfn->p_dpc_ptt,
 		     PGLUE_B_REG_MASTER_ZLR_ERR_DETAILS);
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +1 -1
index 7806a4d2b1fc..718a73c623a7 100644
@@ -4431,7 +4431,7 @@ void rtl8xxxu_gen1_init_aggregation(struct rtl8xxxu_priv *priv)
 			timeout = page_thresh;
 		else if (rtl8xxxu_dma_agg_pages <= 6)
 			dev_err(&priv->udev->dev,
-				"%s: dma_agg_pages=%i too small, minium is 6\n",
+				"%s: dma_agg_pages=%i too small, minimum is 6\n",
 				__func__, rtl8xxxu_dma_agg_pages);
 		else
 			dev_err(&priv->udev->dev,
drivers/scsi/aacraid/src.c +2 -2
index 48c2b2b34b72..e94f456c13cd 100644
@@ -784,7 +784,7 @@ static int aac_src_restart_adapter(struct aac_dev *dev, int bled, u8 reset_type)
 		if (!is_ctrl_up)
 			dev_err(&dev->pdev->dev, "IOP reset failed\n");
 		else {
-			dev_info(&dev->pdev->dev, "IOP reset succeded\n");
+			dev_info(&dev->pdev->dev, "IOP reset succeeded\n");
 			goto set_startup;
 		}
 	}

@@ -806,7 +806,7 @@ static int aac_src_restart_adapter(struct aac_dev *dev, int bled, u8 reset_type)
 			ret = -ENODEV;
 			goto out;
 		} else
-			dev_info(&dev->pdev->dev, "SOFT reset succeded\n");
+			dev_info(&dev->pdev->dev, "SOFT reset succeeded\n");
 	}
 
 set_startup:
drivers/scsi/qedi/qedi_fw.c +1 -1
index 93d54acd4a22..e5d728508734 100644
@@ -1884,7 +1884,7 @@ static int qedi_map_scsi_sg(struct qedi_ctx *qedi, struct qedi_cmd *cmd)
 		bd[bd_count].sge_len = (u16)sg_len;
 
 		QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_IO,
-			  "single-cashed-sgl: bd_count:%d addr=%llx, len=%x",
+			  "single-cached-sgl: bd_count:%d addr=%llx, len=%x",
 			  sg_count, addr, sg_len);
 
 		return ++bd_count;
fs/orangefs/orangefs-utils.c +1 -1
index aab6f1842963..50d38be6b0ad 100644
@@ -573,7 +573,7 @@ int orangefs_normalize_to_errno(__s32 error_code)
 	 * server.
 	 */
 	} else if (error_code > 0) {
-		gossip_err("orangefs: error status receieved.\n");
+		gossip_err("orangefs: error status received.\n");
 		gossip_err("orangefs: assuming error code is inverted.\n");
 		error_code = -error_code;
 	}
sound/soc/mediatek/mt2701/mt2701-afe-pcm.c +1 -1
index 8fda182f849b..8f1ea821a1ec 100644
@@ -359,7 +359,7 @@ static int mt2701_btmrg_hw_params(struct snd_pcm_substream *substream,
 	stream_fs = params_rate(params);
 
 	if ((stream_fs != 8000) && (stream_fs != 16000)) {
-		dev_err(afe->dev, "%s() btmgr not supprt this stream_fs %d\n",
+		dev_err(afe->dev, "%s() btmgr not support this stream_fs %d\n",
 			__func__, stream_fs);
 		return -EINVAL;
 	}
Signature · 1 line
2.14.1.729.g59c0ea183ad1
#1 lore raw

sound/soc/mediatek/mt2701/mt2701-afe-pcm.c static int mt2701_btmrg_hw_params(struct snd_pcm_substream *substream, · line 362

Quoted 3 lines
sound/soc/mediatek/mt2701/mt2701-afe-pcm.c +1 -1
 	if ((stream_fs != 8000) && (stream_fs != 16000)) {
-		dev_err(afe->dev, "%s() btmgr not supprt this stream_fs %d\n",
+		dev_err(afe->dev, "%s() btmgr not support this stream_fs %d\n",

I might be mistaken, but shouldn't it be "[...] btmgr *does* not support this stream_fs [...]" anyways?

sound/soc/mediatek/mt2701/mt2701-afe-pcm.c static int mt2701_btmrg_hw_params(struct snd_pcm_substream *substream, · line 365

Quoted 4 lines
sound/soc/mediatek/mt2701/mt2701-afe-pcm.c +0 -0
 			__func__, stream_fs);
 		return -EINVAL;
 	}

--
Regards,
Christoph

Acked-by on v1 1/1
#2 lore raw
In reply to Masanari Iida
Quoted 1 line · Masanari Iida

This patch fix some spellint typo found in printk messages.

fixes some spelling typos

Quoted 20 lines
Signed-off-by Masanari Iida <[email protected]>
---
 drivers/fmc/fmc-core.c                                | 2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c             | 2 +-
 drivers/gpu/drm/i915/intel_cdclk.c                    | 4 ++--
 drivers/net/ethernet/qlogic/qed/qed_int.c             | 2 +-
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +-
 drivers/scsi/aacraid/src.c                            | 4 ++--
 drivers/scsi/qedi/qedi_fw.c                           | 2 +-
 fs/orangefs/orangefs-utils.c                          | 2 +-
 sound/soc/mediatek/mt2701/mt2701-afe-pcm.c            | 2 +-
 9 files changed, 11 insertions(+), 11 deletions(-)
sound/soc/mediatek/mt2701/mt2701-afe-pcm.c +0 -0
index 8fda182f849b..8f1ea821a1ec 100644

sound/soc/mediatek/mt2701/mt2701-afe-pcm.c static int mt2701_btmrg_hw_params(struct snd_pcm_substream *substream, · line 365

Quoted 8 lines
sound/soc/mediatek/mt2701/mt2701-afe-pcm.c +1 -1
@@ -359,7 +359,7 @@ static int mt2701_btmrg_hw_params(struct snd_pcm_substream *substream,
 	stream_fs = params_rate(params);
 
 	if ((stream_fs != 8000) && (stream_fs != 16000)) {
-		dev_err(afe->dev, "%s() btmgr not supprt this stream_fs %d\n",
+		dev_err(afe->dev, "%s() btmgr not support this stream_fs %d\n",
 			__func__, stream_fs);
 		return -EINVAL;
 	}

same as what Christoph said above. Otherwise

Acked-by Randy Dunlap <[email protected]>

Thanks.

Signature · 1 line
~Randy
author
#3 lore raw

[PATCH/v2] [trivial] Fix typos and grammar in printk

This patch fixes some spelling typo and grammar error found in printk messages.

Signed-off-by Masanari Iida <[email protected]>
---
 drivers/fmc/fmc-core.c                                | 2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c             | 2 +-
 drivers/gpu/drm/i915/intel_cdclk.c                    | 4 ++--
 drivers/net/ethernet/qlogic/qed/qed_int.c             | 2 +-
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +-
 drivers/scsi/aacraid/src.c                            | 4 ++--
 drivers/scsi/qedi/qedi_fw.c                           | 2 +-
 fs/orangefs/orangefs-utils.c                          | 2 +-
 sound/soc/mediatek/mt2701/mt2701-afe-pcm.c            | 2 +-
 9 files changed, 11 insertions(+), 11 deletions(-)
drivers/fmc/fmc-core.c +1 -1
index cec3b8db0d69..bbcb505d1522 100644
@@ -244,7 +244,7 @@ int fmc_device_register_n_gw(struct fmc_device **devs, int n,
 		if (!fmc->carrier_name || !fmc->carrier_data ||
 		    !fmc->device_id) {
 			dev_err(fmc->hwdev,
-				"deivce nr %i: carrier name, "
+				"device nr %i: carrier name, "
 				"data or dev_id not set\n", i);
 			ret = -EINVAL;
 		}
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c +1 -1
index 36c763310df5..df856c986dfd 100644
@@ -280,7 +280,7 @@ amdgpu_ucode_get_load_type(struct amdgpu_device *adev, int load_type)
 		else
 			return AMDGPU_FW_LOAD_PSP;
 	default:
-		DRM_ERROR("Unknow firmware load type\n");
+		DRM_ERROR("Unknown firmware load type\n");
 	}
 
 	return AMDGPU_FW_LOAD_DIRECT;
drivers/gpu/drm/i915/intel_cdclk.c +2 -2
index 1241e5891b29..8f6632840b04 100644
@@ -1492,7 +1492,7 @@ static void cnl_cdclk_pll_disable(struct drm_i915_private *dev_priv)
 
 	/* Timeout 200us */
 	if (wait_for((I915_READ(BXT_DE_PLL_ENABLE) & BXT_DE_PLL_LOCK) == 0, 1))
-		DRM_ERROR("timout waiting for CDCLK PLL unlock\n");
+		DRM_ERROR("timeout waiting for CDCLK PLL unlock\n");
 
 	dev_priv->cdclk.hw.vco = 0;
 }

@@ -1510,7 +1510,7 @@ static void cnl_cdclk_pll_enable(struct drm_i915_private *dev_priv, int vco)
 
 	/* Timeout 200us */
 	if (wait_for((I915_READ(BXT_DE_PLL_ENABLE) & BXT_DE_PLL_LOCK) != 0, 1))
-		DRM_ERROR("timout waiting for CDCLK PLL lock\n");
+		DRM_ERROR("timeout waiting for CDCLK PLL lock\n");
 
 	dev_priv->cdclk.hw.vco = vco;
 }
drivers/net/ethernet/qlogic/qed/qed_int.c +1 -1
index 719cdbfe1695..932c589a0b22 100644
@@ -321,7 +321,7 @@ static int qed_pglub_rbc_attn_cb(struct qed_hwfn *p_hwfn)
 	tmp = qed_rd(p_hwfn, p_hwfn->p_dpc_ptt,
 		     PGLUE_B_REG_TX_ERR_WR_DETAILS_ICPL);
 	if (tmp & PGLUE_ATTENTION_ICPL_VALID)
-		DP_INFO(p_hwfn, "ICPL eror - %08x\n", tmp);
+		DP_INFO(p_hwfn, "ICPL error - %08x\n", tmp);
 
 	tmp = qed_rd(p_hwfn, p_hwfn->p_dpc_ptt,
 		     PGLUE_B_REG_MASTER_ZLR_ERR_DETAILS);
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +1 -1
index 7806a4d2b1fc..718a73c623a7 100644
@@ -4431,7 +4431,7 @@ void rtl8xxxu_gen1_init_aggregation(struct rtl8xxxu_priv *priv)
 			timeout = page_thresh;
 		else if (rtl8xxxu_dma_agg_pages <= 6)
 			dev_err(&priv->udev->dev,
-				"%s: dma_agg_pages=%i too small, minium is 6\n",
+				"%s: dma_agg_pages=%i too small, minimum is 6\n",
 				__func__, rtl8xxxu_dma_agg_pages);
 		else
 			dev_err(&priv->udev->dev,
drivers/scsi/aacraid/src.c +2 -2
index 48c2b2b34b72..e94f456c13cd 100644
@@ -784,7 +784,7 @@ static int aac_src_restart_adapter(struct aac_dev *dev, int bled, u8 reset_type)
 		if (!is_ctrl_up)
 			dev_err(&dev->pdev->dev, "IOP reset failed\n");
 		else {
-			dev_info(&dev->pdev->dev, "IOP reset succeded\n");
+			dev_info(&dev->pdev->dev, "IOP reset succeeded\n");
 			goto set_startup;
 		}
 	}

@@ -806,7 +806,7 @@ static int aac_src_restart_adapter(struct aac_dev *dev, int bled, u8 reset_type)
 			ret = -ENODEV;
 			goto out;
 		} else
-			dev_info(&dev->pdev->dev, "SOFT reset succeded\n");
+			dev_info(&dev->pdev->dev, "SOFT reset succeeded\n");
 	}
 
 set_startup:
drivers/scsi/qedi/qedi_fw.c +1 -1
index 93d54acd4a22..e5d728508734 100644
@@ -1884,7 +1884,7 @@ static int qedi_map_scsi_sg(struct qedi_ctx *qedi, struct qedi_cmd *cmd)
 		bd[bd_count].sge_len = (u16)sg_len;
 
 		QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_IO,
-			  "single-cashed-sgl: bd_count:%d addr=%llx, len=%x",
+			  "single-cached-sgl: bd_count:%d addr=%llx, len=%x",
 			  sg_count, addr, sg_len);
 
 		return ++bd_count;
fs/orangefs/orangefs-utils.c +1 -1
index aab6f1842963..50d38be6b0ad 100644
@@ -573,7 +573,7 @@ int orangefs_normalize_to_errno(__s32 error_code)
 	 * server.
 	 */
 	} else if (error_code > 0) {
-		gossip_err("orangefs: error status receieved.\n");
+		gossip_err("orangefs: error status received.\n");
 		gossip_err("orangefs: assuming error code is inverted.\n");
 		error_code = -error_code;
 	}
sound/soc/mediatek/mt2701/mt2701-afe-pcm.c +1 -1
index 8fda182f849b..7c07f7a435fd 100644
@@ -359,7 +359,7 @@ static int mt2701_btmrg_hw_params(struct snd_pcm_substream *substream,
 	stream_fs = params_rate(params);
 
 	if ((stream_fs != 8000) && (stream_fs != 16000)) {
-		dev_err(afe->dev, "%s() btmgr not supprt this stream_fs %d\n",
+		dev_err(afe->dev, "%s() btmgr doesn't support this stream_fs %d\n",
 			__func__, stream_fs);
 		return -EINVAL;
 	}
Signature · 1 line
2.14.1.802.g28996cec8069
Acked-by
#4 lore raw

Re: [PATCH/v2] [trivial] Fix typos and grammar in printk

Quoted 4 lines · Masanari Iida

This patch fixes some spelling typo and grammar error found in printk messages.

Signed-off-by Masanari Iida <[email protected]>
Acked-by Randy Dunlap <[email protected]>

Thanks.

Quoted 12 lines
---
 drivers/fmc/fmc-core.c                                | 2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c             | 2 +-
 drivers/gpu/drm/i915/intel_cdclk.c                    | 4 ++--
 drivers/net/ethernet/qlogic/qed/qed_int.c             | 2 +-
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +-
 drivers/scsi/aacraid/src.c                            | 4 ++--
 drivers/scsi/qedi/qedi_fw.c                           | 2 +-
 fs/orangefs/orangefs-utils.c                          | 2 +-
 sound/soc/mediatek/mt2701/mt2701-afe-pcm.c            | 2 +-
 9 files changed, 11 insertions(+), 11 deletions(-)
Signature · 1 line
~Randy