Skip to contentSkip to conversation

IA64 and drivers/acpi/bus.c

DISCUSSION Jean Delvare 2 participants 2 messages Sep 25, 2017 – Sep 29, 2017 ACPI

lore
Share & tools
lore

Jean Delvare

author
#0 lore raw

Hi all,

Long ago, a warning was silenced in drivers/acpi/bus.c on IA64 with this commit:

commit cce4f632db200aef147c59084437168174b23f11

Author: Lin Ming <[email protected]>
Date:   Wed May 12 09:26:48 2010 +0800

ACPI: fix early DSDT dmi check warnings on ia64

I don't think this fix was particularly elegant, but it did the job at the time. However you should be informed that an upcoming cleanup of the dmi subsystem will cause the warning to resurface:

https://marc.info/?l=linux-kernel&m=150113709717948&w=2

Instead of checking for dmi_initialized on individual dmi_system_id records, it will now be done once per dmi_check_system() call. It is much more efficient, but one side effect is that the warning will be displayed even if the array passed to dmi_check_system() is empty.

So the time has come to fix the problem cleanly, instead of just silencing the warning. This can be done in 2 ways:

1* Don't call dmi_check_system() at all if not on X86.

2* Initialize DMI earlier on IA64, so it is ready when ACPI support gets started.

I will let you guys decide what is the best option.

Thanks,

Signature · 2 lines
Jean Delvare
SUSE L3 Support
#1 lore raw

I wonder if we can just remove copy_dsdt quirk now.
As the old bug report was not fully root caused and the situation might be changed. Probably that is the simplest way for cleaning this up.

Thanks
Lv

Quoted 44 lines

From: [email protected] [mailto:[email protected]] On Behalf Of Jean Delvare
Subject: IA64 and drivers/acpi/bus.c

Hi all,

Long ago, a warning was silenced in drivers/acpi/bus.c on IA64 with this commit:

commit cce4f632db200aef147c59084437168174b23f11

Author: Lin Ming <[email protected]>
Date:   Wed May 12 09:26:48 2010 +0800

ACPI: fix early DSDT dmi check warnings on ia64

I don't think this fix was particularly elegant, but it did the job at the time. However you should be informed that an upcoming cleanup of the dmi subsystem will cause the warning to resurface:

https://marc.info/?l=linux-kernel&m=150113709717948&w=2

Instead of checking for dmi_initialized on individual dmi_system_id records, it will now be done once per dmi_check_system() call. It is much more efficient, but one side effect is that the warning will be displayed even if the array passed to dmi_check_system() is empty.

So the time has come to fix the problem cleanly, instead of just silencing the warning. This can be done in 2 ways:

1* Don't call dmi_check_system() at all if not on X86.

2* Initialize DMI earlier on IA64, so it is ready when ACPI support gets started.

I will let you guys decide what is the best option.

Thanks,
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html