Skip to contentSkip to conversation

iio:stm32-lp-timer and ep93xx: drop assign iio_info.driver_module and iio_trigger_ops.owner

PATCH In review Jonathan Cameron 3 participants 3 messages Sep 26, 2017

Subsystems (3)
lore
Share & tools
lore

Jonathan Cameron

author maintainer
#0 lore raw

PATCH 1/1 iio:stm32-lp-timer and ep93xx: drop assign iio_info.driver_module and iio_trigger_ops.owner

The equivalent of both of these are now done via macro magic when the relevant register calls are made. The actual structure elements have gone away.

---
Greg, please take this one directly for staging-next. This should fix the build failures Stephen is seeing with linux-next. Thanks!

Sorry about this one. I somehow completely failed to realise that the two drivers that went into mainline via other trees last cycle, were not yet in my local branch when I last tested this set.

Hindsight shows I should have done this in two goes with the change in pull request 1 and the actual removal a while later.

Sorry for the waste of time. Obviously this will cause bisection issues but hopefully not that many people will try bisect anything with these two obscure drivers.

 drivers/iio/adc/ep93xx_adc.c                | 1 -
 drivers/iio/counter/stm32-lptimer-cnt.c     | 1 -
 drivers/iio/trigger/stm32-lptimer-trigger.c | 1 -
 3 files changed, 3 deletions(-)
drivers/iio/adc/ep93xx_adc.c +0 -1
index a179ac476c6d..81c901507ad2 100644
@@ -150,7 +150,6 @@ static int ep93xx_read_raw(struct iio_dev *iiodev,
 }
 
 static const struct iio_info ep93xx_adc_info = {
-	.driver_module = THIS_MODULE,
 	.read_raw = ep93xx_read_raw,
 };
 
drivers/iio/counter/stm32-lptimer-cnt.c +0 -1
index 1c5909bb1605..81ae5f74216d 100644
@@ -178,7 +178,6 @@ static int stm32_lptim_read_raw(struct iio_dev *indio_dev,
 static const struct iio_info stm32_lptim_cnt_iio_info = {
 	.read_raw = stm32_lptim_read_raw,
 	.write_raw = stm32_lptim_write_raw,
-	.driver_module = THIS_MODULE,
 };
 
 static const char *const stm32_lptim_quadrature_modes[] = {
drivers/iio/trigger/stm32-lptimer-trigger.c +0 -1
index 241eae6a4306..de361d879929 100644
@@ -37,7 +37,6 @@ static int stm32_lptim_validate_device(struct iio_trigger *trig,
 }
 
 static const struct iio_trigger_ops stm32_lptim_trigger_ops = {
-	.owner = THIS_MODULE,
 	.validate_device = stm32_lptim_validate_device,
 };
 
Signature · 1 line
2.14.1
#1 lore raw
Quoted 6 lines · Jonathan Cameron

The equivalent of both of these are now done via macro magic when the relevant register calls are made. The actual structure elements have gone away.

You forgot a "Reported-by:" tag here, I'll go add it by hand :)

thanks,

greg k-h

#2 lore raw
Quoted 9 lines · Greg Kroah-Hartman
Quoted 6 lines · Jonathan Cameron

=20
The equivalent of both of these are now done via macro magic when the relevant register calls are made=2E The actual structure elements have gone away=2E
=20

You forgot a "Reported-by:" tag here, I'll go add it by hand :)

Doh! Sorry Stephen and thanks Greg=2E

Jonathan

Quoted 4 lines

thanks,

greg k-h

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E