drm/i915: Avoid using dev_priv->info.gen directly.
Subsystems (2)
Rodrigo Vivi
maintainerPATCH 1/1 drm/i915: Avoid using dev_priv->info.gen directly.
Let's stop this usage before it spreads so much.
1. This check is not part of usual searches happening when adding new platform.
2. There is already a duplication here with INTEL_INFO(dev_priv)->gen and INTEL_GEN(dev_priv).
So let's please avoid yet another way.
--- drivers/gpu/drm/i915/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_display.c +3 -3
@@ -9310,11 +9310,11 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc, pipe_config->gamma_mode =I915_READ (GAMMA_MODE (crtc->pipe)) &GAMMA_MODE_MODE_MASK ; -if (IS_BROADWELL (dev_priv) || dev_priv->info.gen >=9 ) { +if (IS_BROADWELL (dev_priv) ||INTEL_GEN (dev_priv) >=9 ) {u32 tmp =I915_READ (PIPEMISC (crtc->pipe));bool clrspace_yuv = tmp &PIPEMISC_OUTPUT_COLORSPACE_YUV ; -if (IS_GEMINILAKE (dev_priv) || dev_priv->info.gen >=10 ) { +if (IS_GEMINILAKE (dev_priv) ||INTEL_GEN (dev_priv) >=10 ) {bool blend_mode_420 = tmp &PIPEMISC_YUV420_MODE_FULL_BLEND ;
@@ -14217,7 +14217,7 @@ void intel_init_display_hooks(struct drm_i915_private *dev_priv) dev_priv->display.fdi_link_train = hsw_fdi_link_train; } -if (dev_priv->info.gen >=9 ) +if (INTEL_GEN (dev_priv) >=9 ) dev_priv->display.update_crtcs = skl_update_crtcs;else dev_priv->display.update_crtcs = intel_update_crtcs;
Signature · 6 lines
2.13.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Em Ter, 2017-09-26 às 14:13 -0700, Rodrigo Vivi escreveu:
Quoted 7 lines
Let's stop this usage before it spreads so much.
1. This check is not part of usual searches happening when adding new platform.
2. There is already a duplication here with INTEL_INFO(dev_priv)->gen andINTEL_GEN(dev_priv).
Quoted 5 lines
So let's please avoid yet another way.
Fixes b22ca995ba1c ("drm/i915: prepare pipe for YCBCR420 output")Fixes 27082493e9c6 ("drm/i915/skl: Update DDB values atomically withwms/plane attrs")
Not sure if the Fixes tags are appropriate since this is not a bug fix.
Quoted 50 lines
Cc Lyude <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Daniel Vetter <[email protected]>Cc Radhakrishna Sripada <[email protected]>Cc Hans de Goede <[email protected]>Cc Matt Roper <[email protected]>Cc Maarten Lankhorst <[email protected]>Cc Paulo Zanoni <[email protected]>Cc Ville Syrjala <[email protected]>Cc Imre Deak <[email protected]>Cc Shashank Sharma <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>---
drivers/gpu/drm/i915/intel_display.c | 6 +++---1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/intel_display.c +0
-0@@ -9310,11 +9310,11 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc,
pipe_config->gamma_mode= I915_READ(GAMMA_MODE(crtc->pipe)) &GAMMA_MODE_MODE_MASK;drivers/gpu/drm/i915/intel_display.c +1
-1-if (IS_BROADWELL (dev_priv) || dev_priv->info.gen >=9 ) { +if (IS_BROADWELL (dev_priv) ||INTEL_GEN (dev_priv) >=9 ) {u32 tmp = I915_READ(PIPEMISC(crtc->pipe)); bool
clrspace_yuv= tmp &PIPEMISC_OUTPUT_COLORSPACE_YUV;drivers/gpu/drm/i915/intel_display.c +0
-1- if (IS_GEMINILAKE(dev_priv) || dev_priv->info.gen >=10) {
drivers/gpu/drm/i915/intel_display.c +1
-0+ if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv)Quoted 1 line
= 10) {
bool
blend_mode_420= tmp &PIPEMISC_YUV420_MODE_FULL_BLEND;drivers/gpu/drm/i915/intel_display.c +0
-0@@ -14217,7 +14217,7 @@ void intel_init_display_hooks(struct drm_i915_private *dev_priv)
dev_priv->display.fdi_link_train=hsw_fdi_link_train;
}drivers/gpu/drm/i915/intel_display.c +1
-1-if (dev_priv->info.gen >=9 ) +if (INTEL_GEN (dev_priv) >=9 )
Quoted 3 lines
dev_priv->display.update_crtcs=skl_update_crtcs; else
dev_priv->display.update_crtcs=intel_update_crtcs;
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi
maintainerQuoted 8 lines · Paulo Zanoni
Em Ter, 2017-09-26 às 14:13 -0700, Rodrigo Vivi escreveu:
Quoted 7 lines
Let's stop this usage before it spreads so much.
1. This check is not part of usual searches happening when adding new platform.
2. There is already a duplication here with INTEL_INFO(dev_priv)->gen andINTEL_GEN(dev_priv).
Quoted 7 lines
Quoted 5 lines
So let's please avoid yet another way.
Fixes b22ca995ba1c ("drm/i915: prepare pipe for YCBCR420 output")Fixes 27082493e9c6 ("drm/i915/skl: Update DDB values atomically withwms/plane attrs")
Not sure if the Fixes tags are appropriate since this is not a bug fix.
I wondered that... but since "dim fixes" provided me that tag along with the list of people I should cc I decided to include here. I thought it wouldn't hurt and also maybe good to propagate that to everywhere possible so we don't recieve more code based on that usage.
But I won't merge today to give time to get Jani's view on that.
Quoted 41 lines
Reviewed-by Paulo Zanoni <[email protected]>Quoted 38 lines
Cc Lyude <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Daniel Vetter <[email protected]>Cc Radhakrishna Sripada <[email protected]>Cc Hans de Goede <[email protected]>Cc Matt Roper <[email protected]>Cc Maarten Lankhorst <[email protected]>Cc Paulo Zanoni <[email protected]>Cc Ville Syrjala <[email protected]>Cc Imre Deak <[email protected]>Cc Shashank Sharma <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>---
drivers/gpu/drm/i915/intel_display.c | 6 +++---1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/intel_display.c +0
-0@@ -9310,11 +9310,11 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc,
pipe_config->gamma_mode= I915_READ(GAMMA_MODE(crtc->pipe)) &GAMMA_MODE_MODE_MASK;drivers/gpu/drm/i915/intel_display.c +1
-1-if (IS_BROADWELL (dev_priv) || dev_priv->info.gen >=9 ) { +if (IS_BROADWELL (dev_priv) ||INTEL_GEN (dev_priv) >=9 ) {u32 tmp = I915_READ(PIPEMISC(crtc->pipe)); bool
clrspace_yuv= tmp &PIPEMISC_OUTPUT_COLORSPACE_YUV;drivers/gpu/drm/i915/intel_display.c +0
-1- if (IS_GEMINILAKE(dev_priv) || dev_priv->info.gen >=10) {
drivers/gpu/drm/i915/intel_display.c +1
-0+ if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv)Quoted 1 line
= 10) {
Quoted 15 lines
Quoted 12 lines
bool
blend_mode_420= tmp &PIPEMISC_YUV420_MODE_FULL_BLEND;drivers/gpu/drm/i915/intel_display.c +0
-0@@ -14217,7 +14217,7 @@ void intel_init_display_hooks(struct drm_i915_private *dev_priv)
dev_priv->display.fdi_link_train=hsw_fdi_link_train;
}drivers/gpu/drm/i915/intel_display.c +1
-1-if (dev_priv->info.gen >=9 ) +if (INTEL_GEN (dev_priv) >=9 )Quoted 3 lines
dev_priv->display.update_crtcs=skl_update_crtcs; else
dev_priv->display.update_crtcs=intel_update_crtcs;
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerQuoted 15 lines · Rodrigo Vivi
Quoted 14 lines · Paulo Zanoni
Em Ter, 2017-09-26 às 14:13 -0700, Rodrigo Vivi escreveu:
Quoted 12 lines
Let's stop this usage before it spreads so much.
1. This check is not part of usual searches happening when adding new platform.
2. There is already a duplication here with INTEL_INFO(dev_priv)->gen andINTEL_GEN(dev_priv).So let's please avoid yet another way.
Fixes b22ca995ba1c ("drm/i915: prepare pipe for YCBCR420 output")Fixes 27082493e9c6 ("drm/i915/skl: Update DDB values atomically withwms/plane attrs")
Quoted 8 lines
Quoted 1 line
Not sure if the Fixes tags are appropriate since this is not a bug fix.
I wondered that... but since "dim fixes" provided me that tag along with the list of people I should cc I decided to include here. I thought it wouldn't hurt and also maybe good to propagate that to everywhere possible so we don't recieve more code based on that usage.
But I won't merge today to give time to get Jani's view on that.
Please only use Fixes: for functional fixes that need to be backported. Like, nobody's going to be happier running a kernel they know uses INTEL_GEN() consistently.
BR,
Jani.
Quoted 57 lines
Quoted 57 lines
Reviewed-by Paulo Zanoni <[email protected]>Quoted 53 lines
Cc Lyude <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Daniel Vetter <[email protected]>Cc Radhakrishna Sripada <[email protected]>Cc Hans de Goede <[email protected]>Cc Matt Roper <[email protected]>Cc Maarten Lankhorst <[email protected]>Cc Paulo Zanoni <[email protected]>Cc Ville Syrjala <[email protected]>Cc Imre Deak <[email protected]>Cc Shashank Sharma <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>---
drivers/gpu/drm/i915/intel_display.c | 6 +++---1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/intel_display.c +0
-0@@ -9310,11 +9310,11 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc,
pipe_config->gamma_mode= I915_READ(GAMMA_MODE(crtc->pipe)) &GAMMA_MODE_MODE_MASK;drivers/gpu/drm/i915/intel_display.c +1
-1-if (IS_BROADWELL (dev_priv) || dev_priv->info.gen >=9 ) { +if (IS_BROADWELL (dev_priv) ||INTEL_GEN (dev_priv) >=9 ) {u32 tmp = I915_READ(PIPEMISC(crtc->pipe)); bool
clrspace_yuv= tmp &PIPEMISC_OUTPUT_COLORSPACE_YUV;drivers/gpu/drm/i915/intel_display.c +0
-1- if (IS_GEMINILAKE(dev_priv) || dev_priv->info.gen >=10) {
drivers/gpu/drm/i915/intel_display.c +1
-0+ if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv)Quoted 1 line
= 10) {
bool
blend_mode_420= tmp &PIPEMISC_YUV420_MODE_FULL_BLEND;drivers/gpu/drm/i915/intel_display.c +0
-0@@ -14217,7 +14217,7 @@ void intel_init_display_hooks(struct drm_i915_private *dev_priv)
dev_priv->display.fdi_link_train=hsw_fdi_link_train;
}drivers/gpu/drm/i915/intel_display.c +1
-1-if (dev_priv->info.gen >=9 ) +if (INTEL_GEN (dev_priv) >=9 )
dev_priv->display.update_crtcs=skl_update_crtcs; else
dev_priv->display.update_crtcs=intel_update_crtcs;
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 23 lines · Jani Nikula
Quoted 22 lines · Rodrigo Vivi
Quoted 8 lines · Paulo Zanoni
Em Ter, 2017-09-26 às 14:13 -0700, Rodrigo Vivi escreveu:
Quoted 7 lines
Let's stop this usage before it spreads so much.
1. This check is not part of usual searches happening when adding new platform.
2. There is already a duplication here with INTEL_INFO(dev_priv)->gen andINTEL_GEN(dev_priv).Quoted 7 lines
Quoted 5 lines
So let's please avoid yet another way.
Fixes b22ca995ba1c ("drm/i915: prepare pipe for YCBCR420 output")Fixes 27082493e9c6 ("drm/i915/skl: Update DDB values atomically withwms/plane attrs")
Not sure if the Fixes tags are appropriate since this is not a bug fix.
I wondered that... but since "dim fixes" provided me that tag along with the list of people I should cc I decided to include here. I thought it wouldn't hurt and also maybe good to propagate that to everywhere possible so we don't recieve more code based on that usage.
Quoted 5 lines
Quoted 1 line
But I won't merge today to give time to get Jani's view on that.
Please only use Fixes: for functional fixes that need to be backported. Like, nobody's going to be happier running a kernel they know uses
INTEL_GEN()consistently.
Makes sense.
Merged to dinq without the "Fixes:" tags.
Thanks for all comments and reviews.
Quoted 69 lines
BR,
Jani.Quoted 52 lines
Quoted 52 lines
Reviewed-by Paulo Zanoni <[email protected]>Quoted 48 lines
Cc Lyude <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Daniel Vetter <[email protected]>Cc Radhakrishna Sripada <[email protected]>Cc Hans de Goede <[email protected]>Cc Matt Roper <[email protected]>Cc Maarten Lankhorst <[email protected]>Cc Paulo Zanoni <[email protected]>Cc Ville Syrjala <[email protected]>Cc Imre Deak <[email protected]>Cc Shashank Sharma <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/intel_display.c +1
-2@@ -9310,11 +9310,11 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc, pipe_config->gamma_mode =I915_READ (GAMMA_MODE (crtc->pipe)) &GAMMA_MODE_MODE_MASK ; - if (IS_BROADWELL(dev_priv) || dev_priv->info.gen >= 9) { +if (IS_BROADWELL (dev_priv) ||INTEL_GEN (dev_priv) >=9 ) {u32 tmp =I915_READ (PIPEMISC (crtc->pipe));bool clrspace_yuv = tmp &PIPEMISC_OUTPUT_COLORSPACE_YUV ; - if (IS_GEMINILAKE(dev_priv) || dev_priv->info.gen >=10) {
+ if (IS_GEMINILAKE(dev_priv)||INTEL_GEN(dev_priv)Quoted 1 line
= 10) {
bool blend_mode_420 = tmp & PIPEMISC_YUV420_MODE_F
ULL_BLEND;drivers/gpu/drm/i915/intel_display.c +0
-0@@ -14217,7 +14217,7 @@ void intel_init_display_hooks(struct drm_i915_private *dev_priv) dev_priv->display.fdi_link_train = hsw_fdi_link_train; }Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
drivers/gpu/drm/i915/intel_display.c +1
-1-if (dev_priv->info.gen >=9 ) +if (INTEL_GEN (dev_priv) >=9 ) dev_priv->display.update_crtcs = skl_update_crtcs;else dev_priv->display.update_crtcs = intel_update_crtcs;--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Joonas Lahtinen
maintainerQuoted 27 lines · Rodrigo Vivi
Quoted 25 lines · Jani Nikula
Quoted 23 lines · Rodrigo Vivi
Quoted 8 lines · Paulo Zanoni
Em Ter, 2017-09-26 às 14:13 -0700, Rodrigo Vivi escreveu:
Quoted 7 lines
Let's stop this usage before it spreads so much.
1. This check is not part of usual searches happening when adding new platform.
2. There is already a duplication here with INTEL_INFO(dev_priv)->gen andINTEL_GEN(dev_priv).Quoted 7 lines
Quoted 5 lines
So let's please avoid yet another way.
Fixes b22ca995ba1c ("drm/i915: prepare pipe for YCBCR420 output")Fixes 27082493e9c6 ("drm/i915/skl: Update DDB values atomically withwms/plane attrs")
Not sure if the Fixes tags are appropriate since this is not a bug fix.
I wondered that... but since "dim fixes" provided me that tag along with the list of people I should cc I decided to include here. I thought it wouldn't hurt and also maybe good to propagate that to everywhere possible so we don't recieve more code based on that usage.
But I won't merge today to give time to get Jani's view on that.
Quoted 7 lines
Quoted 3 lines
Please only use Fixes: for functional fixes that need to be backported. Like, nobody's going to be happier running a kernel they know uses
INTEL_GEN()consistently.Makes sense.
Merged to dinq without the "Fixes:" tags.
Thanks for all comments and reviews.
We discussed this with Chris too, I ended up suggesting there could be something along; "Backport: none" or "Backport: v4.0+", instead of the horrible #v4.0 that is causing pain every now and then, by getting mixed to the To: fields in a wrong way.
Any thoughts on that?
Fixes: is an interesting metric in other sense too, or then just decide to use X-Fixes: when we don't want it to end up backported.
Regards, Joonas
Signature · 7 lines
Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerQuoted 36 lines · Joonas Lahtinen
Quoted 27 lines · Rodrigo Vivi
Quoted 25 lines · Jani Nikula
Quoted 23 lines · Rodrigo Vivi
Quoted 8 lines · Paulo Zanoni
Em Ter, 2017-09-26 às 14:13 -0700, Rodrigo Vivi escreveu:
Quoted 7 lines
Let's stop this usage before it spreads so much.
1. This check is not part of usual searches happening when adding new platform.
2. There is already a duplication here with INTEL_INFO(dev_priv)->gen andINTEL_GEN(dev_priv).Quoted 7 lines
Quoted 5 lines
So let's please avoid yet another way.
Fixes b22ca995ba1c ("drm/i915: prepare pipe for YCBCR420 output")Fixes 27082493e9c6 ("drm/i915/skl: Update DDB values atomically withwms/plane attrs")
Not sure if the Fixes tags are appropriate since this is not a bug fix.
I wondered that... but since "dim fixes" provided me that tag along with the list of people I should cc I decided to include here. I thought it wouldn't hurt and also maybe good to propagate that to everywhere possible so we don't recieve more code based on that usage.
But I won't merge today to give time to get Jani's view on that.
Quoted 7 lines
Quoted 3 lines
Please only use Fixes: for functional fixes that need to be backported. Like, nobody's going to be happier running a kernel they know uses
INTEL_GEN()consistently.Makes sense.
Merged to dinq without the "Fixes:" tags.
Thanks for all comments and reviews.
Quoted 6 lines
We discussed this with Chris too, I ended up suggesting there could be something along; "Backport: none" or "Backport: v4.0+", instead of the horrible #v4.0 that is causing pain every now and then, by getting mixed to the To: fields in a wrong way.
Any thoughts on that?
The "# v4.0" notation is described in stable-kernel-rules.rst, and if there are problems with it, they will get fixed. Git screwed it up, and AFAIK it has since been fixed. I think stick with what the stable team wants.
Quoted 2 lines
Fixes: is an interesting metric in other sense too, or then just decide to use X-Fixes: when we don't want it to end up backported.
IMO Fixes: should only be used for actual functional fixes, not cosmetic stuff. We don't need to track cosmetic fixes, nobody wants to backport them anywhere. Our tooling heavily relies on Fixes: to select fixes backports, and we'll just look silly sending "comment typo fix" style patches Linus' way at, say, -rc6 when stuff is supposed to abide by stable-kernel-rules.rst.
BR,
Jani.
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 9 lines · Rodrigo Vivi
Let's stop this usage before it spreads so much.
1. This check is not part of usual searches happening when adding new platform.
2. There is already a duplication here with INTEL_INFO(dev_priv)->gen andINTEL_GEN(dev_priv).So let's please avoid yet another way.
Quoted 15 lines
Fixes b22ca995ba1c ("drm/i915: prepare pipe for YCBCR420 output")Fixes 27082493e9c6 ("drm/i915/skl: Update DDB values atomically with wms/plane attrs")Cc Lyude <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Daniel Vetter <[email protected]>Cc Radhakrishna Sripada <[email protected]>Cc Hans de Goede <[email protected]>Cc Matt Roper <[email protected]>Cc Maarten Lankhorst <[email protected]>Cc Paulo Zanoni <[email protected]>Cc Ville Syrjala <[email protected]>Cc Imre Deak <[email protected]>Cc Shashank Sharma <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>
Maybe we could make dim use coccinelle to flag these kinds of patterns in the future to prevent them from sneaking back into the code?
Matt
Quoted 34 lines
--- drivers/gpu/drm/i915/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/intel_display.c +3
-3@@ -9310,11 +9310,11 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc, pipe_config->gamma_mode =I915_READ (GAMMA_MODE (crtc->pipe)) &GAMMA_MODE_MODE_MASK ; -if (IS_BROADWELL (dev_priv) || dev_priv->info.gen >=9 ) { +if (IS_BROADWELL (dev_priv) ||INTEL_GEN (dev_priv) >=9 ) {u32 tmp =I915_READ (PIPEMISC (crtc->pipe));bool clrspace_yuv = tmp &PIPEMISC_OUTPUT_COLORSPACE_YUV ; -if (IS_GEMINILAKE (dev_priv) || dev_priv->info.gen >=10 ) { +if (IS_GEMINILAKE (dev_priv) ||INTEL_GEN (dev_priv) >=10 ) {bool blend_mode_420 = tmp &PIPEMISC_YUV420_MODE_FULL_BLEND ;@@ -14217,7 +14217,7 @@ void intel_init_display_hooks(struct drm_i915_private *dev_priv) dev_priv->display.fdi_link_train = hsw_fdi_link_train; } -if (dev_priv->info.gen >=9 ) +if (INTEL_GEN (dev_priv) >=9 ) dev_priv->display.update_crtcs = skl_update_crtcs;else dev_priv->display.update_crtcs = intel_update_crtcs;Signature · 1 line
2.13.5
Signature · 9 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Avoid using dev_priv->info.gen directly.
In reply to Rodrigo Vivi== Series Details ==
== Series Details ==
Series: drm/i915: Avoid using dev_priv->info.gen directly.
URL : https://patchwork.freedesktop.org/series/30926/
State : success
== Summary ==
Series 30926v1 drm/i915: Avoid using dev_priv->info.gen directly.
https://patchwork.freedesktop.org/api/1.0/series/30926/revisions/1/mbox/
Test chamelium:
Subgroup dp-edid-read:
pass -> FAIL (fi-kbl-7500u) fdo#102672
Subgroup dp-crc-fast:
fail -> PASS (fi-kbl-7500u) fdo#102514
Test pm_rpm:
Subgroup basic-rte:
dmesg-warn -> PASS (fi-cfl-s) fdo#102294
Test drv_module_reload:
Subgroup basic-no-display:
pass -> DMESG-WARN (fi-glk-1) fdo#102777 +1fdo#102672 https://bugs.freedesktop.org/show_bug.cgi?id=102672
fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#102294 https://bugs.freedesktop.org/show_bug.cgi?id=102294
fdo#102777 https://bugs.freedesktop.org/show_bug.cgi?id=102777
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:440s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:466s fi-blb-e6850 total:289 pass:224 dwarn:1 dfail:0 fail:0 skip:64 time:422s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:517s fi-bwr-2160 total:289 pass:184 dwarn:0 dfail:0 fail:0 skip:105 time:278s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:495s fi-byt-j1900 total:289 pass:254 dwarn:1 dfail:0 fail:0 skip:34 time:496s fi-byt-n2820 total:289 pass:250 dwarn:1 dfail:0 fail:0 skip:38 time:497s fi-cfl-s total:289 pass:223 dwarn:34 dfail:0 fail:0 skip:32 time:539s fi-cnl-y total:289 pass:258 dwarn:0 dfail:0 fail:4 skip:27 time:639s fi-elk-e7500 total:289 pass:230 dwarn:0 dfail:0 fail:0 skip:59 time:418s fi-glk-1 total:289 pass:259 dwarn:1 dfail:0 fail:0 skip:29 time:564s fi-hsw-4770 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:423s fi-hsw-4770r total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:405s fi-ilk-650 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:433s fi-ivb-3520m total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:491s fi-ivb-3770 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:460s fi-kbl-7500u total:289 pass:263 dwarn:1 dfail:0 fail:1 skip:24 time:469s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:577s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:589s fi-pnv-d510 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:549s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:454s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:748s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:487s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:475s fi-snb-2520m total:289 pass:251 dwarn:0 dfail:0 fail:0 skip:38 time:575s fi-snb-2600 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:414s
13d4fadfbe072f2952fb0fda72f2176434b609f5 drm-tip: 2017y-09m-26d-20h-03m-18s UTC integration manifest a457f6bb37eb drm/i915: Avoid using dev_priv->info.gen directly.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5826/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915: Avoid using dev_priv->info.gen directly.
In reply to Rodrigo Vivi== Series Details ==
== Series Details ==
Series: drm/i915: Avoid using dev_priv->info.gen directly.
URL : https://patchwork.freedesktop.org/series/30926/
State : success
== Summary ==
Test kms_setmode:
Subgroup basic:
fail -> PASS (shard-hsw) fdo#99912
Test perf:
Subgroup polling:
fail -> PASS (shard-hsw) fdo#102252fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
shard-hsw total:2429 pass:1336 dwarn:1 dfail:0 fail:9 skip:1083 time:9949s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5826/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx