Skip to contentSkip to conversation

qf: Handle unused patches on sub-directories.

PATCH In review Rodrigo Vivi 2 participants 2 messages Sep 26, 2017 – Sep 27, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qf: Handle unused patches on sub-directories.

Most of internal patches are nowadays organized in quilt subdirectories, but qf was never updated to check for unused patches there.

---
 qf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
qf +2 -2
index 0c9d28edb3f0..cafbdc44e1bc 100755
@@ -300,7 +300,7 @@ function qf_clean_patches
 	cd_toplevel
 	repo_check 0
 
-	for patch in patches/*.patch ; do
+	for patch in patches/{*/,/}*.patch ; do
 		if grep "^${patch##patches/}$" patches/series &> /dev/null ; then
 			continue
 		fi
@@ -486,7 +486,7 @@ function qf_list_unused_patches
 	cd_toplevel
 	repo_check 1
 
-	for patch in patches/*.patch ; do
+	for patch in patches/{*/,/}*.patch ; do
 		if ! grep "^${patch#patches/}$" patches/series > /dev/null ; then
 			if [[ "$1" != --purge ]] ; then
 				echo $patch
Signature · 6 lines
2.13.5

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 6 lines · Rodrigo Vivi

Most of internal patches are nowadays organized in quilt subdirectories, but qf was never updated to check for unused patches there.

lgtm, Ack. Maybe go with ** in case we start nesting them deeper. -Daniel

Quoted 33 lines
---
 qf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
qf +2 -2
index 0c9d28edb3f0..cafbdc44e1bc 100755
@@ -300,7 +300,7 @@ function qf_clean_patches
 	cd_toplevel
 	repo_check 0
 
-	for patch in patches/*.patch ; do
+	for patch in patches/{*/,/}*.patch ; do
 		if grep "^${patch##patches/}$" patches/series &> /dev/null ; then
 			continue
 		fi
@@ -486,7 +486,7 @@ function qf_list_unused_patches
 	cd_toplevel
 	repo_check 1
 
-	for patch in patches/*.patch ; do
+	for patch in patches/{*/,/}*.patch ; do
 		if ! grep "^${patch#patches/}$" patches/series > /dev/null ; then
 			if [[ "$1" != --purge ]] ; then
 				echo $patch
Signature · 6 lines
2.13.5

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx