amdgpu/dc: add static to construct function
Subsystems (3)
PATCH 1/1 amdgpu/dc: add static to construct function
From: Dave Airlie <[email protected]>
There was a global construct symbol in the module symbols, kill it.
Signed-off-by Dave Airlie <[email protected]>
--- drivers/gpu/drm/amd/display/dc/irq/dce110/irq_service_dce110.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/irq/dce110/irq_service_dce110.c +1 -1
@@ -406,7 +406,7 @@ static const struct irq_service_funcs irq_service_funcs_dce110 = { .to_dal_irq_source = to_dal_irq_source_dce110 }; -bool construct ( +static bool construct (struct irq_service *irq_service,struct irq_service_init_data *init_data) {
Signature · 6 lines
2.9.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Harry Wentland
Reviewed-byQuoted 4 lines · Dave Airlie
From: Dave Airlie <[email protected]>
There was a global construct symbol in the module symbols, kill it.
Good catch. I should really watch out for global namespace pollution which is really not cool in the kernel tree.
Quoted 1 line
Signed-off-by Dave Airlie <[email protected]>
Reviewed-by Harry Wentland <[email protected]>
Harry
Quoted 10 lines
--- drivers/gpu/drm/amd/display/dc/irq/dce110/irq_service_dce110.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/display/dc/irq/dce110/irq_service_dce110.c +0
-0
drivers/gpu/drm/amd/display/dc/irq/dce110/irq_service_dce110.c static const struct irq_service_funcs irq_service_funcs_dce110 = { · line 412
Quoted 8 lines
drivers/gpu/drm/amd/display/dc/irq/dce110/irq_service_dce110.c +1
-1@@ -406,7 +406,7 @@ static const struct irq_service_funcs irq_service_funcs_dce110 = { .to_dal_irq_source = to_dal_irq_source_dce110 }; -bool construct ( +static bool construct (struct irq_service *irq_service,struct irq_service_init_data *init_data) {
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx