Skip to contentSkip to conversation

staging: vc04_services: Remove duplicate extern variable

PATCH Superseded Mihaela Muraru 2 participants 3 messages Sep 28, 2017

Subsystems (2)
Staging Broadcom BCM2711/BCM2835 Arm architecture

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Mihaela Muraru

author
#0 lore raw

PATCH 1/1 staging: vc04_services: Remove duplicate extern variable

This patch removes the extern vchiq_arm_log_level variable from vchiq_2835_arm.c.The variable is also declared in vchiq_arm.h header.

Issue found by checpatch.pl

Signed-off-by Mihaela Muraru <[email protected]>
---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c +0 -1
index 0159ca4..12b0e0d 100644
@@ -84,7 +84,6 @@ static char *g_free_fragments;
 static struct semaphore g_free_fragments_sema;
 static struct device *g_dev;
 
-extern int vchiq_arm_log_level;
 
 static DEFINE_SEMAPHORE(g_free_fragments_mutex);
Signature · 1 line
2.7.4
#1 lore raw
Quoted 4 lines · Mihaela Muraru

This patch removes the extern vchiq_arm_log_level variable from vchiq_2835_arm.c.The variable is also declared in vchiq_arm.h header.

Issue found by checpatch.pl

checpatch.pl -> checkpatch.pl

Quoted 11 lines
Signed-off-by Mihaela Muraru <[email protected]>
---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c +0 -0
index 0159ca4..12b0e0d 100644

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c static char *g_free_fragments; · line 87

Quoted 5 lines
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c +0 -1
@@ -84,7 +84,6 @@ static char *g_free_fragments;
 static struct semaphore g_free_fragments_sema;
 static struct device *g_dev;
 
-extern int vchiq_arm_log_level;

You're going to end up with two blank lines here.

julia

Quoted 12 lines
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c +0 -1
 static DEFINE_SEMAPHORE(g_free_fragments_mutex);
 
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170928093917.GA5023%40ubuntu.
For more options, visit https://groups.google.com/d/optout.

author
#2 lore raw
Quoted 25 lines · Julia Lawall
Quoted 4 lines · Mihaela Muraru

This patch removes the extern vchiq_arm_log_level variable from vchiq_2835_arm.c.The variable is also declared in vchiq_arm.h header.

Issue found by checpatch.pl

checpatch.pl -> checkpatch.pl

Quoted 14 lines
Signed-off-by Mihaela Muraru <[email protected]>
---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c +0 -0
index 0159ca4..12b0e0d 100644
@@ -84,7 +84,6 @@ static char *g_free_fragments;
 static struct semaphore g_free_fragments_sema;
 static struct device *g_dev;
Quoted 6 lines

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c static char *g_free_fragments; · line 87

Quoted 2 lines
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c +0 -1
-extern int vchiq_arm_log_level;

You're going to end up with two blank lines here.

julia

Thank you,

I will send patch v2 with these changes

Mihaela

Quoted 12 lines
Quoted 12 lines
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c +0 -1
 static DEFINE_SEMAPHORE(g_free_fragments_mutex);
 
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170928093917.GA5023%40ubuntu.
For more options, visit https://groups.google.com/d/optout.