Skip to contentSkip to conversation

staging: vc04_services: Remove duplicate extern variable

PATCH Superseded Mihaela Muraru 2 participants 3 messages Sep 28, 2017

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: vc04_services: Remove duplicate extern variable

This patch removes the extern vchiq_arm_log_level variable from vchiq_2835_arm.c.The variable is also declared in vchiq_arm.h header.

Issue found by checkpatch.pl

---
Changes in v2:
- remove unnecessary blank line

---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c +0 -1
index ee00f51..a96bae0 100644
@@ -84,7 +84,6 @@ static char *g_free_fragments;
 static struct semaphore g_free_fragments_sema;
 static struct device *g_dev;
 
-
 static DEFINE_SEMAPHORE(g_free_fragments_mutex);
 
 static irqreturn_t
Signature · 1 line
2.7.4
#1 lore raw
Quoted 2 lines · Mihaela Muraru

This patch removes the extern vchiq_arm_log_level variable from vchiq_2835_arm.c.The variable is also declared in vchiq_arm.h header.

This looks like the same code as the other patch I commented on, but again the change doesn't match the log message.

julia

Quoted 34 lines

Issue found by checkpatch.pl

---
Changes in v2:
- remove unnecessary blank line

---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c +0 -2
index ee00f51..a96bae0 100644
@@ -84,7 +84,6 @@ static char *g_free_fragments;
 static struct semaphore g_free_fragments_sema;
 static struct device *g_dev;
 
-
 static DEFINE_SEMAPHORE(g_free_fragments_mutex);
 
 static irqreturn_t
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170928113505.GA12271%40ubuntu.
For more options, visit https://groups.google.com/d/optout.

#2 lore raw
Quoted 11 lines · Julia Lawall
Quoted 2 lines · Mihaela Muraru

This patch removes the extern vchiq_arm_log_level variable from vchiq_2835_arm.c.The variable is also declared in vchiq_arm.h header.

This looks like the same code as the other patch I commented on, but again the change doesn't match the log message.

julia

I think I sent the wrong patch, sorry

Mihaela

Quoted 34 lines
Quoted 34 lines

Issue found by checkpatch.pl

---
Changes in v2:
- remove unnecessary blank line

---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c +0 -2
index ee00f51..a96bae0 100644
@@ -84,7 +84,6 @@ static char *g_free_fragments;
 static struct semaphore g_free_fragments_sema;
 static struct device *g_dev;
 
-
 static DEFINE_SEMAPHORE(g_free_fragments_mutex);
 
 static irqreturn_t
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170928113505.GA12271%40ubuntu.
For more options, visit https://groups.google.com/d/optout.