Skip to contentSkip to conversation

cros_ec: sysfs: Fix memory leak in show/store_kb_wake_angle()

PATCH New Jeffy Chen 1 participant 1 message Sep 29, 2017

Subsystems (2)
lore
Share & tools
lore

Jeffy Chen

author
#0 lore raw

PATCH 1/1 cros_ec: sysfs: Fix memory leak in show/store_kb_wake_angle()

Add missing kfree of allocated cros_ec_command.

Fixes ff00af859354 ("platform/chrome: cros_ec: Add sysfs entry to set keyboard wake lid angle")

---

 drivers/platform/chrome/cros_ec_sysfs.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)
drivers/platform/chrome/cros_ec_sysfs.c +10 -5
index 0fd88eb03d39..0f821dd0d5b1 100644
@@ -286,10 +286,12 @@ static ssize_t show_kb_wake_angle(struct device *dev,
 	msg->insize = sizeof(*resp);
 	ret = cros_ec_cmd_xfer_status(ec->ec_dev, msg);
 	if (ret < 0)
-		return ret;
+		goto exit;
 	resp = (struct ec_response_motion_sense *)msg->data;
-	return scnprintf(buf, PAGE_SIZE, "%d\n",
-			 resp->kb_wake_angle.ret);
+	ret = scnprintf(buf, PAGE_SIZE, "%d\n", resp->kb_wake_angle.ret);
+exit:
+	kfree(msg);
+	return ret;
 }
 
 static ssize_t store_kb_wake_angle(struct device *dev,
@@ -320,8 +322,11 @@ static ssize_t store_kb_wake_angle(struct device *dev,
 	msg->insize = sizeof(struct ec_response_motion_sense);
 	ret = cros_ec_cmd_xfer_status(ec->ec_dev, msg);
 	if (ret < 0)
-		return ret;
-	return count;
+		goto exit;
+	ret = count;
+exit:
+	kfree(msg);
+	return ret;
 }
 
 /* Module initialization */
Signature · 1 line
2.11.0