Skip to contentSkip to conversation

drm/omap: displays: panel-dpi: add backlight dependency

PATCH In review Arnd Bergmann 2 participants 2 messages Oct 5, 2017 – Oct 12, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/omap: displays: panel-dpi: add backlight dependency

The new backlight code causes a link failure when backlight support itself is disabled:

drivers/gpu/drm/omapdrm/displays/panel-dpi.o: In function `panel_dpi_probe_of':
panel-dpi.c:(.text+0x35c): undefined reference to `of_find_backlight_by_node'

This adds a Kconfig dependency like we have for the other OMAP display targets.

Fixes 39135a305a0f ("drm/omap: displays: panel-dpi: Support for handling backlight devices")
---
 drivers/gpu/drm/omapdrm/displays/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/omapdrm/displays/Kconfig +1 -0
index c226da145fb3..a349cb61961e 100644
@@ -35,6 +35,7 @@ config DRM_OMAP_CONNECTOR_ANALOG_TV
 
 config DRM_OMAP_PANEL_DPI
 	tristate "Generic DPI panel"
+	depends on BACKLIGHT_CLASS_DEVICE
 	help
 	  Driver for generic DPI panels.
 
Signature · 1 line
2.9.0
#1 lore raw


Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Quoted 20 lines · Arnd Bergmann

The new backlight code causes a link failure when backlight support itself is disabled:

drivers/gpu/drm/omapdrm/displays/panel-dpi.o: In function `panel_dpi_probe_of':
panel-dpi.c:(.text+0x35c): undefined reference to `of_find_backlight_by_node'

This adds a Kconfig dependency like we have for the other OMAP display targets.

Fixes 39135a305a0f ("drm/omap: displays: panel-dpi: Support for handling backlight devices")
---
 drivers/gpu/drm/omapdrm/displays/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/omapdrm/displays/Kconfig +0 -0
index c226da145fb3..a349cb61961e 100644

drivers/gpu/drm/omapdrm/displays/Kconfig config DRM_OMAP_CONNECTOR_ANALOG_TV · line 40

Quoted 6 lines
drivers/gpu/drm/omapdrm/displays/Kconfig +1 -0
@@ -35,6 +35,7 @@ config DRM_OMAP_CONNECTOR_ANALOG_TV
 
 config DRM_OMAP_PANEL_DPI
 	tristate "Generic DPI panel"
+	depends on BACKLIGHT_CLASS_DEVICE
 	help
 	  Driver for generic DPI panels.

Thanks, I've queued this for 4.14 fixes.

Tomi

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel