Skip to contentSkip to conversation

bcache: mark expected switch fall-throughs in STRTO_H

PATCH In review Gustavo A. R. Silva 3 participants 3 messages Oct 9, 2017 – Oct 10, 2017

Subsystems (2)
MD RAID bcache (block layer cache)
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 bcache: mark expected switch fall-throughs in STRTO_H

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Cc Kent Overstreet <[email protected]>
Cc Shaohua Li <[email protected]>
Cc [email protected]
Cc [email protected]
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/md/bcache/util.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/md/bcache/util.c +7 -0
index 176d3c2..da9194b 100644
@@ -32,20 +32,27 @@ int bch_ ## name ## _h(const char *cp, type *res)		\
 	case 'y':						\
 	case 'z':						\
 		u++;						\
+		/* fall through */				\
 	case 'e':						\
 		u++;						\
+		/* fall through */				\
 	case 'p':						\
 		u++;						\
+		/* fall through */				\
 	case 't':						\
 		u++;						\
+		/* fall through */				\
 	case 'g':						\
 		u++;						\
+		/* fall through */				\
 	case 'm':						\
 		u++;						\
+		/* fall through */				\
 	case 'k':						\
 		u++;						\
 		if (e++ == cp)					\
 			return -EINVAL;				\
+		/* fall through */				\
 	case '\n':						\
 	case '\0':						\
 		if (*e == '\n')					\
Signature · 1 line
2.7.4
Reviewed-by on v1 1/1
#2 lore raw
In reply to Gustavo A. R. Silva
Quoted 8 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Cc Kent Overstreet <[email protected]>
Cc Shaohua Li <[email protected]>
Cc [email protected]
Cc [email protected]
Signed-off-by Gustavo A. R. Silva <[email protected]>

It seems for gcc7, and -Wimplicit-fallthrough is equal to -Wimplicit-fallthrough=3, code comments work.

Reviewed-by Coly Li <[email protected]>

Thanks.

Coly

Quoted 37 lines
---
 drivers/md/bcache/util.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/md/bcache/util.c +7 -0
index 176d3c2..da9194b 100644
@@ -32,20 +32,27 @@ int bch_ ## name ## _h(const char *cp, type *res)		\
 	case 'y':						\
 	case 'z':						\
 		u++;						\
+		/* fall through */				\
 	case 'e':						\
 		u++;						\
+		/* fall through */				\
 	case 'p':						\
 		u++;						\
+		/* fall through */				\
 	case 't':						\
 		u++;						\
+		/* fall through */				\
 	case 'g':						\
 		u++;						\
+		/* fall through */				\
 	case 'm':						\
 		u++;						\
+		/* fall through */				\
 	case 'k':						\
 		u++;						\
 		if (e++ == cp)					\
 			return -EINVAL;				\
+		/* fall through */				\
 	case '\n':						\
 	case '\0':						\
 		if (*e == '\n')					\