Skip to contentSkip to conversation

linux-firmware: make i.MX SDMA split complete

PATCH In review Mikko Ylinen 2 participants 3 messages Oct 10, 2017 – Oct 12, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 linux-firmware: make i.MX SDMA split complete

The commit to split i.MX SDMA firmware blobs in their own packages was not complete and results in a failure when trying to install full linux-firmware:

* Solver encountered 1 problem(s):
* Problem 1/1:
* - nothing provides linux-firmware-imx-sdma-license needed
* by linux-firmware-1:0.0+git0+a61ac5cf83-r0.all
*
* Solution 1:
* - do not ask to install a package providing linux-firmware

Make the split complete by installing the license in ${PN}-imx-sdma-license and have the blob packages depend on it.

---
 meta/recipes-kernel/linux-firmware/linux-firmware_git.bb | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
meta/recipes-kernel/linux-firmware/linux-firmware_git.bb +8 -1
index 3cf432e83a..0338ba8ac2 100644
@@ -563,7 +563,9 @@ FILES_${PN}-whence-license = "${nonarch_base_libdir}/firmware/WHENCE"
 RDEPENDS_${PN}-bnx2-mips += "${PN}-whence-license"
 
 # For imx-sdma
-LICENSE_${PN}-imx-sdma          = "Firmware-imx-sdma_firmware"
+LICENSE_${PN}-imx-sdma-imx6q       = "Firmware-imx-sdma_firmware"
+LICENSE_${PN}-imx-sdma-imx7d       = "Firmware-imx-sdma_firmware"
+LICENSE_${PN}-imx-sdma-license       = "Firmware-imx-sdma_firmware"
 
 FILES_${PN}-imx-sdma-imx6q = "${nonarch_base_libdir}/firmware/imx/sdma/sdma-imx6q.bin"
 
@@ -573,6 +575,11 @@ RCONFLICTS_${PN}-imx-sdma-imx6q = "firmware-imx-sdma-imx6q"
 
 FILES_${PN}-imx-sdma-imx7d = "${nonarch_base_libdir}/firmware/imx/sdma/sdma-imx7d.bin"
 
+FILES_${PN}-imx-sdma-license = "${nonarch_base_libdir}/firmware/LICENSE.sdma_firmware"
+
+RDEPENDS_${PN}-imx-sdma-imx6q += "${PN}-imx-sdma-license"
+RDEPENDS_${PN}-imx-sdma-imx7d += "${PN}-imx-sdma-license"
+
 # For iwlwifi
 LICENSE_${PN}-iwlwifi           = "Firmware-iwlwifi_firmware"
 LICENSE_${PN}-iwlwifi-135-6     = "Firmware-iwlwifi_firmware"
Signature · 1 line
2.11.0
#1 lore raw

Hello Mikko,

Quoted 12 lines · Mikko Ylinen

The commit to split i.MX SDMA firmware blobs in their own packages was not complete and results in a failure when trying to install full linux-firmware:

* Solver encountered 1 problem(s):
* Problem 1/1:
* - nothing provides linux-firmware-imx-sdma-license needed
* by linux-firmware-1:0.0+git0+a61ac5cf83-r0.all
*
* Solution 1:
* - do not ask to install a package providing linux-firmware

Quoted 4 lines

Make the split complete by installing the license in ${PN}-imx-sdma-license and have the blob packages depend on it.

First, thanks for fixing my mistake ... I will try to find what I did wrong here as I did test it.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#2 lore raw

Hi,

Quoted 16 lines · Otavio Salvador

Hello Mikko,

Quoted 12 lines · Mikko Ylinen

The commit to split i.MX SDMA firmware blobs in their own packages was not complete and results in a failure when trying to install full linux-firmware:

* Solver encountered 1 problem(s):
* Problem 1/1:
* - nothing provides linux-firmware-imx-sdma-license needed
* by linux-firmware-1:0.0+git0+a61ac5cf83-r0.all
*
* Solution 1:
* - do not ask to install a package providing linux-firmware

Quoted 8 lines
Quoted 4 lines

Make the split complete by installing the license in ${PN}-imx-sdma-license and have the blob packages depend on it.

First, thanks for fixing my mistake ... I will try to find what I did wrong here as I did test it.

No problem. I'm guessing you did not install linux-firmware (perhaps just the newly created packages only). The recipe builds fine but fails to install resulting .ipk/.rpm.

-- Mikko