staging: rtlwifi: mark expected switch fall-through in rtl_make_smps_action

PATCH New Gustavo A. R. Silva 1 participant 1 message Oct 10, 2017 Staging

lore

Share & tools

lore

Gustavo A. R. Silva

author

2017-10-10 19:01 UTC #0 lore raw

PATCH 1/1 staging: rtlwifi: mark expected switch fall-through in rtl_make_smps_action

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/staging/rtlwifi/base.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

drivers/staging/rtlwifi/base.c +1 -3

index b88b0e8..cc38907 100644
@@ -2334,9 +2334,7 @@ static struct sk_buff *rtl_make_smps_action(struct ieee80211_hw *hw,
 	case IEEE80211_SMPS_AUTOMATIC:/* 0 */
 	case IEEE80211_SMPS_NUM_MODES:/* 4 */
 		WARN_ON(1);
-	/* Here will get a 'MISSING_BREAK' in Coverity Test, just ignore it.
-	 * According to Kernel Code, here is right.
-	 */
+	/* fall through */
 	case IEEE80211_SMPS_OFF:/* 1 */ /*MIMO_PS_NOLIMIT*/
 		action_frame->u.action.u.ht_smps.smps_control =
 				WLAN_HT_SMPS_CONTROL_DISABLED;/* 0 */

Signature · 1 line

2.7.4