staging: greybus: mark expected switch fall-through in check_urb_status

PATCH In review Gustavo A. R. Silva 3 participants 8 messages Oct 10, 2017 – Oct 12, 2017

Subsystems (2)

Staging Greybus

lore

Share & tools

lore

Gustavo A. R. Silva

author

2017-10-10 21:01 UTC #0 lore raw

PATCH 1/1 staging: greybus: mark expected switch fall-through in check_urb_status

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/staging/greybus/es2.c | 1 +
 1 file changed, 1 insertion(+)

drivers/staging/greybus/es2.c +1 -0

index f7b24e0..e451c2f 100644
@@ -761,6 +761,7 @@ static int check_urb_status(struct urb *urb)
 	case -EOVERFLOW:
 		dev_err(dev, "%s: overflow actual length is %d\n",
 			__func__, urb->actual_length);
+		/* fall through */
 	case -ECONNRESET:
 	case -ENOENT:
 	case -ESHUTDOWN:

Signature · 1 line

2.7.4

Johan Hovold

maintainer Acked-by on v1 1/1

2017-10-11 07:45 UTC #1 lore raw

Quoted 4 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Signed-off-by Gustavo A. R. Silva <[email protected]>

Acked-by Johan Hovold <[email protected]>

Patch is fine, but next time make sure to run scripts/get_maintainer.sh to figure which people and lists to CC.

We also try to include the module (component) "es2" in the commit summary (unless you really are doing things subsystem wide), although that has not been enforced for staging clean ups recently.

Thanks,
Johan

Gustavo A. R. Silva

author

2017-10-11 15:59 UTC #2 lore raw

Hi Johan,

Quoting Johan Hovold <[email protected]>:

Quoted 11 lines · Gustavo A. R. Silva

Quoted 4 lines
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Acked-by Johan Hovold <[email protected]>
Patch is fine, but next time make sure to run scripts/get_maintainer.sh to figure which people and lists to CC.

I actually did:

$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback drivers/staging/greybus/es2.c

and this was the output:

[email protected] (open list)

Quoted 4 lines

We also try to include the module (component) "es2" in the commit summary (unless you really are doing things subsystem wide), although that has not been enforced for staging clean ups recently.

I got it. I'll take that into account for future patches.

Thanks
--
Gustavo A. R. Silva

Joe Perches

2017-10-11 16:06 UTC #3 lore raw

Quoted 16 lines · Gustavo A. R. Silva

Hi Johan,
Quoting Johan Hovold <[email protected]>:
Quoted 11 lines · Gustavo A. R. Silva
Quoted 4 lines
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Acked-by Johan Hovold <[email protected]>
Patch is fine, but next time make sure to run scripts/get_maintainer.sh to figure which people and lists to CC.

Quoted 8 lines

I actually did:
$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback  
drivers/staging/greybus/es2.c
and this was the output:
[email protected] (open list)

I don't know how that happens.

$ ./scripts/get_maintainer.pl -f --nokeywords --nogit --nogit-fallback drivers/staging/greybus/es2.c
Johan Hovold <[email protected]> (maintainer:GREYBUS SUBSYSTEM)
Alex Elder <[email protected]> (maintainer:GREYBUS SUBSYSTEM)
Greg Kroah-Hartman <[email protected]> (maintainer:GREYBUS SUBSYSTEM)
[email protected] (moderated list:GREYBUS SUBSYSTEM)
[email protected] (open list:STAGING SUBSYSTEM)
[email protected] (open list)

Johan Hovold

maintainer

2017-10-11 16:08 UTC #5 lore raw

In reply to Gustavo A. R. Silva

Quoted 8 lines · Gustavo A. R. Silva

Hi Johan,
Quoting Johan Hovold <[email protected]>:
Quoted 3 lines
Patch is fine, but next time make sure to run scripts/get_maintainer.sh to figure which people and lists to CC.

Quoted 8 lines

I actually did:
$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback  
drivers/staging/greybus/es2.c
and this was the output:
[email protected] (open list)

Very odd. If I run the exact same command I get the expected result:

Johan Hovold <[email protected]> (maintainer:GREYBUS SUBSYSTEM) Alex Elder <[email protected]> (maintainer:GREYBUS SUBSYSTEM)
Greg Kroah-Hartman <[email protected]> (maintainer:GREYBUS SUBSYSTEM) [email protected] (moderated list:GREYBUS SUBSYSTEM) [email protected] (open list:STAGING SUBSYSTEM) [email protected] (open list)

Quoted 6 lines

Quoted 4 lines
We also try to include the module (component) "es2" in the commit summary (unless you really are doing things subsystem wide), although that has not been enforced for staging clean ups recently.
I got it. I'll take that into account for future patches.

Looking at the commit history for the file in questions usually gives a hint about the style used for the corresponding subsystem.

Thanks,
Johan

Gustavo A. R. Silva

author

2017-10-11 16:58 UTC #4 lore raw

In reply to Joe Perches

Hi Joe,

Quoting Joe Perches <[email protected]>:

Quoted 28 lines · Gustavo A. R. Silva

Quoted 16 lines
Hi Johan,
Quoting Johan Hovold <[email protected]>:
Quoted 11 lines · Gustavo A. R. Silva
Quoted 4 lines
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Acked-by Johan Hovold <[email protected]>
Patch is fine, but next time make sure to run scripts/get_maintainer.sh to figure which people and lists to CC.
Quoted 8 lines
I actually did:
$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback
drivers/staging/greybus/es2.c
and this was the output:
[email protected] (open list)
I don't know how that happens.

Quoted 8 lines

$ ./scripts/get_maintainer.pl -f --nokeywords --nogit  
--nogit-fallback drivers/staging/greybus/es2.c
Johan Hovold <[email protected]> (maintainer:GREYBUS SUBSYSTEM)
Alex Elder <[email protected]> (maintainer:GREYBUS SUBSYSTEM)
Greg Kroah-Hartman <[email protected]> (maintainer:GREYBUS SUBSYSTEM)
[email protected] (moderated list:GREYBUS SUBSYSTEM)
[email protected] (open list:STAGING SUBSYSTEM)
[email protected] (open list)

I was running this command:

$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback drivers//staging/greybus/es2.c

instead of this one:

$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback drivers/staging/greybus/es2.c

Thanks
--
Gustavo A. R. Silva

Gustavo A. R. Silva

author

2017-10-11 17:18 UTC #6 lore raw

In reply to Johan Hovold

Quoting Johan Hovold <[email protected]>:

Quoted 18 lines · Gustavo A. R. Silva

Quoted 8 lines
Hi Johan,
Quoting Johan Hovold <[email protected]>:
Quoted 3 lines
Patch is fine, but next time make sure to run scripts/get_maintainer.sh to figure which people and lists to CC.
Quoted 8 lines
I actually did:
$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback
drivers/staging/greybus/es2.c
and this was the output:
[email protected] (open list)

Quoted 9 lines

Very odd. If I run the exact same command I get the expected result:
Johan Hovold <[email protected]> (maintainer:GREYBUS SUBSYSTEM) Alex Elder <[email protected]> (maintainer:GREYBUS SUBSYSTEM)
Greg Kroah-Hartman <[email protected]> (maintainer:GREYBUS SUBSYSTEM) [email protected] (moderated list:GREYBUS SUBSYSTEM) [email protected] (open list:STAGING SUBSYSTEM) [email protected] (open list)

I double checked and this is what happened:

$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback drivers//staging/greybus/es2.c

Notice that double slash after drivers: //

For some reason I was running that command instead of this one:

$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback drivers/staging/greybus/es2.c

Quoted 10 lines

Quoted 6 lines
Quoted 4 lines
We also try to include the module (component) "es2" in the commit summary (unless you really are doing things subsystem wide), although that has not been enforced for staging clean ups recently.
I got it. I'll take that into account for future patches.
Looking at the commit history for the file in questions usually gives a hint about the style used for the corresponding subsystem.

Yep, I usually do that:

$ git log --oneline drivers/staging/greybus/es2.c

This time I got many of these two:

staging: greybus:
greybus: es2:

so I picked up the first one.

But I get your point and I understand now that I should have used the second one.

Thanks
--
Gustavo A. R. Silva

Johan Hovold

maintainer

2017-10-12 09:05 UTC #7 lore raw

Quoted 18 lines · Gustavo A. R. Silva

Quoting Johan Hovold <[email protected]>:
Quoted 16 lines · Gustavo A. R. Silva
Quoted 15 lines
Hi Johan,
Quoting Johan Hovold <[email protected]>:
Quoted 3 lines
Patch is fine, but next time make sure to run scripts/get_maintainer.sh to figure which people and lists to CC.
I actually did:
$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback
drivers/staging/greybus/es2.c
and this was the output:

Quoted 8 lines

Quoted 1 line
Quoted 1 line
[email protected] (open list)
I double checked and this is what happened:
$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback  
drivers//staging/greybus/es2.c
Notice that double slash after drivers: //

Ah, perhaps something which should be supported.

Quoted 17 lines

Quoted 10 lines
Quoted 6 lines
Quoted 4 lines
We also try to include the module (component) "es2" in the commit summary (unless you really are doing things subsystem wide), although that has not been enforced for staging clean ups recently.
I got it. I'll take that into account for future patches.
Looking at the commit history for the file in questions usually gives a hint about the style used for the corresponding subsystem.
Yep, I usually do that:
$ git log --oneline drivers/staging/greybus/es2.c
This time I got many of these two:

Quoted 7 lines

staging: greybus:
greybus: es2:
so I picked up the first one.
But I get your point and I understand now that I should have used the second one.

Good, so you already have the habit of doing so. As I mentioned, this file in staging is not the best example since the prefix has changed over time and not really been enforced lately (it should really be "staging: greybus: es2" now).

Thanks,
Johan