Skip to contentSkip to conversation

fs/block_dev: remove vfs_msg() interface

PATCH In review Rakesh Pandit 3 participants 3 messages Oct 12, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs/block_dev: remove vfs_msg() interface

Replaced by pr_err usage in commit ef51042472f5 ("block, dax: move "select DAX" from BLOCK to FS_DAX")

---

Al, May you consider queuing this for v4.15 ? Thank you.

 fs/block_dev.c         | 12 ------------
 include/linux/blkdev.h | 11 -----------
 2 files changed, 23 deletions(-)
fs/block_dev.c +0 -12
index 93d088f..07ddccd 100644
@@ -54,18 +54,6 @@ struct block_device *I_BDEV(struct inode *inode)
 }
 EXPORT_SYMBOL(I_BDEV);
 
-void __vfs_msg(struct super_block *sb, const char *prefix, const char *fmt, ...)
-{
-	struct va_format vaf;
-	va_list args;
-
-	va_start(args, fmt);
-	vaf.fmt = fmt;
-	vaf.va = &args;
-	printk_ratelimited("%sVFS (%s): %pV\n", prefix, sb->s_id, &vaf);
-	va_end(args);
-}
-
 static void bdev_write_inode(struct block_device *bdev)
 {
 	struct inode *inode = bdev->bd_inode;
include/linux/blkdev.h +0 -11
index 02fa42d..a373246 100644
@@ -922,17 +922,6 @@ static inline void rq_flush_dcache_pages(struct request *rq)
 }
 #endif
 
-#ifdef CONFIG_PRINTK
-#define vfs_msg(sb, level, fmt, ...)				\
-	__vfs_msg(sb, level, fmt, ##__VA_ARGS__)
-#else
-#define vfs_msg(sb, level, fmt, ...)				\
-do {								\
-	no_printk(fmt, ##__VA_ARGS__);				\
-	__vfs_msg(sb, "", " ");					\
-} while (0)
-#endif
-
 extern int blk_register_queue(struct gendisk *disk);
 extern void blk_unregister_queue(struct gendisk *disk);
 extern blk_qc_t generic_make_request(struct bio *bio);
Signature · 1 line
2.9.3
maintainer
#2 lore raw
Quoted 11 lines · Dan Williams
Quoted 8 lines · Rakesh Pandit

Replaced by pr_err usage in commit ef51042472f5 ("block, dax: move "select DAX" from BLOCK to FS_DAX")

---

Al, May you consider queuing this for v4.15 ? Thank you.

Should go through Jens, but if it lingers a few more days I'll grab it.

I've picked it up.

Signature · 1 line
Jens Axboe