remove extra word in command
PATCH 1/18 remove extra word in command
remove extra 'any' word in command line
--- engine/tests/Functional.bsdiff/fuego_test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
engine/tests/Functional.bsdiff/fuego_test.sh +1 -1
@@ -6,7 +6,7 @@ function test_deploy { function test_run { report "cd $BOARD_TESTDIR/fuego.$TESTDIR; \ - if bsdiff 13.bspatch.original 13.bspatch.modified 13.diff any; then echo 'TEST-1 OK'; else echo 'TEST-1 FAIL'; fi; \ + if bsdiff 13.bspatch.original 13.bspatch.modified 13.diff; then echo 'TEST-1 OK'; else echo 'TEST-1 FAIL'; fi; \ if bspatch 13.bspatch.original 13.out 13.diff; then echo 'TEST-2 OK'; else echo 'TEST-2 FAIL'; fi; \ if diff 13.bspatch.modified 13.out; then echo 'TEST-3 OK'; else echo 'TEST-3 FAIL'; fi" }
Signature · 1 line
2.9.3.windows.3
OK -here is some preliminary information.
I've now moved to using my 'master' branch for Fuego work. You can consider this to be part of the 1.2 'merge' window. I've already tagged the 1.2 (Combustion) release, but don't worry about that. I've decided to work in the 'master' branch and add these fixes in a minor release, since they don't disturb and of the core functionality of Fuego. When the dust settles on these fixes, and fixes that are in-flight for LTP, then I'll tag a minor release (and maybe move the "Combustion" tag).
Comments will generally be inline or below the patches.
I won't push until the end, so if you see me say 'applied', but don't see it on bitbucket, just ping me (or wait a bit).
Thanks,
-- Tim
Quoted 28 lines
-----Original Message-----
From: [email protected] [mailto:fuego- [email protected]] On Behalf Of Song Cai
Sent: Friday, October 13, 2017 3:04 AM
To: [email protected]
Subject: [Fuego] [PATCH 01/18] remove extra word in commandremove extra 'any' word in command line
Signed-off-by Song Cai <[email protected]>--- engine/tests/Functional.bsdiff/fuego_test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)engine/tests/Functional.bsdiff/fuego_test.sh +1
-1@@ -6,7 +6,7 @@ function test_deploy { function test_run { report "cd $BOARD_TESTDIR/fuego.$TESTDIR; \ - if bsdiff 13.bspatch.original 13.bspatch.modified 13.diff any; then echo 'TEST-1 OK'; else echo 'TEST-1 FAIL'; fi; \ + if bsdiff 13.bspatch.original 13.bspatch.modified 13.diff; then echo 'TEST-1 OK'; else echo 'TEST-1 FAIL'; fi; \ if bspatch 13.bspatch.original 13.out 13.diff; then echo 'TEST-2 OK'; else
Quoted 6 lines
echo 'TEST-2 FAIL'; fi; \
if diff 13.bspatch.modified 13.out; then echo 'TEST-3 OK'; else echo 'TEST-3
FAIL'; fi"
}
--
2.9.3.windows.3
Looks OK to me. Applied in my 'master' branch.
However, this test fails for me, since my targets don't have bsdiff. Is this included in AGL?
This patch depends on bsdiff being already installed on the target. Can you add an 'test_pre_check' with an is_on_target for this?
Thanks,
-- TimP.S. I should probably get AGL installed on one of my boards here to test this stuff. I have a Raspberry Pi 3, and I think that's supported.