Skip to contentSkip to conversation

wandboard: disable RevD1 support with use-mainline-bsp

PATCH In review Trevor Woerner 2 participants 3 messages Oct 15, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wandboard: disable RevD1 support with use-mainline-bsp

use-mainline-bsp uses linux-fslc (as opposed to linux-wandboard otherwise) which doesn't currently have the RevD1 definitions.

---
 conf/machine/wandboard.conf | 6 ++++++
 1 file changed, 6 insertions(+)
conf/machine/wandboard.conf +6 -0
index e07046d..8eaf58e 100644
@@ -29,6 +29,12 @@ KERNEL_DEVICETREE = " \
     imx6q-wandboard-revd1.dtb \
     imx6qp-wandboard-revd1.dtb \
 "
+KERNEL_DEVICETREE_use-mainline-bsp = " \
+    imx6dl-wandboard.dtb \
+    imx6dl-wandboard-revb1.dtb \
+    imx6q-wandboard.dtb \
+    imx6q-wandboard-revb1.dtb \
+"
 
 KERNEL_IMAGETYPE = "zImage"
 
Signature · 1 line
2.14.1.459.g238e487ea
#1 lore raw

Hi Trevor,

Quoted 4 lines · Trevor Woerner

use-mainline-bsp uses linux-fslc (as opposed to linux-wandboard otherwise) which doesn't currently have the RevD1 definitions.

This fixes the build error, but it will give a run-time error in case someone has a revd1 as the revd1 dtb's will not be found.

It would be better to add the revd1 dts as per this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/commit/?h=for-next&id=36cfd5b3fb556ea7f818f2669c29d15817942b97

#2 lore raw
Quoted 6 lines · Fabio Estevam

Hi Trevor,

Quoted 3 lines · Trevor Woerner

use-mainline-bsp uses linux-fslc (as opposed to linux-wandboard otherwise) which doesn't currently have the RevD1 definitions.

Quoted 7 lines
Quoted 1 line

This fixes the build error, but it will give a run-time error in case someone has a revd1 as the revd1 dtb's will not be found.

It would be better to add the revd1 dts as per this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/commit/?h=for-next&id=36cfd5b3fb556ea7f818f2669c29d15817942b97

Good point. I've submitted https://github.com/Freescale/linux-fslc/pull/16