Skip to contentSkip to conversation

soc: qcom: remove unused label

PATCH In review Arnd Bergmann 3 participants 4 messages Oct 18, 2017 – Nov 3, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: qcom: remove unused label

The newly added driver comes with a harmless warning:

drivers/soc/qcom/rmtfs_mem.c: In function 'qcom_rmtfs_mem_probe':
drivers/soc/qcom/rmtfs_mem.c:211:1: error: label 'remove_cdev' defined but not used [-Werror=unused-label]

This removes the unused label to avoid the warning.

Fixes 702baebb8e00 ("soc: qcom: Remote filesystem memory driver")
---
 drivers/soc/qcom/rmtfs_mem.c | 2 --
 1 file changed, 2 deletions(-)
drivers/soc/qcom/rmtfs_mem.c +0 -2
index f6f2f0cb3b3a..ce35ff748adf 100644
@@ -208,8 +208,6 @@ static int qcom_rmtfs_mem_probe(struct platform_device *pdev)
 
 	return 0;
 
-remove_cdev:
-	cdev_device_del(&rmtfs_mem->cdev, &rmtfs_mem->dev);
 put_device:
 	put_device(&rmtfs_mem->dev);
 
Signature · 1 line
2.9.0
#1 lore raw
Quoted 9 lines · Arnd Bergmann

The newly added driver comes with a harmless warning:

drivers/soc/qcom/rmtfs_mem.c: In function 'qcom_rmtfs_mem_probe':
drivers/soc/qcom/rmtfs_mem.c:211:1: error: label 'remove_cdev' defined but not used [-Werror=unused-label]

This removes the unused label to avoid the warning.

Fixes 702baebb8e00 ("soc: qcom: Remote filesystem memory driver")

I just noticed that the build bots now show the warning arm-soc/next/drivers, so I've
applied my patch on top of that branch.

Arnd

#2 lore raw
Quoted 6 lines · Arnd Bergmann
Quoted 5 lines · Arnd Bergmann

The newly added driver comes with a harmless warning:

drivers/soc/qcom/rmtfs_mem.c: In function 'qcom_rmtfs_mem_probe':
drivers/soc/qcom/rmtfs_mem.c:211:1: error: label 'remove_cdev' defined but not used [-Werror=unused-label]

Quoted 9 lines
Quoted 4 lines

This removes the unused label to avoid the warning.

Fixes 702baebb8e00 ("soc: qcom: Remote filesystem memory driver")

I just noticed that the build bots now show the warning arm-soc/next/drivers, so I've
applied my patch on top of that branch.

Okay, that sounds good. Sorry for missing your previous email.

I apparently got that snippet sqaushed into the wrong commit, will add it back when I post the follow-up patch needing it.

Regards,
Bjorn

Reviewed-by on v1 1/1
#3 lore raw
In reply to Arnd Bergmann
Quoted 9 lines · Arnd Bergmann

The newly added driver comes with a harmless warning:

drivers/soc/qcom/rmtfs_mem.c: In function 'qcom_rmtfs_mem_probe':
drivers/soc/qcom/rmtfs_mem.c:211:1: error: label 'remove_cdev' defined but not used [-Werror=unused-label]

This removes the unused label to avoid the warning.

Fixes 702baebb8e00 ("soc: qcom: Remote filesystem memory driver")

Looks good.

Quoted 18 lines
---
 drivers/soc/qcom/rmtfs_mem.c | 2 --
 1 file changed, 2 deletions(-)
drivers/soc/qcom/rmtfs_mem.c +0 -2
index f6f2f0cb3b3a..ce35ff748adf 100644
@@ -208,8 +208,6 @@ static int qcom_rmtfs_mem_probe(struct platform_device *pdev)
 
 	return 0;
 
-remove_cdev:
-	cdev_device_del(&rmtfs_mem->cdev, &rmtfs_mem->dev);
 put_device:
 	put_device(&rmtfs_mem->dev);