Skip to contentSkip to conversation

vmbus: hvsock: add proper sync for vmbus_hvsock_device_unregister()

PATCH New [email protected] 1 participant 1 message Oct 18, 2017 Hyper-V/Azure core and drivers

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 vmbus: hvsock: add proper sync for vmbus_hvsock_device_unregister()

From: Dexuan Cui <[email protected]>

Without the patch, vmbus_hvsock_device_unregister() can destroy the device prematurely when close() is called, and can cause NULl dereferencing or potential data loss (the last portion of the data stream may be dropped prematurely).

Cc Haiyang Zhang <[email protected]>
Cc Stephen Hemminger <[email protected]>

---
Please consider this for 4.14.
V2: Moved some comments around (Dan Carpenter)

 drivers/hv/channel_mgmt.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/hv/channel_mgmt.c +4 -1
index 018d2e0f8ec5..379b0df123be 100644
@@ -937,7 +937,10 @@ void vmbus_hvsock_device_unregister(struct vmbus_channel *channel)
 {
 	BUG_ON(!is_hvsock_channel(channel));
 
-	channel->rescind = true;
+	/* We always get a rescind msg when a connection is closed. */
+	while (!READ_ONCE(channel->probe_done) || !READ_ONCE(channel->rescind))
+		msleep(1);
+
 	vmbus_device_unregister(channel->device_obj);
 }
 EXPORT_SYMBOL_GPL(vmbus_hvsock_device_unregister);
Signature · 1 line
2.14.1