lib/igt_kms: Only print changed mode objects during atomic commit.
PATCH 1/1 lib/igt_kms: Only print changed mode objects during atomic commit.
When we only print mode objects that have changed properties, we reduce a lot of the spam. Fortuantely we have a single bitfield now that gets printed when something is changed. Use that to decrease the amount of spam.
--- lib/igt_kms.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
lib/igt_kms.c +5 -3
@@ -2653,10 +2653,12 @@ static int igt_atomic_commit(igt_display_t *display, uint32_t flags, void *user_/* * Add CRTC Properties to the property set */ -igt_atomic_prepare_crtc_commit (pipe_obj, req); +if (pipe_obj->changed) +igt_atomic_prepare_crtc_commit (pipe_obj, req);for_each_plane_on_pipe (display, pipe, plane) { -igt_atomic_prepare_plane_commit (plane, pipe_obj, req); +if (plane->changed) +igt_atomic_prepare_plane_commit (plane, pipe_obj, req); } }
@@ -2664,7 +2666,7 @@ static int igt_atomic_commit(igt_display_t *display, uint32_t flags, void *user_for (i =0 ; i < display->n_outputs; i++) { output = &display->outputs[i]; -if (!output->config.connector) +if (!output->config.connector || !output->changed)continue ; LOG(display, "%s: preparing atomic, pipe: %s\n",
Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for lib/igt_kms: Only print changed mode objects during atomic commit.
== Series Details ==
== Series Details ==
Series: lib/igt_kms: Only print changed mode objects during atomic commit.
URL : https://patchwork.freedesktop.org/series/32360/
State : success
== Summary ==
IGT patchset tested on top of latest successful build 9ba736aecc2a3cb34a2aeec8d417f66390e0c82b tools/intel_vbt_decode: abstract child devices printing more
with latest DRM-Tip kernel build CI_DRM_326975b85b0dce2f drm-tip: 2017y-10m-20d-10h-07m-16s UTC integration manifest
No testlist changes.
Test gem_exec_reloc:
Subgroup basic-cpu-read-active:
pass -> FAIL (fi-gdg-551) fdo#102582
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-b-frame-sequence:
incomplete -> PASS (fi-skl-6700hq) fdo#102035
Test prime_vgem:
Subgroup basic-fence-flip:
dmesg-warn -> PASS (fi-kbl-7567u) fdo#103165 +1fdo#102582 https://bugs.freedesktop.org/show_bug.cgi?id=102582
fdo#102035 https://bugs.freedesktop.org/show_bug.cgi?id=102035
fdo#103165 https://bugs.freedesktop.org/show_bug.cgi?id=103165
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:446s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:459s fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:377s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:533s fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:265s fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:499s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:497s fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:498s fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:490s fi-cfl-s total:289 pass:253 dwarn:4 dfail:0 fail:0 skip:32 time:564s fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:410s fi-gdg-551 total:289 pass:177 dwarn:1 dfail:0 fail:2 skip:109 time:251s fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:579s fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:450s fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:429s fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:433s fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:495s fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:459s fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:497s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:575s fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:483s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:581s fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:552s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:454s fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:648s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:519s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:503s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:467s fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:567s fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:424s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_394/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: failure for lib/igt_kms: Only print changed mode objects during atomic commit.
In reply to Maarten Lankhorst== Series Details ==
== Series Details ==
Series: lib/igt_kms: Only print changed mode objects during atomic commit.
URL : https://patchwork.freedesktop.org/series/32360/
State : failure
== Summary ==
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-indfb-draw-mmap-cpu:
skip -> PASS (shard-hsw)
Subgroup fbc-1p-primscrn-cur-indfb-move:
skip -> PASS (shard-hsw)
Test kms_plane:
Subgroup plane-position-hole-pipe-A-planes:
skip -> PASS (shard-hsw)
Test gem_tiled_swapping:
Subgroup non-threaded:
pass -> INCOMPLETE (shard-hsw)
Test kms_busy:
Subgroup extended-modeset-hang-oldfb-with-reset-render-C:
pass -> DMESG-WARN (shard-hsw) fdo#102249 +2
Subgroup extended-modeset-hang-newfb-with-reset-render-B:
dmesg-warn -> PASS (shard-hsw) fdo#103038
Test kms_flip:
Subgroup blt-wf_vblank-vs-dpms:
dmesg-warn -> PASS (shard-hsw)
Test kms_setmode:
Subgroup basic:
pass -> FAIL (shard-hsw) fdo#99912fdo#102249 https://bugs.freedesktop.org/show_bug.cgi?id=102249
fdo#103038 https://bugs.freedesktop.org/show_bug.cgi?id=103038
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
shard-hsw total:2497 pass:1409 dwarn:3 dfail:0 fail:9 skip:1075 time:9052s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_394/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 4 lines · Maarten Lankhorst
When we only print mode objects that have changed properties, we reduce a lot of the spam. Fortuantely we have a single bitfield now that gets printed when something is changed. Use that to decrease the amount of spam.
s/Fortuantely/Fortunately/
Quoted 2 lines
Signed-off-by Maarten Lankhorst <[email protected]>
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Op 24-10-17 om 14:34 schreef Petri Latvala:
Quoted 7 lines · Maarten Lankhorst
Quoted 4 lines
When we only print mode objects that have changed properties, we reduce a lot of the spam. Fortuantely we have a single bitfield now that gets printed when something is changed. Use that to decrease the amount of spam.
s/Fortuantely/Fortunately/
Fixed, thanks for catching it!
Quoted 3 lines
Quoted 2 lines
Signed-off-by Maarten Lankhorst <[email protected]>Reviewed-by Petri Latvala <[email protected]>
Thanks, pushed. :)
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for lib/igt_kms: Only print changed mode objects during atomic commit.
In reply to Maarten Lankhorst== Series Details ==
== Series Details ==
Series: lib/igt_kms: Only print changed mode objects during atomic commit.
URL : https://patchwork.freedesktop.org/series/32360/
State : failure
== Summary ==
Series 32360 revision 1 was fully merged or fully failed: no git log
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_394/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx