Skip to contentSkip to conversation

i40e: Fix incorrect use of tx_itr_setting when checking for Rx ITR setup

PATCH New Alexander Duyck 2 participants 2 messages Oct 20, 2017 – Oct 25, 2017

Subsystems (2)
Network drivers Intel Ethernet
lore
Share & tools
lore

Alexander Duyck

author
#0 lore raw

PATCH 1/1 i40e: Fix incorrect use of tx_itr_setting when checking for Rx ITR setup

From: Alexander Duyck <[email protected]>

It looks like there was either a copy/paste error or just a typo that resulted in the Tx ITR setting being used to determine if we were using adaptive Rx interrupt moderation or not.

This patch fixes the typo.

Fixes 65e87c0398f5 ("i40evf: support queue-specific settings for interrupt moderation")
Signed-off-by Alexander Duyck <[email protected]>
---
 drivers/net/ethernet/intel/i40e/i40e_txrx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/i40e/i40e_txrx.c +1 -1
index edbc94c4353d..778633569663 100644
@@ -2277,7 +2277,7 @@ static inline void i40e_update_enable_itr(struct i40e_vsi *vsi,
 		goto enable_int;
 	}
 
-	if (ITR_IS_DYNAMIC(tx_itr_setting)) {
+	if (ITR_IS_DYNAMIC(rx_itr_setting)) {
 		rx = i40e_set_new_dynamic_itr(&q_vector->rx);
 		rxval = i40e_buildreg_itr(I40E_RX_ITR, q_vector->rx.itr);
 	}
#1 lore raw

PATCH 1/1 i40e: Fix incorrect use of tx_itr_setting when checking for Rx ITR setup

Quoted 14 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Alexander Duyck
Sent: Friday, October 20, 2017 1:59 PM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [jkirsher/net-queue PATCH] i40e: Fix incorrect use of tx_itr_setting when checking for Rx ITR setup

From: Alexander Duyck <[email protected]>

It looks like there was either a copy/paste error or just a typo that resulted in the Tx ITR setting being used to determine if we were using adaptive Rx interrupt moderation or not.

Quoted 8 lines

This patch fixes the typo.

Fixes 65e87c0398f5 ("i40evf: support queue-specific settings for interrupt

moderation")

Signed-off-by Alexander Duyck <[email protected]>
---
 drivers/net/ethernet/intel/i40e/i40e_txrx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Tested-by Andrew Bowers <[email protected]>