Skip to contentSkip to conversation

staging: atomisp: i2c: Convert timers to use timer_setup()

PATCH New Kees Cook 1 participant 1 message Oct 24, 2017

Subsystems (4)
Media (V4L/DVB) Staging Intel MID (Mobile Internet Device) platform Staging - atomisp driver
lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH 1/1 staging: atomisp: i2c: Convert timers to use timer_setup()

In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly.

Signed-off-by Kees Cook <[email protected]>
---
 drivers/staging/media/atomisp/i2c/lm3554.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/staging/media/atomisp/i2c/lm3554.c +3 -5
index 679176f7c542..a815f208409f 100644
@@ -171,10 +171,9 @@ static int lm3554_set_config1(struct lm3554 *flash)
 /* -----------------------------------------------------------------------------
  * Hardware trigger
  */
-static void lm3554_flash_off_delay(long unsigned int arg)
+static void lm3554_flash_off_delay(struct timer_list *t)
 {
-	struct v4l2_subdev *sd = i2c_get_clientdata((struct i2c_client *)arg);
-	struct lm3554 *flash = to_lm3554(sd);
+	struct lm3554 *flash = from_timer(flash, t, flash_off_delay);
 	struct lm3554_platform_data *pdata = flash->pdata;
 
 	gpio_set_value(pdata->gpio_strobe, 0);

@@ -915,8 +914,7 @@ static int lm3554_probe(struct i2c_client *client,
 
 	mutex_init(&flash->power_lock);
 
-	setup_timer(&flash->flash_off_delay, lm3554_flash_off_delay,
-		    (unsigned long)client);
+	timer_setup(&flash->flash_off_delay, lm3554_flash_off_delay, 0);
 
 	err = lm3554_gpio_init(client);
 	if (err) {
Signature · 6 lines
2.7.4


-- 
Kees Cook
Pixel Security