Skip to contentSkip to conversation

drivers/wireless: qtnfmac: Convert timers to use timer_setup()

PATCH In review Kees Cook 2 participants 2 messages Oct 24, 2017 – Oct 27, 2017

Subsystems (3)
Networking Network drivers Quantenna qtnfmac wireless driver
lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH 1/1 drivers/wireless: qtnfmac: Convert timers to use timer_setup()

In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly.

Cc Kalle Valo <[email protected]>
Cc Igor Mitsyanko <[email protected]>
Cc Avinash Patil <[email protected]>
Cc Sergey Matyukevich <[email protected]>
Cc Kamlesh Rath <[email protected]>
Cc [email protected]
Cc [email protected]
Signed-off-by Kees Cook <[email protected]>
---
 drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 7 +++----
 drivers/net/wireless/quantenna/qtnfmac/core.c     | 2 +-
 2 files changed, 4 insertions(+), 5 deletions(-)
drivers/net/wireless/quantenna/qtnfmac/cfg80211.c +3 -4
index 32bf72c0399f..ac1b9bd5ed90 100644
@@ -581,9 +581,9 @@ qtnf_del_station(struct wiphy *wiphy, struct net_device *dev,
 	return ret;
 }
 
-static void qtnf_scan_timeout(unsigned long data)
+static void qtnf_scan_timeout(struct timer_list *t)
 {
-	struct qtnf_wmac *mac = (struct qtnf_wmac *)data;
+	struct qtnf_wmac *mac = from_timer(mac, t, scan_timeout);
 
 	pr_warn("mac%d scan timed out\n", mac->macid);
 	qtnf_scan_done(mac, true);

@@ -602,8 +602,7 @@ qtnf_scan(struct wiphy *wiphy, struct cfg80211_scan_request *request)
 		return -EFAULT;
 	}
 
-	mac->scan_timeout.data = (unsigned long)mac;
-	mac->scan_timeout.function = qtnf_scan_timeout;
+	mac->scan_timeout.function = (TIMER_FUNC_TYPE)qtnf_scan_timeout;
 	mod_timer(&mac->scan_timeout,
 		  jiffies + QTNF_SCAN_TIMEOUT_SEC * HZ);
drivers/net/wireless/quantenna/qtnfmac/core.c +1 -1
index 5e60180482d1..aa7f146278a7 100644
@@ -289,7 +289,7 @@ static struct qtnf_wmac *qtnf_core_mac_alloc(struct qtnf_bus *bus,
 		mac->iflist[i].vifid = i;
 		qtnf_sta_list_init(&mac->iflist[i].sta_list);
 		mutex_init(&mac->mac_lock);
-		init_timer(&mac->scan_timeout);
+		setup_timer(&mac->scan_timeout, NULL, 0);
 	}
 
 	qtnf_mac_init_primary_intf(mac);
Signature · 6 lines
2.7.4


-- 
Kees Cook
Pixel Security
#1 lore raw

Re: qtnfmac: Convert timers to use timer_setup()

Quoted 4 lines · Kees Cook

In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly.

Quoted 8 lines
Cc Kalle Valo <[email protected]>
Cc Igor Mitsyanko <[email protected]>
Cc Avinash Patil <[email protected]>
Cc Sergey Matyukevich <[email protected]>
Cc Kamlesh Rath <[email protected]>
Cc [email protected]
Cc [email protected]
Signed-off-by Kees Cook <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

7e916cafb4d9 qtnfmac: Convert timers to use timer_setup()

Signature · 3 lines
https://patchwork.kernel.org/patch/10023851/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches