Input: Serio/hil_mlc: Convert timers to use timer_setup()
Subsystems (2)
PATCH 1/1 Input: Serio/hil_mlc: Convert timers to use timer_setup()
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly.
Cc Dmitry Torokhov <[email protected]>
Signed-off-by Kees Cook <[email protected]>
--- drivers/input/serio/hil_mlc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/input/serio/hil_mlc.c +2 -2
@@ -784,7 +784,7 @@ static void hil_mlcs_process(unsigned long unused)/************************* Keepalive timer task *********************/ -static void hil_mlcs_timer (unsigned long data) +static void hil_mlcs_timer (struct timer_list *unused) { hil_mlcs_probe =1 ;tasklet_schedule (&hil_mlcs_tasklet);
@@ -998,7 +998,7 @@ int hil_mlc_unregister(hil_mlc *mlc)static int __init hil_mlc_init (void ) { -setup_timer (&hil_mlcs_kicker, &hil_mlcs_timer,0 ); +timer_setup (&hil_mlcs_kicker, &hil_mlcs_timer,0 );mod_timer (&hil_mlcs_kicker, jiffies +HZ );tasklet_enable (&hil_mlcs_tasklet);
Signature · 6 lines
2.7.4 -- Kees Cook Pixel Security
Quoted 7 lines · Kees Cook
In preparation for unconditionally passing the struct
timer_listpointer to all timer callbacks, switch to using the newtimer_setup()andfrom_timer()to pass the timer pointer explicitly.Cc Dmitry Torokhov <[email protected]>Signed-off-by Kees Cook <[email protected]>
Applied, thank you.
Quoted 33 lines
--- drivers/input/serio/hil_mlc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/input/serio/hil_mlc.c +2
-2@@ -784,7 +784,7 @@ static void hil_mlcs_process(unsigned long unused)/************************* Keepalive timer task *********************/ -static void hil_mlcs_timer (unsigned long data) +static void hil_mlcs_timer (struct timer_list *unused) { hil_mlcs_probe =1 ;tasklet_schedule (&hil_mlcs_tasklet);@@ -998,7 +998,7 @@ int hil_mlc_unregister(hil_mlc *mlc)static int __init hil_mlc_init (void ) { -setup_timer (&hil_mlcs_kicker, &hil_mlcs_timer,0 ); +timer_setup (&hil_mlcs_kicker, &hil_mlcs_timer,0 );mod_timer (&hil_mlcs_kicker, jiffies +HZ );tasklet_enable (&hil_mlcs_tasklet);Signature · 6 lines
2.7.4 -- Kees Cook Pixel Security
Signature · 1 line
Dmitry