usb: storage: uas: mark expected switch fall-through

PATCH New Gustavo A. R. Silva 1 participant 1 message Oct 24, 2017

Subsystems (4)

SCSI USB USB mass storage driver USB attached SCSI

lore

Share & tools

lore

Gustavo A. R. Silva

author

2017-10-24 16:48 UTC #0 lore raw

PATCH 1/1 usb: storage: uas: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 115016

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/usb/storage/uas.c | 1 +
 1 file changed, 1 insertion(+)

drivers/usb/storage/uas.c +1 -0

index 63cf981..bd4671d 100644
@@ -668,6 +668,7 @@ static int uas_queuecommand_lck(struct scsi_cmnd *cmnd,
 		break;
 	case DMA_BIDIRECTIONAL:
 		cmdinfo->state |= ALLOC_DATA_IN_URB | SUBMIT_DATA_IN_URB;
+		/* fall through */
 	case DMA_TO_DEVICE:
 		cmdinfo->state |= ALLOC_DATA_OUT_URB | SUBMIT_DATA_OUT_URB;
 	case DMA_NONE:

Signature · 1 line

2.7.4