Skip to contentSkip to conversation

tools/intel_vbt_decode: Fix HDMI level shifter and max data rate bitfield sizes

PATCH In review Ville Syrjala 3 participants 5 messages Oct 27, 2017 – Oct 30, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/intel_vbt_decode: Fix HDMI level shifter and max data rate bitfield sizes

From: Ville Syrjälä <[email protected]>

The HDMI level shifter value should be 5 bits and the max data rate 3 bits.

---
 tools/intel_vbt_defs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/intel_vbt_defs.h +2 -2
index 404569c9fdfc..27da765eb0db 100644
@@ -334,8 +334,8 @@ struct child_device_config {
 			u8 i2c_speed;
 			u8 dp_onboard_redriver;			/* 158 */
 			u8 dp_ondock_redriver;			/* 158 */
-			u8 hdmi_level_shifter_value:4;		/* 169 */
-			u8 hdmi_max_data_rate:4;		/* 204 */
+			u8 hdmi_level_shifter_value:5;		/* 169 */
+			u8 hdmi_max_data_rate:3;		/* 204 */
 			u16 dtd_buf_ptr;			/* 161 */
 			u8 edidless_efp:1;			/* 161 */
 			u8 compression_enable:1;		/* 198 */
Signature · 6 lines
2.13.6

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Ville Syrjala

From: Ville Syrjälä <[email protected]>

The HDMI level shifter value should be 5 bits and the max data rate 3 bits.

Quoted 19 lines
---
 tools/intel_vbt_defs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/intel_vbt_defs.h +2 -2
index 404569c9fdfc..27da765eb0db 100644
@@ -334,8 +334,8 @@ struct child_device_config {
 			u8 i2c_speed;
 			u8 dp_onboard_redriver;			/* 158 */
 			u8 dp_ondock_redriver;			/* 158 */
-			u8 hdmi_level_shifter_value:4;		/* 169 */
-			u8 hdmi_max_data_rate:4;		/* 204 */
+			u8 hdmi_level_shifter_value:5;		/* 169 */
+			u8 hdmi_max_data_rate:3;		/* 204 */
 			u16 dtd_buf_ptr;			/* 161 */
 			u8 edidless_efp:1;			/* 161 */
 			u8 compression_enable:1;		/* 198 */
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

✗ Fi.CI.BAT: failure for tools/intel_vbt_decode: Fix HDMI level shifter and max data rate bitfield sizes

In reply to Ville Syrjala
== Series Details ==

== Series Details ==

Series: tools/intel_vbt_decode: Fix HDMI level shifter and max data rate bitfield sizes
URL : https://patchwork.freedesktop.org/series/32786/
State : failure

== Summary ==

IGT patchset tested on top of latest successful build 1fc4de1ca390adec9be8bd7cc0c36cab07465959 igt/gem_exec_latency: Wire up an interloper for preemption

with latest DRM-Tip kernel build CI_DRM_3292
d0582552491e drm-tip: 2017y-10m-27d-19h-16m-21s UTC integration manifest

No testlist changes.

Test gem_exec_flush:

        Subgroup basic-wb-ro-default:
                pass       -> DMESG-FAIL (fi-glk-dsi)
        Subgroup basic-wb-rw-before-default:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-wb-rw-default:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-wb-set-default:
                pass       -> SKIP       (fi-glk-dsi)
Test gem_exec_nop:
        Subgroup basic-parallel:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-series:
                pass       -> SKIP       (fi-glk-dsi)
Test gem_exec_parallel:
        Subgroup basic:
                pass       -> SKIP       (fi-glk-dsi)
Test gem_exec_reloc:
        Subgroup basic-cpu:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-gtt:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-cpu-gtt:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-gtt-cpu:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-cpu-read:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-gtt-read:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-write-cpu:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-write-gtt:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-write-read:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-cpu-noreloc:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-gtt-noreloc:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-cpu-gtt-noreloc:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-gtt-cpu-noreloc:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-cpu-read-noreloc:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-gtt-read-noreloc:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-write-cpu-noreloc:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-write-gtt-noreloc:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-write-read-noreloc:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-cpu-active:
                pass       -> FAIL       (fi-gdg-551) fdo#102582 +4
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-gtt-active:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-cpu-gtt-active:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-gtt-cpu-active:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-cpu-read-active:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-gtt-read-active:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-write-cpu-active:
                pass       -> FAIL       (fi-gdg-551)
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-write-gtt-active:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-write-read-active:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-softpin:
                pass       -> SKIP       (fi-glk-dsi)
Test gem_exec_store:
        Subgroup basic-all:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-blt:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-bsd:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-default:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-render:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-vebox:
                pass       -> SKIP       (fi-glk-dsi)
Test gem_exec_suspend:
        Subgroup basic:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-s3:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-s4-devices:
                pass       -> SKIP       (fi-glk-dsi)
Test gem_linear_blits:
        Subgroup basic:
                pass       -> SKIP       (fi-glk-dsi)
Test gem_render_linear_blits:
        Subgroup basic:
                pass       -> SKIP       (fi-glk-dsi)
Test gem_render_tiled_blits:
        Subgroup basic:
                pass       -> SKIP       (fi-glk-dsi)
Test gem_ringfill:
        Subgroup basic-default:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-default-interruptible:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-default-forked:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-default-fd:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-default-hang:
                pass       -> SKIP       (fi-glk-dsi)
Test gem_sync:
        Subgroup basic-all:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-each:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-many-each:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-store-all:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-store-each:
                pass       -> SKIP       (fi-glk-dsi)
Test gem_tiled_blits:
        Subgroup basic:
                pass       -> SKIP       (fi-glk-dsi)
Test gem_tiled_fence_blits:
        Subgroup basic:
                pass       -> SKIP       (fi-glk-dsi)
Test gem_wait:
        Subgroup basic-busy-all:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-wait-all:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-await-all:
                pass       -> SKIP       (fi-glk-dsi)
Test gem_workarounds:
        Subgroup basic-read:
                pass       -> SKIP       (fi-glk-dsi)
Test kms_busy:
        Subgroup basic-flip-a:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-flip-b:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-flip-c:
                pass       -> SKIP       (fi-glk-dsi)
Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-atomic:
                pass       -> SKIP       (fi-glk-dsi)
        Subgroup basic-busy-flip-before-cursor-legacy:
                pass       -> SKIP       (fi-glk-dsi)
Test kms_frontbuffer_tracking:
        Subgroup basic:
                fail       -> SKIP       (fi-glk-dsi) fdo#103167
Test kms_pipe_crc_basic:
        Subgroup hang-read-crc-pipe-a:
                pass       -> DMESG-FAIL (fi-glk-dsi)
        Subgroup hang-read-crc-pipe-b:
                pass       -> DMESG-FAIL (fi-glk-dsi)
        Subgroup hang-read-crc-pipe-c:
                pass       -> DMESG-FAIL (fi-glk-dsi)
        Subgroup suspend-read-crc-pipe-a:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup suspend-read-crc-pipe-b:
                dmesg-warn -> PASS       (fi-byt-j1900) fdo#101705

fdo#102582 https://bugs.freedesktop.org/show_bug.cgi?id=102582
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:437s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:451s
fi-blb-e6850     total:289  pass:223  dwarn:1   dfail:0   fail:0   skip:65  time:378s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:524s
fi-bwr-2160      total:289  pass:183  dwarn:0   dfail:0   fail:0   skip:106 time:267s
fi-bxt-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:499s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:498s
fi-byt-j1900     total:289  pass:254  dwarn:0   dfail:0   fail:0   skip:35  time:498s
fi-byt-n2820     total:289  pass:249  dwarn:1   dfail:0   fail:0   skip:39  time:477s
fi-cnl-y         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:613s
fi-elk-e7500     total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:424s
fi-gdg-551       total:289  pass:172  dwarn:1   dfail:0   fail:7   skip:109 time:251s
fi-glk-1         total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:581s
fi-glk-dsi       total:289  pass:186  dwarn:1   dfail:4   fail:0   skip:98  time:386s
fi-hsw-4770      total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:445s
fi-hsw-4770r     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:429s
fi-ilk-650       total:289  pass:228  dwarn:0   dfail:0   fail:0   skip:61  time:427s
fi-ivb-3520m     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:495s
fi-ivb-3770      total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:460s
fi-kbl-7500u     total:289  pass:264  dwarn:1   dfail:0   fail:0   skip:24  time:491s
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:575s
fi-kbl-7567u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:481s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:589s
fi-pnv-d510      total:289  pass:222  dwarn:1   dfail:0   fail:0   skip:66  time:547s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:456s
fi-skl-6600u     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:594s
fi-skl-6700hq    total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:649s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:522s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:502s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:455s
fi-snb-2520m     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:569s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:0   skip:40  time:423s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_432/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

✓ Fi.CI.BAT: success for tools/intel_vbt_decode: Fix HDMI level shifter and max data rate bitfield sizes

In reply to Ville Syrjala
== Series Details ==

== Series Details ==

Series: tools/intel_vbt_decode: Fix HDMI level shifter and max data rate bitfield sizes
URL : https://patchwork.freedesktop.org/series/32786/
State : success

== Summary ==

IGT patchset tested on top of latest successful build 1fc4de1ca390adec9be8bd7cc0c36cab07465959 igt/gem_exec_latency: Wire up an interloper for preemption

with latest DRM-Tip kernel build CI_DRM_3294
2dd14a4ad87f drm-tip: 2017y-10m-30d-13h-40m-22s UTC integration manifest

No testlist changes.

Test debugfs_test:

        Subgroup read_all_entries:
                dmesg-warn -> PASS       (fi-cfl-s)
Test drv_getparams_basic:
        Subgroup basic-eu-total:
                dmesg-warn -> PASS       (fi-cfl-s)
        Subgroup basic-subslice-total:
                dmesg-warn -> PASS       (fi-cfl-s)
Test drv_hangman:
        Subgroup error-state-basic:
                dmesg-warn -> PASS       (fi-cfl-s)
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                pass       -> DMESG-WARN (fi-byt-n2820) fdo#101705

fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:442s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:457s
fi-blb-e6850     total:289  pass:223  dwarn:1   dfail:0   fail:0   skip:65  time:380s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:526s
fi-bwr-2160      total:289  pass:183  dwarn:0   dfail:0   fail:0   skip:106 time:265s
fi-bxt-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:498s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:502s
fi-byt-j1900     total:289  pass:253  dwarn:1   dfail:0   fail:0   skip:35  time:500s
fi-byt-n2820     total:289  pass:249  dwarn:1   dfail:0   fail:0   skip:39  time:486s
fi-cfl-s         total:289  pass:253  dwarn:4   dfail:0   fail:0   skip:32  time:548s
fi-cnl-y         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:605s
fi-elk-e7500     total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:425s
fi-gdg-551       total:289  pass:178  dwarn:1   dfail:0   fail:1   skip:109 time:252s
fi-glk-1         total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:587s
fi-glk-dsi       total:289  pass:258  dwarn:0   dfail:0   fail:1   skip:30  time:488s
fi-hsw-4770      total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:428s
fi-hsw-4770r     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:428s
fi-ilk-650       total:289  pass:228  dwarn:0   dfail:0   fail:0   skip:61  time:422s
fi-ivb-3520m     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:482s
fi-ivb-3770      total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:464s
fi-kbl-7500u     total:289  pass:264  dwarn:1   dfail:0   fail:0   skip:24  time:495s
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:577s
fi-kbl-7567u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:475s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:579s
fi-pnv-d510      total:289  pass:222  dwarn:1   dfail:0   fail:0   skip:66  time:551s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:451s
fi-skl-6600u     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:594s
fi-skl-6700hq    total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:636s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:523s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:501s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:459s
fi-snb-2520m     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:566s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:0   skip:40  time:424s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_444/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

✗ Fi.CI.IGT: warning for tools/intel_vbt_decode: Fix HDMI level shifter and max data rate bitfield sizes

In reply to Ville Syrjala
== Series Details ==

== Series Details ==

Series: tools/intel_vbt_decode: Fix HDMI level shifter and max data rate bitfield sizes
URL : https://patchwork.freedesktop.org/series/32786/
State : warning

== Summary ==

Test kms_flip:

        Subgroup wf_vblank-vs-dpms:
                dmesg-warn -> PASS       (shard-hsw) fdo#102614
Test kms_setmode:
        Subgroup basic:
                pass       -> FAIL       (shard-hsw) fdo#99912
Test gem_tiled_swapping:
        Subgroup non-threaded:
                incomplete -> PASS       (shard-hsw)
Test kms_busy:
        Subgroup extended-modeset-hang-newfb-with-reset-render-B:
                pass       -> DMESG-WARN (shard-hsw) fdo#103038
        Subgroup extended-modeset-hang-oldfb-with-reset-render-A:
                pass       -> DMESG-WARN (shard-hsw) fdo#102249 +1
Test kms_plane:
        Subgroup plane-panning-top-left-pipe-A-planes:
                pass       -> SKIP       (shard-hsw)

fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#103038 https://bugs.freedesktop.org/show_bug.cgi?id=103038
fdo#102249 https://bugs.freedesktop.org/show_bug.cgi?id=102249

shard-hsw total:2539 pass:1429 dwarn:3 dfail:0 fail:9 skip:1098 time:9062s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_444/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx