Skip to contentSkip to conversation

watchdog: mei_wdt: don't use of variable length array

watchdog Tomas Winkler 2 participants 2 messages Oct 29, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Fixes sparse warning:
drivers/watchdog/mei_wdt.c:530:18: warning: Variable length array is used

---
 drivers/watchdog/mei_wdt.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/watchdog/mei_wdt.c +3 -4
index ea60b29494fb..b8194b02abe0 100644
@@ -526,12 +526,11 @@ static ssize_t mei_dbgfs_read_state(struct file *file, char __user *ubuf,
 				    size_t cnt, loff_t *ppos)
 {
 	struct mei_wdt *wdt = file->private_data;
-	const size_t bufsz = 32;
-	char buf[bufsz];
+	char buf[32];
 	ssize_t pos;
 
-	pos = scnprintf(buf, bufsz, "state: %s\n",
-			 mei_wdt_state_str(wdt->state));
+	pos = scnprintf(buf, sizeof(buf), "state: %s\n",
+			mei_wdt_state_str(wdt->state));
 
 	return simple_read_from_buffer(ubuf, cnt, ppos, buf, pos);
 }
Signature · 1 line
2.9.5
maintainer Reviewed-by
#1 lore raw
Quoted 5 lines · Tomas Winkler

Fixes sparse warning:
drivers/watchdog/mei_wdt.c:530:18: warning: Variable length array is used

Quoted 25 lines
---
  drivers/watchdog/mei_wdt.c | 7 +++----
  1 file changed, 3 insertions(+), 4 deletions(-)
drivers/watchdog/mei_wdt.c +3 -4
index ea60b29494fb..b8194b02abe0 100644
@@ -526,12 +526,11 @@ static ssize_t mei_dbgfs_read_state(struct file *file, char __user *ubuf,
  				    size_t cnt, loff_t *ppos)
  {
  	struct mei_wdt *wdt = file->private_data;
-	const size_t bufsz = 32;
-	char buf[bufsz];
+	char buf[32];
  	ssize_t pos;
 
-	pos = scnprintf(buf, bufsz, "state: %s\n",
-			 mei_wdt_state_str(wdt->state));
+	pos = scnprintf(buf, sizeof(buf), "state: %s\n",
+			mei_wdt_state_str(wdt->state));
 
  	return simple_read_from_buffer(ubuf, cnt, ppos, buf, pos);
  }