ltp: fix some frequent typoes
PATCH v3 1/2 ltp: fix some frequent typoes
These are high-frequency easily misspelled words: kernel|memory|filesystem|network.
--- doc/test-writing-guidelines.txt | 2 +- include/old/old_device.h | 2 +- include/tst_safe_macros.h | 2 +- testcases/kernel/containers/TEST_PLAN.txt | 2 +- testcases/kernel/controllers/memcg/functional/memcg_stat_test.sh | 2 +- testcases/kernel/device-drivers/agp/kernel_space/tagp.c | 2 +- testcases/kernel/device-drivers/agp/kernel_space/tagp.h | 2 +- testcases/kernel/device-drivers/agp/user_space/user_tagp.c | 2 +- testcases/kernel/fs/fs-bench/modaltr.sh | 2 +- testcases/network/iptables/iptables_tests.sh | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-)
doc/test-writing-guidelines.txt +1 -1
@@ -822,7 +822,7 @@ Aligns the x to be next multiple of a. The a must be power of 2. 2.2.12 Filesystem type detection ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ -Some tests are known to fail on certain filesytems (you cannot swap on TMPFS, +Some tests are known to fail on certain filesystems (you cannot swap on TMPFS, there are unimplemented 'fcntl()' etc.). If your test needs to be skipped on certain filesystems, use the interface
include/old/old_device.h +1 -1
@@ -21,7 +21,7 @@/* * Returns filesystem type to be used for the testing. Unless your test is * designed for specific filesystem you should use this function to the tested -* filesytem. +* filesystem. * * If TST_DEV_FS_TYPE is set the function returns it's content, * otherwise default fs type hardcoded in the library is returned.
include/tst_safe_macros.h +1 -1
@@ -406,7 +406,7 @@ static inline sighandler_t safe_signal(const char *file, const int lineno,#define SAFE_EXECL (file, arg, ...) do { \ execl((file), (arg), ##__VA_ARGS__); \ tst_brk_(__FILE__, __LINE__, TBROK | TERRNO, \ - "execlp(%s, %s, ...) failed", file, arg); \ + "execl(%s, %s, ...) failed", file, arg); \ } while (0)int safe_getpriority (const char *file,const int lineno,int which,id_t who);
testcases/kernel/containers/TEST_PLAN.txt +1 -1
@@ -19,7 +19,7 @@ Following are tentative Testcases to be included into LTP-Containers in future: NAME TENTATIVE-TIME ================================================================================= PID NAMESPACES (NEAR FUTURE) -NETWROK NAMESPACES (NEAR FUTURE) +NETWORK NAMESPACES (NEAR FUTURE) POSIX IPC NAMESPACES (NEAR FUTURE) TTY+CONSOLE+DEVPTS NAMESPACES (NEAR FUTURE) PROC+SYSFS ISOLATION (NEAR FUTURE)
testcases/kernel/controllers/memcg/functional/memcg_stat_test.sh +1 -1
@@ -21,7 +21,7 @@ ################################################################################ # # File : memcg_stat_test.sh -# Description: Tests memroy.stat. +# Description: Tests memory.stat. # Author: Peng Haitao <[email protected]> # History: 2012/01/16 - Created. #
testcases/kernel/device-drivers/agp/kernel_space/tagp.c +1 -1
@@ -216,7 +216,7 @@ static int tagp_ioctl(struct inode *ino, struct file *f,case TEST_GENERIC_FREE_GATT_TABLE : rc =test_agp_generic_free_gatt_table ();break ; -case TEST_GENERIC_INSERT_MEMROY : +case TEST_GENERIC_INSERT_MEMORY : rc =test_agp_generic_insert_memory ();break ;case TEST_GENERIC_ALLOC_BY_TYPE :
testcases/kernel/device-drivers/agp/kernel_space/tagp.h +1 -1
@@ -55,7 +55,7 @@#define TEST_NUM_ENTRIES _IO(MAG_NUM, 12)#define TEST_GENERIC_CREATE_GATT_TABLE _IO(MAG_NUM, 13)#define TEST_GENERIC_FREE_GATT_TABLE _IO(MAG_NUM, 14) -#define TEST_GENERIC_INSERT_MEMROY _IO(MAG_NUM, 15) +#define TEST_GENERIC_INSERT_MEMORY _IO(MAG_NUM, 15)#define TEST_GENERIC_ALLOC_BY_TYPE _IO(MAG_NUM, 16)#define TEST_GENERIC_ALLOC_PAGE _IO(MAG_NUM, 17)#define TEST_ENABLE _IO(MAG_NUM, 19)
testcases/kernel/device-drivers/agp/user_space/user_tagp.c +1 -1
@@ -249,7 +249,7 @@ int main()printf ("Success on agp_generic_free_gatt_table\n" );/* make test calls for agp_generic_insert_memory */ -if (ki_generic (tagp_fd,TEST_GENERIC_INSERT_MEMROY )) +if (ki_generic (tagp_fd,TEST_GENERIC_INSERT_MEMORY ))printf ("Fail on agp_generic_insert_memory\n" );else printf ("Success on agp_generic_insert_memory\n" );
testcases/kernel/fs/fs-bench/modaltr.sh +1 -1
@@ -6,7 +6,7 @@ # 4.you should have fs-bench utility (http://h2np.net/tools/fs-bench-0.2.tar.gz) # 5.results will be copied to /tmp/log and /tmp/log1 files -#DESCRIPTION: This testscript creates a jffs2 file system type and tests the filesytem test +#DESCRIPTION: This testscript creates a jffs2 file system type and tests the filesystem test #and places the log in the log directory.The file system test actually creates a tree of large #directories and performs the delete and random delete operations as per the filesystem stress #algorithim and gives a report of real time ,user time,system time taken to perform the file
testcases/network/iptables/iptables_tests.sh +1 -1
@@ -36,7 +36,7 @@ init() if [ $? -ne 0 ]; then iptables -L > tst_iptables.out 2>&1 if [ $? -ne 0 ]; then - tst_brkm TBROK "no iptables support in kenrel." + tst_brkm TBROK "no iptables support in kernel." fi fi
Signature · 1 line
2.9.3
PATCH v3 1/2 ltp: fix some frequent typoes
Hi!
include/tst_safe_macros.h static inline sighandler_t safe_signal(const char *file, const int lineno, · line 410
Quoted 11 lines
include/tst_safe_macros.h +1
-1@@ -406,7 +406,7 @@ static inline sighandler_t safe_signal(const char *file, const int lineno,#define SAFE_EXECL (file, arg, ...) do { \ execl((file), (arg), ##__VA_ARGS__); \ tst_brk_(__FILE__, __LINE__, TBROK | TERRNO, \ - "execlp(%s, %s, ...) failed", file, arg); \ + "execl(%s, %s, ...) failed", file, arg); \ } while (0)
Can you, pretty please, put this change into a separate patch?
Since the rest of the changes are just fixing typos, there is no change in behaivor. But this one actually changes it and there is even no description for it in the commit message.
Signature · 2 lines
Cyril Hrubis [email protected]
PATCH v3 1/2 ltp: fix some frequent typoes
Quoted 14 lines · Cyril Hrubis
Hi!
include/tst_safe_macros.h static inline sighandler_t safe_signal(const char *file, const int lineno, · line 410
Quoted 11 lines
include/tst_safe_macros.h +1
-1@@ -406,7 +406,7 @@ static inline sighandler_t safe_signal(const char *file, const int lineno,#define SAFE_EXECL (file, arg, ...) do { \ execl((file), (arg), ##__VA_ARGS__); \ tst_brk_(__FILE__, __LINE__, TBROK | TERRNO, \ - "execlp(%s, %s, ...) failed", file, arg); \ + "execl(%s, %s, ...) failed", file, arg); \ } while (0)Can you, pretty please, put this change into a separate patch?
Of course I can. But this is still a typo which was involved by:
commit 3a4772603733e5be11b367e156723aa554c4a1fc
Author: Li Wang <[email protected]> Date: Thu Oct 12 11:27:59 2017 +0200
creat07: switch EXECLP to EXECL
Quoted 4 lines
Since the rest of the changes are just fixing typos, there is no change in behaivor. But this one actually changes it and there is even no description for it in the commit message.
Sorry, I feel a little confused.
This typo only in the printed messages but without any behavior changing too. The situation is that if execl() get failed and then tst_brk do exist with the typo print.
Anyway, if you insist that I could write a new patch for it. :)
Signature · 2 lines
Li Wang [email protected]
PATCH v3 1/2 ltp: fix some frequent typoes
Hi!
Quoted 9 lines
Quoted 3 lines
Since the rest of the changes are just fixing typos, there is no change in behaivor. But this one actually changes it and there is even no description for it in the commit message.
Sorry, I feel a little confused.
This typo only in the printed messages but without any behavior changing too. The situation is that if
execl()get failed and thentst_brkdo exist with the typo print.
My bad, I was blind yesterday evening and confused the line in the message with the line that actually calls the syscall. I will take the patch as it is and sorry for the confusion.
Signature · 2 lines
Cyril Hrubis [email protected]
PATCH v3 1/2 ltp: fix some frequent typoes
In reply to Li WangHi!
Pushed, thanks.
Signature · 2 lines
Cyril Hrubis [email protected]