Skip to contentSkip to conversation

platform/x86: intel_telemetry: add back linux/io.h inclusion

PATCH In review Arnd Bergmann 2 participants 2 messages Nov 2, 2017 – Nov 3, 2017 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: intel_telemetry: add back linux/io.h inclusion

This one wasn't redundant after all, as shown by this randconfig build error:

drivers/platform/x86/intel_telemetry_pltdrv.c: In function 'telem_evtlog_read':
drivers/platform/x86/intel_telemetry_pltdrv.c:900:20: error: implicit declaration of function 'readq' [-Werror=implicit-function-declaration]

We should generally include exactly the set of headers that declare the interfaces we use, so this adds back the missing include to get it to compile again.

Fixes a5e50220edbd ("platform/x86: intel_telemetry: cleanup redundant headers")
---
 drivers/platform/x86/intel_telemetry_pltdrv.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/intel_telemetry_pltdrv.c +1 -0
index 678abf2e9e92..45f790a22ca2 100644
@@ -16,6 +16,7 @@
  * It used the PUNIT and PMC IPC interfaces for configuring the counters.
  * The accumulated results are fetched from SRAM.
  */
+#include <linux/io.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
 
Signature · 1 line
2.9.0
#1 lore raw
Quoted 9 lines · Arnd Bergmann

This one wasn't redundant after all, as shown by this randconfig build error:

drivers/platform/x86/intel_telemetry_pltdrv.c: In function 'telem_evtlog_read':
drivers/platform/x86/intel_telemetry_pltdrv.c:900:20: error: implicit declaration of function 'readq' [-Werror=implicit-function-declaration]

We should generally include exactly the set of headers that declare the interfaces we use, so this adds back the missing include to get it to compile again.

Thanks Arnd, Andy already caught this and has it queued.

Signature · 2 lines
Darren Hart
VMware Open Source Technology Center